[digikam] [Bug 366361] New: createReadWriteLock and createMetadataProcessor should not be pure virtual

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366361

            Bug ID: 366361
           Summary: createReadWriteLock and createMetadataProcessor should
                    not be pure virtual
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkipi
          Assignee: [hidden email]
          Reporter: [hidden email]

Created attachment 100422
  --> https://bugs.kde.org/attachment.cgi?id=100422&action=edit
Make createReadWriteLock and createMetadataProcessor not-pure.

If an application does not implement the features HostSupportsReadWriteLock and
HostSupportsMetadataProcessing, the current API still expects the host
application to provide the functions createReadWriteLock and
createMetadataProcessor.

Both methods are already implemented in interface.cpp, so it seems to me that
making them pure virtual was actually a mistake...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366361

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.1.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |ipi/860f11a91c9398397246bf5
                   |                            |54e24ff9b8b3adc6d
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Maik Qualmann <[hidden email]> ---
Git commit 860f11a91c9398397246bf554e24ff9b8b3adc6d by Maik Qualmann.
Committed on 03/08/2016 at 16:35.
Pushed by mqualmann into branch 'master'.

apply patch #100422 to make implemented methods not pure virtual
FIXED-IN: 5.1.0

M  +2    -2    src/interface.h

http://commits.kde.org/libkipi/860f11a91c9398397246bf554e24ff9b8b3adc6d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366361

--- Comment #2 from [hidden email] ---
Git commit 593cf8bf10349ce459fdf26c800f9b5b3301a4b3 by Gilles Caulier.
Committed on 04/08/2016 at 09:36.
Pushed by cgilles into branch 'master'.

fix ABI/API ID since pure virtual method fingerprints have changed.

M  +3    -2    CMakeLists.txt

http://commits.kde.org/libkipi/593cf8bf10349ce459fdf26c800f9b5b3301a4b3

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366361

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]       |[hidden email]
          Component|libkipi                     |General
            Product|digikam                     |libkipi

--
You are receiving this mail because:
You are the assignee for the bug.