https://bugs.kde.org/show_bug.cgi?id=359658
Bug ID: 359658 Summary: Compilation of preprocesstask.cpp fails if QT_NO_CAST_FROM_ASCII is defined Product: digikam Version: 5.0.0 Platform: Gentoo Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: Panorama Assignee: [hidden email] Reporter: [hidden email] Found this problem today while trying to compile the digikam-9999 ebuild (git master) on my Gentoo system. Apparently, QT_NO_CAST_FROM_ASCII is defined on my side, causing the QString(const * char) c'tor to be private. As a consequence I was not able to compile preprocesstask.cpp without modifying it, such that QImg::save(const QString&, FORMAT, DImgLoaderObserver* const) gets called in PreProcessTask::computePreview(const QUrl& inUrl) instead. The patch is included in the "Additional Information" section. Reproducible: Always diff --git a/utilities/assistants/panorama/tasks/preprocesstask.cpp b/utilities/assistants/panorama/tasks/preprocesstask.cpp index 8efc607..49f9972 100644 --- a/utilities/assistants/panorama/tasks/preprocesstask.cpp +++ b/utilities/assistants/panorama/tasks/preprocesstask.cpp @@ -133,7 +133,7 @@ bool PreProcessTask::computePreview(const QUrl& inUrl) if (img.load(inUrl.toLocalFile())) { DImg preview = img.smoothScale(1280, 1024, Qt::KeepAspectRatio); - bool saved = preview.save(outUrl.toLocalFile(), "JPG"); + bool saved = preview.save(outUrl.toLocalFile(), Digikam::DImg::FORMAT::JPEG); // save exif information also to preview image for auto rotation if (saved) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
https://bugs.kde.org/show_bug.cgi?id=359658
--- Comment #1 from [hidden email] --- Created attachment 97347 --> https://bugs.kde.org/attachment.cgi?id=97347&action=edit qt-no-cast-from-ascii.patch -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=359658
--- Comment #2 from [hidden email] --- Added the patch as an attachment as well now. Sorry for the inconvenience, but I did not find an attachment field in the first form, hence I added it as "Additional Information" ... -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=359658
Maik Qualmann <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |5.0.0 Status|UNCONFIRMED |RESOLVED Latest Commit| |http://commits.kde.org/digi | |kam/b0f728ed31de2ebebe68394 | |f856df0be388d3d04 Resolution|--- |FIXED --- Comment #3 from Maik Qualmann <[hidden email]> --- Git commit b0f728ed31de2ebebe68394f856df0be388d3d04 by Maik Qualmann. Committed on 22/02/2016 at 07:07. Pushed by mqualmann into branch 'master'. apply patch #97347 to correct DImg save format option FIXED-IN: 5.0.0 M +2 -2 NEWS M +1 -1 utilities/assistants/panorama/tasks/preprocesstask.cpp http://commits.kde.org/digikam/b0f728ed31de2ebebe68394f856df0be388d3d04 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |