[digikam] [Bug 358081] New: Various small issues creating, editing and deleting Tags

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

            Bug ID: 358081
           Summary: Various small issues creating, editing and deleting
                    Tags
           Product: digikam
           Version: 4.14.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]

1. When I create a tag, I can set an icon for this tag. But when I edit a tag
in the right sidebar panel, I cannot change that icon - selecting one works but
the new icon is not saved upon clicking "save" and resets when I select another
tag.
2. When I delete an icon using the context menu, the confirmation dialog says
"Delete tag ''?" (in German "Stichwort '' löschen?" ie. an empty string instead
of the tag name. When I use the "-" toolbar icon to delete, the tag name is
correctly inserted.

Wishlist:
3. In the tag editor sidebar, F2 (if one tag is selected) should open the
editor dialog and focus the tag name field, and "ENTER" in any text entry field
(eg. name) should save and close the editor sidebar and focus the tag list so
that I can select the next tag to be edited.


Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Various small issues        |Tags Manager - selecting
                   |creating, editing and       |tags from tree-view do not
                   |deleting Tags               |focus tags title field in
                   |                            |right sidebar
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
1/ ==> see bug #216637 : it's a generic issue with PAlbum and TAlbum.
2/ ==> not reproducible with current implementation (5.0.0)
3/ ==> F2 is used to rename icon view item selected if one exist in TAlbum, F2
has no effect.

Typically, this king of improvement must be implemented in Tags Manager window,
not in Album view. When you select a tag from list, the tag properties is
automatically updated. Note that no focus is given in tag title field.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Git commit 130ff08145ab51cf157d45eede04c7f3e3e5a019 by Maik Qualmann.
Committed on 17/01/2016 at 08:43.
Pushed by mqualmann into branch 'master'.

fix TAlbum icon update

M  +0    -1    libs/album/albummanager.cpp

http://commits.kde.org/digikam/130ff08145ab51cf157d45eede04c7f3e3e5a019

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Maik Qualmann <[hidden email]> ---
1) is resolved with the commit from Comment 2
2) is here also not to reproduce with digiKam-5.0.0-beta3

I think we can close this bug.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

--- Comment #4 from [hidden email] ---
Maik,

For the point 3, look my comment from #1 :

"Typically, this king of improvement must be implemented in Tags Manager
window, not in Album view. When you select a tag from list, the tag properties
is automatically updated. Note that no focus is given in tag title field."

This want mean that Tags Manager need to be patched about focus policy while
editing. This is why i changed the bug title.

What's about generic bug #216637 with point 1/ ? PAlbum icon is the same
problem than TAlbum or it's completely different ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

--- Comment #5 from Maik Qualmann <[hidden email]> ---
(In reply to caulier.gilles from comment #4)
> For the point 3, look my comment from #1 :

Yes, that's right a bit uncomfortable in the Tags Manager.

> What's about generic bug #216637 with point 1/ ? PAlbum icon is the same
> problem than TAlbum or it's completely different ?

As I see as different. PAlbum can only use image from the album as icon. TAlbum
uses KDE icons. I find fine.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.0.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/cd60812cde0e931db701a07
                   |                            |1224537d3c98771c4
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Git commit cd60812cde0e931db701a071224537d3c98771c4 by Maik Qualmann.
Committed on 11/02/2016 at 20:05.
Pushed by mqualmann into branch 'master'.

edit the title in Tags Manager with F2 key
FIXED-IN: 5.0.0

M  +2    -1    NEWS
M  +26   -10   libs/tags/tagsmanager/tagmngrtreeview.cpp
M  +22   -7    libs/tags/tagsmanager/tagpropwidget.cpp
M  +6    -0    libs/tags/tagsmanager/tagpropwidget.h
M  +73   -27   libs/tags/tagsmanager/tagsmanager.cpp
M  +10   -0    libs/tags/tagsmanager/tagsmanager.h

http://commits.kde.org/digikam/cd60812cde0e931db701a071224537d3c98771c4

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358081

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tags                        |Tags-Manager

--
You are receiving this mail because:
You are the assignee for the bug.