[digikam] [Bug 351866] New: Make auto focus to input field after adding a face rectangle as an option and not by default

[Stas]

https://bugs.kde.org/show_bug.cgi?id=351866

            Bug ID: 351866
           Summary: Make auto focus to input field after adding a face
                    rectangle as an option and not by default
           Product: digikam
           Version: 4.12.0
          Platform: Archlinux Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Usability
          Assignee: [hidden email]
          Reporter: [hidden email]

Hello,

I see now, that a new focus feature is realized in the actual version 4.12.

https://bugs.kde.org/show_bug.cgi?id=345184

Here is the feature request

Can you change this feature  so one can optionally turn it on and off.

I have a different work flow (as I think this is the fastest one): I first go
through all pictures and draw rectangles in case there are not already there.
Than I go to face menu and just select all faces of the same person and assign
the face tag. This way I have to type the name only once. With the new focus I
can not move from picture to picture fast (with shortcuts) but have to do it
with the mouse.

Please do it as an option ;)

Thanks ;)

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=351866

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Maik Qualmann <[hidden email]> ---
I can navigate with focus in the input field with the up and down cursor keys
to next image.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351866

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Usability                   |Face Management

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351866

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make auto focus to input    |Make focus to input field
                   |field after adding a face   |after adding a face
                   |rectangle as an option and  |rectangle as an option and
                   |not by default              |not by default

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

Yingjie Liu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Yingjie Liu <[hidden email]> ---
Created attachment 104401
  --> https://bugs.kde.org/attachment.cgi?id=104401&action=edit
Action added for controlling the focus in the text field

Hi,
I add a QAction in the toolbar beside the "Show Fullscreen" action, which is
shown in attachment "icon". I added a flag in FaceGroup class which can be
changed by toggling the new action. The value of the flag will be conveyed to
class AssignNameWidget, and a flag called noFocus will have the same value.
Then in function showEvent(QShowEvent* e), if noFocus is true, the function
will return with no focus in the text field.
If user click the new action, there will be no focus in the text field after he
draw a new face rectangle, as shown in attachment "no_focus".
If user click the new action again, there will be focus in the text field after
he draw a new face rectangle, as shown in attachment "has_focus".
I commented the patch for readability.
If there are more easier method, I will try it and change the code.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

--- Comment #3 from Yingjie Liu <[hidden email]> ---
Created attachment 104402
  --> https://bugs.kde.org/attachment.cgi?id=104402&action=edit
icon

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

--- Comment #4 from Yingjie Liu <[hidden email]> ---
Created attachment 104403
  --> https://bugs.kde.org/attachment.cgi?id=104403&action=edit
no focus

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

--- Comment #5 from Yingjie Liu <[hidden email]> ---
Created attachment 104404
  --> https://bugs.kde.org/attachment.cgi?id=104404&action=edit
has focus

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

Wolfgang Scheffner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Wolfgang Scheffner <[hidden email]> ---
(In reply to Yingjie Liu from comment #2)
> Created attachment 104401 [details]
> Action added for controlling the focus in the text field
>
> Hi,
> I add a QAction in the toolbar beside the "Show Fullscreen" action, ...

Just something about usability / GUI: I don't like the idea of having that
action in the Main Toolbar. Should be better somewhere in the Left Sidebar so
that it disappears once you leave People View.

Wolfgang Scheffner (documenter)

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

--- Comment #7 from Yingjie Liu <[hidden email]> ---
(In reply to Wolfgang Scheffner from comment #6)

> (In reply to Yingjie Liu from comment #2)
> > Created attachment 104401 [details]
> > Action added for controlling the focus in the text field
> >
> > Hi,
> > I add a QAction in the toolbar beside the "Show Fullscreen" action, ...
>
> Just something about usability / GUI: I don't like the idea of having that
> action in the Main Toolbar. Should be better somewhere in the Left Sidebar
> so that it disappears once you leave People View.
>
> Wolfgang Scheffner (documenter)

Hi, Wolfgang,
I added the action in the people's view which is shown in attachment "which
region", and it will disappear when user leave people view. Do you mean that I
have to add the action in region A (which is able to add a left sidebar) I
circled in attachment "which region"? Thanks.
Yingjie Liu

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

--- Comment #8 from Yingjie Liu <[hidden email]> ---
Created attachment 104423
  --> https://bugs.kde.org/attachment.cgi?id=104423&action=edit
which region

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=351866

--- Comment #9 from Wolfgang Scheffner <[hidden email]> ---
(In reply to Yingjie Liu from comment #7)

Sorry, I got it wrong. "...in the toolbar beside the "Show Fullscreen" action,
" lead me somehow to the Main Toolbar right under the main menu. You were
talking about the toolbar of the preview. That's absolutely okay, leave it
there!


> and it will disappear when user leave people view. ...

Well, the preview is used in other views too but since it always have the
add-face-tag icon its a must that your new icon will show up there as well
(which it probably does anyway).

Wolfgang Scheffner

--
You are receiving this mail because:
You are the assignee for the bug.