[digikam] [Bug 347053] New: BQM: "batched' files" are diffrent from manualay processed files

[Axel Krebs]

https://bugs.kde.org/show_bug.cgi?id=347053

            Bug ID: 347053
           Summary: BQM: "batched' files" are diffrent from manualay
                    processed files
           Product: digikam
           Version: 4.9.0
          Platform: Kubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Batch Queue Manager
          Assignee: [hidden email]
          Reporter: [hidden email]

BQM is a powerful tool, if working properly.

Over the time, I found, that manually processed filed differ seriously from the
same files processed manually.



Reproducible: Always

Steps to Reproduce:
1. I us a sequence of tools to adjust selected pics of mine to a transportbale
and worthy treated version of these. The sequence might be as follows:
- apply metadata (incl. copyright information)
- sizing
- extreact noise
- sharpening
- write "signature"
- save a "jpg"

2.
3.

Actual Results:  
results differ from BQB to manually processed pics (same sequence of tools!!!)

Expected Results:  
a result should always be independent from the way it is achieved...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Maik Qualmann <[hidden email]> ---
What is the difference exactly? Is the difference in the picture visible? I
have now found that the file sizes are very different. BQM used for example not
the settings for JPG compression and always uses the default value of 75. I
will correct it.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Created attachment 92438
  --> https://bugs.kde.org/attachment.cgi?id=92438&action=edit
BQMsaveImage.patch

This patch uses now in BQM the settings for quality, compression, etc. when
saving a JPEG, TIFF, PNG, JPEG2000 or PGF image.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=347053

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Maik,

I think it's patched at the wrong place.

Also calling KConfig & co here will be not thread safe (if i remember).

BQM queue global have settings passed from GUI to background processing. For
ex, this settings take RAW processing settings from digiKam config to the
queue. The same way must be used to pass JPEG/PNG/TIFF/etc. settings. And
typically, this must be already done. If it doesn't work this is a bug with
current implementation.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92438|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #4 from Maik Qualmann <[hidden email]> ---
Gilles,

yes, KConfig in threads is not safe. But I think the place to set the DImg
attributes is right. It is the last point before the image is saved. By analogy
with the RAW decoding settings I would implement it with the IOFileSettings
container.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #5 from Maik Qualmann <[hidden email]> ---
Created attachment 92475
  --> https://bugs.kde.org/attachment.cgi?id=92475&action=edit
BQMsaveImage2.patch

New patch to set up the digiKam settings for saving. The conversion tools
(convert2jpg) use their settings. A new tab in the queue settings for saving
would also possible.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #6 from Gilles Caulier <[hidden email]> ---
The patch look good for me.

A new iofilesettings panel can be add to BQM Queue settings. This imply to
store/restore these settings to/from XML queue file if user decide to save
queue configuration.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92475|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Created attachment 92486
  --> https://bugs.kde.org/attachment.cgi?id=92486&action=edit
BQMsaveImage3.patch

New patch for testing with queues settings for saving.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #8 from Gilles Caulier <[hidden email]> ---
patch work perfectly here..

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=347053

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|BQM: "batched' files" are   |BQM: "batched' files" are
                   |diffrent from manualay      |different from manualy
                   |processed files             |processed files

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=347053

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|BQM: "batched' files" are   |BQM: "batched' files" are
                   |different from manualy      |different from manually
                   |processed files             |processed files [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92486|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Created attachment 92491
  --> https://bugs.kde.org/attachment.cgi?id=92491&action=edit
BQMsaveImage4.patch

Only one value name in the queue XML file changed.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #10 from Gilles Caulier <[hidden email]> ---
fine to commit

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=347053

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.10.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/5d3eff04851759ec6cc0603
                   |                            |8e5cc3e217856a7da
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #11 from Maik Qualmann <[hidden email]> ---
Git commit 5d3eff04851759ec6cc06038e5cc3e217856a7da by Maik Qualmann.
Committed on 08/05/2015 at 17:10.
Pushed by mqualmann into branch 'master'.

apply patch #92491 to added queue settings for saving images
FIXED-IN: 4.10.0

M  +2    -1    NEWS
M  +38   -0    utilities/queuemanager/manager/batchtool.cpp
M  +9    -0    utilities/queuemanager/manager/batchtool.h
M  +6    -0    utilities/queuemanager/manager/queuesettings.h
M  +1    -0    utilities/queuemanager/manager/task.cpp
M  +64   -0    utilities/queuemanager/manager/workflowmanager.cpp
M  +126  -2    utilities/queuemanager/views/queuesettingsview.cpp

http://commits.kde.org/digikam/5d3eff04851759ec6cc06038e5cc3e217856a7da

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=347053

--- Comment #12 from Gilles Caulier <[hidden email]> ---
Git commit 9dcb00b99bda74acbabeb0689420206bd081a615 by Gilles Caulier.
Committed on 08/05/2015 at 20:51.
Pushed by cgilles into branch 'frameworks'.

backport commit #5d3eff04851759ec6cc06038e5cc3e217856a7da from git/master to
frameworks branch

M  +38   -0    utilities/queuemanager/manager/batchtool.cpp
M  +9    -0    utilities/queuemanager/manager/batchtool.h
M  +6    -0    utilities/queuemanager/manager/queuesettings.h
M  +1    -0    utilities/queuemanager/manager/task.cpp
M  +64   -0    utilities/queuemanager/manager/workflowmanager.cpp
M  +126  -2    utilities/queuemanager/views/queuesettingsview.cpp

http://commits.kde.org/digikam/9dcb00b99bda74acbabeb0689420206bd081a615

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=347053

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Workflow

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel