[digikam] [Bug 345954] New: Recursive calls made into ProgressManager::slotTransactionCompletedDeferred

[Kristian Karl]

https://bugs.kde.org/show_bug.cgi?id=345954

            Bug ID: 345954
           Summary: Recursive calls made into
                    ProgressManager::slotTransactionCompletedDeferred
           Product: digikam
           Version: 4.9.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Progress Manager
          Assignee: [hidden email]
          Reporter: [hidden email]

When removing thousands of face tags from thousands of images, I noticed that
the process of removal of face tags took way to long time.

1) I have a test set of 3152 images. Those images have 1738 face tags
2) In the "People view", I select all  (1738) face tags.
3) I click on the "Reject if this is not a face" button (Upper right corner of
a face icon)

Expected results
==============
All selected face tags are removed.

Actual results
===========
The process of removing the face tags, begun, but the process never ended. I
seams as it hung somewhere.


I did some troubleshooting (and with some good help from a friend) I found what
I believe is a bug, causing this 'hanging'.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kristian Karl]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #1 from Kristian Karl <[hidden email]> ---
Created attachment 91925
  --> https://bugs.kde.org/attachment.cgi?id=91925&action=edit
Proposed patch fixing the bug

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345954

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Recursive calls made into   |Recursive calls made into
                   |ProgressManager::slotTransa |ProgressManager::slotTransa
                   |ctionCompletedDeferred      |ctionCompletedDeferred
                   |                            |[patch]
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345954

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.10.0
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/685e0764bb3b771afbc465e
                   |                            |246307e278a12e18d

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Git commit 685e0764bb3b771afbc465e246307e278a12e18d by Maik Qualmann.
Committed on 07/04/2015 at 19:24.
Pushed by mqualmann into branch 'master'.

apply patch #91925 from Kristian Karl to corrects the signal connection in the
ProgressManager
FIXED-IN: 4.10.0

M  +2    -1    NEWS
M  +1    -1    libs/progressmanager/progressmanager.cpp

http://commits.kde.org/digikam/685e0764bb3b771afbc465e246307e278a12e18d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Git commit c518182aa399cd1f0c456bf191d88d200ae4f5a0 by Gilles Caulier.
Committed on 03/04/2015 at 09:20.
Pushed by cgilles into branch 'frameworks'.

backport commit #685e0764bb3b771afbc465e246307e278a12e18d from git/master to
frameworks branch

M  +1    -1    libs/progressmanager/progressmanager.cpp

http://commits.kde.org/digikam/c518182aa399cd1f0c456bf191d88d200ae4f5a0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345954

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Maik Qualmann <[hidden email]> ---
Hi Kristian,
I now get this message in the console when you start digiKam:

Object::connect: No such signal
Digikam::NewItemsFinder::completeTransactionDeferred(ProgressItem*)

The completeTransactionDeferred(ProgressItem*) signal do not exist in
ProgressItem implementation.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kristian Karl]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #5 from Kristian Karl <[hidden email]> ---
Hi Mail,
Good catch Maik!
I noticed that the progress items never gets removed after the face tag removal
task is done. It's most likely connected to your observation. I'm working on a
fix.

Kristian

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kristian Karl]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #6 from Kristian Karl <[hidden email]> ---
Created attachment 91947
  --> https://bugs.kde.org/attachment.cgi?id=91947&action=edit
A proposed patch

The first patch did not fix this bug completely. It introduced a new bug, where
the statusbarprogresswidget was not able to signal that it was done. Thus the
status progress bar was never removed when it reached 100%

This patch fixes that problem. I tested it for a couple of use cases, where
progress bar is used, like
* Removing face tags
* Fingerprinting images
* Re-reading metadata from files

However, I suggest that this patch is code reviewed by someone that knows the
progress manager and status bar items/widgets well.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Created attachment 91955
  --> https://bugs.kde.org/attachment.cgi?id=91955&action=edit
progressmanager.patch

This patch would be an alternative solution to the issue.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kristian Karl]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #8 from Kristian Karl <[hidden email]> ---
I tested your patch, which looks very good,  and I think it works nicely.
Also, your patch is better than my last patch, since it much less intrusive,
and thus less likely to introduce regression.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Git commit b3d67ced05fb99561d69008e7c9e934d186d4aa3 by Maik Qualmann.
Committed on 09/04/2015 at 20:23.
Pushed by mqualmann into branch 'master'.

apply patch #91955 to corrects the signal connection in the ProgressManager

M  +3    -3    libs/progressmanager/progressmanager.cpp

http://commits.kde.org/digikam/b3d67ced05fb99561d69008e7c9e934d186d4aa3

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345954

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Git commit 6d5abbe5d89077b97d91fc8086519f497b85619f by Gilles Caulier.
Committed on 10/04/2015 at 16:33.
Pushed by cgilles into branch 'frameworks'.

backport commit #b3d67ced05fb99561d69008e7c9e934d186d4aa3 from git/master to
frameworks branch

M  +3    -3    libs/progressmanager/progressmanager.cpp

http://commits.kde.org/digikam/6d5abbe5d89077b97d91fc8086519f497b85619f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel