[digikam] [Bug 341758] New: Option to set watermark size based on given dimension

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=341758

            Bug ID: 341758
           Summary: Option to set watermark size based on given dimension
           Product: digikam
           Version: 4.5.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Batch Queue Manager
          Assignee: [hidden email]
          Reporter: [hidden email]

The watermark tool in the BQM can be scaled using only one "Size" slider. Apply
it to portrait and landscape photos and you end up with a very differing
watermark size.
This is a feature request to let the user configure which dimension the
watermark size should be scaled by - width, height, or diagonal (I guess now it
uses the diagonal?).

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=341758

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Option to set watermark     |BQM Watermark tool : Option
                   |size based on given         |to set size based on given
                   |dimension                   |dimension
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=341758

--- Comment #1 from DrSlony <[hidden email]> ---
I think currently it uses the width, always, which is why it doesn't work well
when you process both portrait and landscape photos. It could work better with
diagonal. Or even better, in pixels instead of %.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=341758

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.5.0                       |4.12.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=341758

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Tool-Inse
                   |                            |rtText

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=341758

Ahmed Fathi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmed.fathi.abdelmageed@gma
                   |                            |il.com

--- Comment #2 from Ahmed Fathi <[hidden email]> ---
Created attachment 103530
  --> https://bugs.kde.org/attachment.cgi?id=103530&action=edit
patch to fix the watermark size

I think this is highly related to this issue here

http://digikam.1695700.n4.nabble.com/Inconsistent-watermark-sizes-depending-on-pictures-ratio-td4692920.html

I made a patch for minor modification.My patch doesn't allow the user to choose
height or width , but it simply checks the ratio between height and width . if
the height is much larger , it will modify the watermark size accordingly

It produced much better results . The patch is attached

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=341758

--- Comment #3 from Ahmed Fathi <[hidden email]> ---
Created attachment 103533
  --> https://bugs.kde.org/attachment.cgi?id=103533&action=edit
Pictures Before And After tha patch

These photos show the result before and after the patch

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=341758

Ahmed Fathi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103530|0                           |1
        is obsolete|                            |

--- Comment #4 from Ahmed Fathi <[hidden email]> ---
Created attachment 103536
  --> https://bugs.kde.org/attachment.cgi?id=103536&action=edit
Modify the previous watermarkSize patch for mistake

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=341758

--- Comment #5 from DrSlony <[hidden email]> ---
Looks good.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=341758

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.5.0
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/5ec20e2073752679a3acb7
                   |                            |60c63cc7f5577b9bc5
         Resolution|---                         |FIXED

--- Comment #6 from [hidden email] ---
Git commit 5ec20e2073752679a3acb760c63cc7f5577b9bc5 by Gilles Caulier.
Committed on 20/01/2017 at 08:27.
Pushed by cgilles into branch 'master'.

apply patch #103536
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +10   -0    utilities/queuemanager/tools/decorate/watermark.cpp

https://commits.kde.org/digikam/5ec20e2073752679a3acb760c63cc7f5577b9bc5

--
You are receiving this mail because:
You are the assignee for the bug.