[digikam] [Bug 340581] New: Ratings with rating == 0 cannot be selected on the left sidebar [patch]

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] New: Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

            Bug ID: 340581
           Summary: Ratings with rating == 0 cannot be selected on the
                    left sidebar [patch]
           Product: digikam
           Version: 4.4.0
          Platform: openSUSE RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Labels
          Assignee: [hidden email]
          Reporter: [hidden email]

Images are imported with rating == -1 (no rating). If the rating changed and
then deleted, is the rating == 0. This images cannot be selected on the left
sidebar.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #1 from Maik Qualmann <[hidden email]> ---
Created attachment 89404
  --> https://bugs.kde.org/attachment.cgi?id=89404&action=edit
Rating

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Created attachment 89405
  --> https://bugs.kde.org/attachment.cgi?id=89405&action=edit
albumlabelstreeview.patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Gilles Caulier-4
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |mohammed.ahmed.anwer@gmail.
                   |                            |com

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Mohamed,

What do you think about this patch please ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #4 from Mohamed <[hidden email]> ---
Hi all,

I don't mind implementing this patch, But it will add the "0 Rating" to
digikam, So I think digikam will need more work to implement the "0 Rating"
everywhere.

But there is another way: We can simply change the "0 rated images" into "-1
rated images" so we can search for "images without rating" from the labels tree
view.

Thanks,
Mohamed Anwer

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #5 from Maik Qualmann <[hidden email]> ---
Hi,

this new Patch set rating == 0 to rating = -1

Thanks

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Created attachment 89409
  --> https://bugs.kde.org/attachment.cgi?id=89409&action=edit
databaseworkeriface.patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #7 from Mohamed <[hidden email]> ---
(In reply to Maik Qualmann from comment #6)
> Created attachment 89409 [details]
> databaseworkeriface.patch

Much simpler.

Thanks
Mohamed Anwer

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #8 from Mohamed <[hidden email]> ---
Mr Gilles,

I think the last patch is the simplest solution for the problem as I mentioned
in my previous comment, It doesn't need to add the "0 Rating" to digiKam
anyway.

Mohamed Anwer.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Gilles Caulier-4
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Well, if patch is acceptable for you, feel free to apply it to git/master.

Q : does others part of digiKam which play with rating will be affected by this
change ? For example, rating filter, rating assignment from Captions&Tags,
rating from Advanced Search tool...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #10 from Mohamed <[hidden email]> ---
(In reply to Gilles Caulier from comment #9)
> Well, if patch is acceptable for you, feel free to apply it to git/master.
>
> Q : does others part of digiKam which play with rating will be affected by
> this change ? For example, rating filter, rating assignment from
> Captions&Tags, rating from Advanced Search tool...
>
> Gilles Caulier

OK, I'll test the patch and double check it's functionality as soon as possible

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #11 from Maik Qualmann <[hidden email]> ---
Hi,
please wait still with the patch, I might even be a better idea...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #12 from Mohamed <[hidden email]> ---
(In reply to Maik Qualmann from comment #11)
> Hi,
> please wait still with the patch, I might even be a better idea...

OK, We are waiting...
We appreciate your work, Keep it up.

Thanks
Mohamed Anwer

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #13 from Maik Qualmann <[hidden email]> ---
Hi,

is no rating selected, adds the patch "albumlabelstreeview2.patch" both ratings
to list (0 and -1). It works fine for me.

Thanks

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Maik Qualmann
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #14 from Maik Qualmann <[hidden email]> ---
Created attachment 89422
  --> https://bugs.kde.org/attachment.cgi?id=89422&action=edit
albumlabelstreeview2.patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

Mohamed <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/b8ccc7b36f033ddd17eec18
                   |                            |6fcfccad0c25cff6e
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #15 from Mohamed <[hidden email]> ---
Git commit b8ccc7b36f033ddd17eec186fcfccad0c25cff6e by Mohamed Anwer.
Committed on 04/11/2014 at 17:36.
Pushed by mohamedanwer into branch 'master'.

M  +3    -2    app/album/albumlabelstreeview.cpp

http://commits.kde.org/digikam/b8ccc7b36f033ddd17eec186fcfccad0c25cff6e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

Mohamed <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Peter Albrecht-2
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

Peter Albrecht <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #16 from Peter Albrecht <[hidden email]> ---
(In reply to Mohamed from comment #4)
> I don't mind implementing this patch, But it will add the "0 Rating" to
> digikam, So I think digikam will need more work to implement the "0 Rating"
> everywhere.
> [...]

In digikam 4.4.0, there is already a "0 rating". Not in the "Labels" side view,
but in "Advanced Search":

The options for "Rating" are:
  - (No value selected)   - meaning: ignore rating at all
  - No rating assigned    - meaning: no rating set
  - 0 stars                       - meaning: rating set to value 0
  - 1 star
  - 2 stars
  - 3 stars
  - 4 stars
  - 5 stars

The options "No rating assigned" and "0 stars" give different search results on
my system.

I can move pictures from the "No rating" group to the "0 star rating" group
with the keyboard shortcut "CTRL + 0".

Importing files from SD-card seems to set a small default XMP-section with
"rating = 0". While importing via Copy&Paste seems to leave the image as is (no
metadata -> no rating).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

Mohamed
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

--- Comment #17 from Mohamed <[hidden email]> ---
(In reply to Peter Albrecht from comment #16)

> (In reply to Mohamed from comment #4)
> > I don't mind implementing this patch, But it will add the "0 Rating" to
> > digikam, So I think digikam will need more work to implement the "0 Rating"
> > everywhere.
> > [...]
>
> In digikam 4.4.0, there is already a "0 rating". Not in the "Labels" side
> view, but in "Advanced Search":
>
> The options for "Rating" are:
>   - (No value selected)   - meaning: ignore rating at all
>   - No rating assigned    - meaning: no rating set
>   - 0 stars                       - meaning: rating set to value 0
>   - 1 star
>   - 2 stars
>   - 3 stars
>   - 4 stars
>   - 5 stars
>
> The options "No rating assigned" and "0 stars" give different search results
> on my system.
>
> I can move pictures from the "No rating" group to the "0 star rating" group
> with the keyboard shortcut "CTRL + 0".
>
> Importing files from SD-card seems to set a small default XMP-section with
> "rating = 0". While importing via Copy&Paste seems to leave the image as is
> (no metadata -> no rating).

You are right but from your point of view, What I meant is when you hover over
a photo,  You can see the rating stars indicating the rating of this photo,

Can you differentiate between the (unrated) photo and the (0 rated) photo ? ,
No you can't.

That's what I mean by implementing the 0 rating, Even if it already exists in
some parts of the code, But the user can't feel it, unless he use the advanced
search window.

If we would implement this, I suggest adding another icon beside the rating
stars to (Un-rate) the photo, Of course we must ask the community about this.

There are some plans in my head dedicated to digiKam, But I'm waiting until I
finish my final exams.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 340581] Ratings with rating == 0 cannot be selected on the left sidebar [patch]

bugzilla_noreply
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=340581

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Labels                      |Tags-Rating

--
You are receiving this mail because:
You are the assignee for the bug.