[digikam] [Bug 339210] New: digiKam crashes when trying to stop find duplicates

[Mark Fraser]

https://bugs.kde.org/show_bug.cgi?id=339210

            Bug ID: 339210
           Summary: digiKam crashes when trying to stop find duplicates
           Product: digikam
           Version: 4.3.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: Fuzzy Searches
          Assignee: [hidden email]
          Reporter: [hidden email]

I ran find duplicates and then noticed that the process had finished but was
still showing 100%. When I tried to stop the process, digiKam crashed.
I restarted digiKam and tried again, this time I tried to quit digiKam instead,
but it still crashed.

Reproducible: Always

Steps to Reproduce:
1.Run "find duplicates"
2.When complete, try to stop still running process
3.digiKam crashes.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mark Fraser]

https://bugs.kde.org/show_bug.cgi?id=339210

--- Comment #1 from Mark Fraser <[hidden email]> ---
Created attachment 88751
  --> https://bugs.kde.org/attachment.cgi?id=88751&action=edit
digiKam backtrace

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339210

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.4.0
         Resolution|---                         |FIXED
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Already fixed with this commit :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/30e65a812f5aff808173dad52100c93dcc24b988

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=339210

nucleo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from nucleo <[hidden email]> ---
(In reply to Gilles Caulier from comment #2)
> Already fixed with this commit :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/
> revisions/30e65a812f5aff808173dad52100c93dcc24b988
>
> Gilles Caulier

patching file utilities/maintenance/imageinfojob.cpp
Reversed (or previously applied) patch detected!  Assume -R? [n]

Looks like this commit alreafy applied in digiKam 4.3.0 sources, so if crash
fixed then maybe in other commit?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339210

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Nucleao,

Look the date of commit :

ID: 30e65a812f5aff808173dad52100c93dcc24b988
Added by Teemu Rytilahti 4 days ago
Don't crash if there's an error during the job

4.3.0 tarball have been created well before...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=339210

--- Comment #5 from nucleo <[hidden email]> ---
Here commit:

--- a/utilities/maintenance/imageinfojob.cpp
+++ b/utilities/maintenance/imageinfojob.cpp
@@ -110,8 +110,6 @@ bool ImageInfoJob::isRunning() const

 void ImageInfoJob::slotResult(KJob* job)
 {
-    d->job = 0;
-
     if (job->error())
     {
         kWarning() << "Failed to list url: " << job->errorString();
@@ -121,6 +119,8 @@ void ImageInfoJob::slotResult(KJob* job)
                              DigikamApp::instance(),
DigikamApp::instance()->windowTitle());
     }

+    d->job = 0;
+
     emit signalCompleted();
 }



And here actual code from 4.3.0 tarball:

void ImageInfoJob::slotResult(KJob* job)
{
    if (job->error())
    {
        kWarning() << "Failed to list url: " << job->errorString();

        // Pop-up a message about the error.
        DNotificationWrapper(QString(), d->job->errorString(),
                             DigikamApp::instance(),
DigikamApp::instance()->windowTitle());
        return;
    }

    d->job = 0;

    emit signalCompleted();
}

So patch already applied in 4.3.0 sources.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339210

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Ahh...

This one is not include to 4.3.0 i think :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/d523a9768ab8276860c76e02b9d9b598a3d607f9

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=339210

--- Comment #7 from nucleo <[hidden email]> ---
(In reply to Gilles Caulier from comment #6)
> Ahh...
>
> This one is not include to 4.3.0 i think :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/
> revisions/d523a9768ab8276860c76e02b9d9b598a3d607f9

This commit fixes crash in 4.3.0.
Thanks.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel