[digikam] [Bug 339074] New: Warning from Qt when in database connection checker

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339074

            Bug ID: 339074
           Summary: Warning from Qt when in database connection checker
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Database
          Assignee: [hidden email]
          Reporter: [hidden email]

Don't actually know if this is an actual issue or not, maybe not even leak in
it, but a warning from Qt arrives when digikam starts:

QSqlDatabasePrivate::removeDatabase: connection 'ConnectionTest' is still in
use, all queries will cease to work.

and it seems the Qt docs say to destroy the QSqlDatabase object before removing
the connection: http://qt-project.org/doc/qt-4.7/qsqldatabase.html in
removeConnection(). Actually not completely clear to me if it is necessary even
though no query is open. I see in digikam code it is done differently.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339074

Luca Carlon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Warning from Qt when in     |Warning from Qt when in
                   |database connection checker |database connection checker
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339074

--- Comment #1 from Luca Carlon <[hidden email]> ---
Created attachment 88701
  --> https://bugs.kde.org/attachment.cgi?id=88701&action=edit
Patch do free QSqlDatabase object before connection is removed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339074

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.3.0
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Marcel,

I need your feedback for this patch please.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=339074

--- Comment #3 from Marcel Wiesweg <[hidden email]> ---
Comment on attachment 88701
  --> https://bugs.kde.org/attachment.cgi?id=88701
Patch do free QSqlDatabase object before connection is removed.

What is the actually changed code, indentation changes set aside?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339074

--- Comment #4 from Luca Carlon <[hidden email]> ---
A couple of brackets were added.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339074

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Luca,

The 2 brackets add in void DatabaseConnectionChecker::run() must have no effect
compared to previous implementation... Are you sure to have provided the right
patch ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339074

--- Comment #6 from Luca Carlon <[hidden email]> ---
I just checked again. The patch is what I intended. The effect of the brackets
is to make the dtor of databaseHandler run before the connection is removed by
QSqlDatabase::removeDatabase. Again, not sure this was strictly needed
according to Qt sources as I don't see queries in the code, but the warning
disappears.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339074

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Warning from Qt when in     |CORE : warning from Qt when
                   |database connection checker |in database connection
                   |[patch]                     |checker [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=339074

--- Comment #7 from Marcel Wiesweg <[hidden email]> ---
Ok, I see.
I have never understood why these error messages appear, but they never had any
adverse effects.
Patch is fine for me.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339074

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.4.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/7ef60a13291e421af235594
                   |                            |62cfb41700bc70f60
         Resolution|---                         |FIXED

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Git commit 7ef60a13291e421af23559462cfb41700bc70f60 by Gilles Caulier.
Committed on 15/09/2014 at 20:41.
Pushed by cgilles into branch 'master'.

apply patch #88701 to prevent QtSQL plugin warnings
FIXED-IN: 4.4.0

M  +31   -29   app/database/databaseguierrorhandler.cpp
M  +1    -1    app/database/databaseguierrorhandler.h

http://commits.kde.org/digikam/7ef60a13291e421af23559462cfb41700bc70f60

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel