[digikam] [Bug 339053] New: Allow the usage of arrows to move in the photo sequence when in preview

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339053

            Bug ID: 339053
           Summary: Allow the usage of arrows to move in the photo
                    sequence when in preview
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Preview
          Assignee: [hidden email]
          Reporter: [hidden email]

When in preview, only moving with pageup and pagedown is allowed. But some
keyboards (for instance macbook's keyboard) doesn't feature those keys and
moving with the arrows seems pretty natural.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339053

--- Comment #1 from Luca Carlon <[hidden email]> ---
Created attachment 88696
  --> https://bugs.kde.org/attachment.cgi?id=88696&action=edit
Allows the usage of arrows in preview.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339053

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Allow the usage of arrows   |Allow the usage of arrows
                   |to move in the photo        |to move in the photo
                   |sequence when in preview    |sequence when in preview
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339053

Luca Carlon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88696|0                           |1
        is obsolete|                            |

--- Comment #2 from Luca Carlon <[hidden email]> ---
Created attachment 89698
  --> https://bugs.kde.org/attachment.cgi?id=89698&action=edit
Allows the usage of arrows in preview.

Inverted params in the macro as requested.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=339053

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Teemu Rytilahti <[hidden email]> ---
Gilles, what do you think? For me it looks good.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339053

--- Comment #4 from Gilles Caulier <[hidden email]> ---
The feature is fine for me.

Patch include a macro which must be factored somewhere in a common place (as
core/app/utils/global.h) and used where we can to reduce duplicate code.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339053

Luca Carlon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89698|0                           |1
        is obsolete|                            |

--- Comment #5 from Luca Carlon <[hidden email]> ---
Created attachment 89701
  --> https://bugs.kde.org/attachment.cgi?id=89701&action=edit
Allows the usage of arrows in preview.

Moved to globals.h as requested to try to reuse the code.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339053

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/fca9b840bfa68aedff75311
                   |                            |35c39812ab98faa88
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.6.0
         Resolution|---                         |FIXED

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Git commit fca9b840bfa68aedff7531135c39812ab98faa88 by Gilles Caulier.
Committed on 26/11/2014 at 12:49.
Pushed by cgilles into branch 'master'.

apply patch #89701 from Lucas Carlon about to manage arrow keys to navigate
between items as with PAGE_UP and PAGE_DOWN
This affect ImageEditor, LightTable, AlbumGUI Preview Mode, and ImportGUI
Preview Mode.
FIXED-IN: 4.6.0

M  +2    -1    NEWS
M  +27   -6    app/utils/globals.h
M  +7    -9    app/views/digikamview.cpp
M  +10   -5    utilities/imageeditor/editor/editorwindow.cpp
M  +10   -0    utilities/imageeditor/editor/editorwindow_p.h
M  +8    -13   utilities/importui/views/importview.cpp
M  +3    -1    utilities/lighttable/lighttablewindow.cpp
M  +13   -0    utilities/lighttable/lighttablewindow_p.h

http://commits.kde.org/digikam/fca9b840bfa68aedff7531135c39812ab98faa88

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel