[digikam] [Bug 338869] New: Watermark tool: need option for rotation of the text

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 338869] New: Watermark tool: need option for rotation of the text

Pento
https://bugs.kde.org/show_bug.cgi?id=338869

            Bug ID: 338869
           Summary: Watermark tool: need option for rotation of the text
           Product: digikam
           Version: 4.0.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Batch Queue Manager
          Assignee: [hidden email]
          Reporter: [hidden email]

Often it is need to not only position of watermark but also rotation of the
text

Reproducible: Always

Steps to Reproduce:
1. Open digiKam and navigate to some album
2. Select images and add them to new batch queue
3. Enable Watermark tool

Actual Results:  
There is no option for rotation of the text. Only position and margins.

Expected Results:  
Option for rotation: 90, -90, 180

Same functionality you can see in main editor tool "Add Text"

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 338869] BQM Watermark tool : add new option to rotate text

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=338869

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Watermark tool: need option |BQM Watermark tool : add
                   |for rotation of the text    |new option to rotate text
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 338869] BQM Watermark tool : add new option to rotate text

Gilles Caulier-4
In reply to this post by Pento
https://bugs.kde.org/show_bug.cgi?id=338869

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0                       |4.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 338869] BQM Watermark tool : add new option to rotate text

bugzilla_noreply
In reply to this post by Pento
https://bugs.kde.org/show_bug.cgi?id=338869

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Tool-Inse
                   |                            |rtText

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 338869] BQM Watermark tool : add new option to rotate text

bugzilla_noreply
In reply to this post by Pento
https://bugs.kde.org/show_bug.cgi?id=338869

Ahmed Fathi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmed.fathi.abdelmageed@gma
                   |                            |il.com

--- Comment #1 from Ahmed Fathi <[hidden email]> ---
Created attachment 103909
  --> https://bugs.kde.org/attachment.cgi?id=103909&action=edit
patch for watermark orientation feature. also handles exif data correctly

This patch provides this feature. It also handles the exif data correctly. if
the exif data specifies , for example , that the image is rotated 90 degrees
clockwise, and the user chooses to place a water mark at the bottom right of
the photo, It will be placed on the bottom right of the photo as expected. This
was the problem proposed by the following two entries :

https://bugs.kde.org/show_bug.cgi?id=250642
https://bugs.kde.org/show_bug.cgi?id=290944

In the next comment I provide some screen shots of the watermark orientation
feature, in addition to some screenshots for the watermark orientation + exif
data orientation side by side

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 338869] BQM Watermark tool : add new option to rotate text

bugzilla_noreply
In reply to this post by Pento
https://bugs.kde.org/show_bug.cgi?id=338869

--- Comment #2 from Ahmed Fathi <[hidden email]> ---
Created attachment 103910
  --> https://bugs.kde.org/attachment.cgi?id=103910&action=edit
photos for the feature provided by the previous patch

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 338869] BQM Watermark tool : add new option to rotate text

bugzilla_noreply
In reply to this post by Pento
https://bugs.kde.org/show_bug.cgi?id=338869

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.5.0
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/d54da04770450fa56a712d
                   |                            |05485b73f023b008c2

--- Comment #3 from [hidden email] ---
Git commit d54da04770450fa56a712d05485b73f023b008c2 by Gilles Caulier.
Committed on 09/02/2017 at 21:24.
Pushed by cgilles into branch 'master'.

apply patch #103909 to add rotation feature in BQM watermark tool with exif
orientation support.
Related: bug 250642, bug 290944
FIXED-IN: 5.5.0

M  +6    -1    NEWS
M  +50   -0    libs/dimg/dimg.cpp
M  +6    -1    libs/dimg/dimg.h
M  +6    -0    libs/threadimageio/loadsavethread.cpp
M  +5    -0    libs/threadimageio/loadsavethread.h
M  +83   -12   utilities/queuemanager/tools/decorate/watermark.cpp
M  +1    -1    utilities/queuemanager/tools/decorate/watermark.h

https://commits.kde.org/digikam/d54da04770450fa56a712d05485b73f023b008c2

--
You are receiving this mail because:
You are the assignee for the bug.