[digikam] [Bug 338367] New: Unable to zoom out to less than fit to window

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=338367

            Bug ID: 338367
           Summary: Unable to zoom out to less than fit to window
           Product: digikam
           Version: 4.2.0
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
          Assignee: [hidden email]
          Reporter: [hidden email]

It's impossible to use 'View->Zoom out' if the images fits to the window. Fit
to either width or height doesn't matter. 'View->Zoom out' is grey.

Setting a zoom factor to a smaller value works though.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Right, reproducible here...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unable to zoom out to less  |CANVAS : unable to zoom out
                   |than fit to window          |to less than fit to window

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Created attachment 89840
  --> https://bugs.kde.org/attachment.cgi?id=89840&action=edit
zoomout.patch

This patch fixes the Zoom out problem. By input into the Zoom combo box can be
extended to 1% -4800% of the zoom range. By entering a large zoom factor in the
Zoom combo box digiKam could crash.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CANVAS : unable to zoom out |CANVAS : unable to zoom out
                   |to less than fit to window  |to less than fit to window
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Created attachment 89842
  --> https://bugs.kde.org/attachment.cgi?id=89842&action=edit
zoomout2.patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #4 from Maik Qualmann <[hidden email]> ---
The zoomout2.patch corrects a problem if the window is smaller than the current
minZoomFactor.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Thanks Maik For you patches.

I suppose that zoomout2.patch replace zoomout.patch. If yes, please don't
forget to set as "obsolete" older one when you push new one in bugzilla.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Maik,

You patch zoomout2.patch touch SinglePhotoPreviewLayout and DZoomBar classes.
Both are used with

1/ Image Editor canvas (relevant of this entry).
2/ Preview canvas from AlbumUI (F3 mode).
3/ Preview canvas from ImportUI (F3 mode).
4/ Preview Canvas from LightTable.

Did you seen if no regression have not been introduced with 2/ 3/ 4/ in canvas
zoom management ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Maik,

In Light Table, put the same image on Left and Right View. From high values to
fit on view zoom level, both view are sync if you press on zoom +/- butom from
status bar. If zoom level is lower than fit on view value, only left or right
view is zoomed out.

This specific case is certainly relevant of zoom management done in Light Table
implementation to sync left and right view, not from your patch.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Maik,

Else, i tested cases 1/, 2/, and 3/ : no regression introduced.

It still the little problem with Light Table, explained in my comment #7.

Seen in Light Table implementation from lightTableView class, where
signals/slots connection are done between preview and zoombar.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89842|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89842|1                           |0
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89840|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Gilles,

yes the sync zoom from Light Table do not work correctly. Could the resize
event of scrollbars are, I'll be looking at.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89842|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Created attachment 89847
  --> https://bugs.kde.org/attachment.cgi?id=89847&action=edit
zoomout3.patch

New patch for test. Sorry for the large changes in the Light Table. The patch
also fixes the problem on the Light Table that is lost synchronization when the
image is smaller than the window.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/be72e5d8c0465ab4b8b4418
                   |                            |41ae22be47c3dbc92
   Version Fixed In|                            |4.6.0

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Git commit be72e5d8c0465ab4b8b441841ae22be47c3dbc92 by Gilles Caulier.
Committed on 07/12/2014 at 10:39.
Pushed by cgilles into branch 'master'.

Apply patch #89847 from Maik Qualmann to permit to zoom out over preview and
editor canvas lesser than fit image to window scale.
Adjust Light Table zoom handling signal and slots to run with new preview zoom
range
FIXED-IN: 4.6.0

M  +2    -1    NEWS
M  +14   -2    libs/widgets/graphicsview/previewlayout.cpp
M  +1    -1    libs/widgets/mainview/dzoombar.cpp
M  +37   -27   utilities/lighttable/lighttableview.cpp
M  +2    -0    utilities/lighttable/lighttableview.h

http://commits.kde.org/digikam/be72e5d8c0465ab4b8b441841ae22be47c3dbc92

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #12 from Maik Qualmann <[hidden email]> ---
Created attachment 89869
  --> https://bugs.kde.org/attachment.cgi?id=89869&action=edit
zoomout4.patch

Gilles,

can you please add zoomout4.patch to optimize the code and reset a large zoom
range on standard.

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338367

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Git commit 2fa15e1d23d25e6522562dec4d00425f0a940e85 by Gilles Caulier.
Committed on 08/12/2014 at 18:00.
Pushed by cgilles into branch 'master'.

apply patch #89869 from Maik Qualmann to optimize zomming code and reset a
large zoom range on standard.

M  +9    -12   libs/widgets/graphicsview/previewlayout.cpp

http://commits.kde.org/digikam/2fa15e1d23d25e6522562dec4d00425f0a940e85

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel