[digikam] [Bug 338224] New: Inconsistent Zoom to 100% shortcut in digiKam vs showFoto

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338224

            Bug ID: 338224
           Summary: Inconsistent Zoom to 100% shortcut in digiKam vs
                    showFoto
           Product: digikam
           Version: 4.2.0
          Platform: Gentoo Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Usability
          Assignee: [hidden email]
          Reporter: [hidden email]

In digiKam the Zoom to 100% shortcut, which I set to *, zooms the image to
100%, and if I click * again, it fits it to window again.
In showFoto I set the same shortcuts, but there it only zooms to 100%. If I
click it again, nothing happens, it does not toggle back and forth between 100%
and fit-to-window as digiKam does.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338224

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Inconsistent Zoom to 100%   |Inconsistent Zoom to 100%
                   |shortcut in digiKam vs      |shortcut behavior between
                   |showFoto                    |Preview Pode and image
                   |                            |Editor

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338224

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Inconsistent Zoom to 100%   |Inconsistent "Zoom to 100%"
                   |shortcut behavior between   |shortcut behavior between
                   |Preview Pode and image      |Preview Mode and Image
                   |Editor                      |Editor

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338224

--- Comment #1 from DrSlony <[hidden email]> ---
This applies to the Light Table too.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338224

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Gilles,

i want to fix this bug. What do you think, how the behavior of "Fit to Window"
and should be "Zoom to 100%"?

Preview from Album:
Fit to Window -> only fit to window
Zoom to 100%  -> toggled 100% and fit to Window

Image Editor:
Fit to Window -> toggled fit to Window and last zoom
Zoom to 100%  -> only zoom to 100%

Preview from LightTable:
Fit to Window -> only fit to window
Zoom to 100%  -> only zoom to 100%

Preview from Import:
Fit to Window -> only fit to window
Zoom to 100%  -> toggled 100% and fit to Window

I would be for the behavior of preview from Album and Import.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338224

--- Comment #3 from DrSlony <[hidden email]> ---
They should toggle back and forth. It is of no benefit if they don't.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338224

--- Comment #4 from Gilles Caulier <[hidden email]> ---
 I'am surprised about the différence between preview, LT, and Editor.
In all case, behavior must be the same everywhere.
The good behavior is preview mode from album view and import tool.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338224

--- Comment #5 from Maik Qualmann <[hidden email]> ---
Created attachment 89909
  --> https://bugs.kde.org/attachment.cgi?id=89909&action=edit
zoomto100.patch

This patch is present everywhere the same behavior of Zoom to 100%.
First applies Zoom to 100% then fit to window.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338224

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.6.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/028793b9e3a830a51ed05fc
                   |                            |738a5db8825941652
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Git commit 028793b9e3a830a51ed05fc738a5db8825941652 by Gilles Caulier.
Committed on 10/12/2014 at 17:44.
Pushed by cgilles into branch 'master'.

Apply patch #89909 from Maik Qualmann about to fix zoom to 100% behavior to
have same rules everywhere (IE, LY, Preview)
FIXED-IN: 4.6.0

M  +2    -1    NEWS
M  +1    -1    libs/widgets/graphicsview/previewlayout.cpp
M  +2    -2    utilities/imageeditor/editor/editorstackview.cpp
M  +2    -2    utilities/lighttable/lighttableview.cpp

http://commits.kde.org/digikam/028793b9e3a830a51ed05fc738a5db8825941652

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=338224

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Usability-Shortcuts

--
You are receiving this mail because:
You are the assignee for the bug.