[digikam] [Bug 338200] New: "Cancel this operation" does not work

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338200

            Bug ID: 338200
           Summary: "Cancel this operation" does not work
           Product: digikam
           Version: 4.2.0
          Platform: Gentoo Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

I assigned a tag to about a thousand raw photos, with the "write metadata to
raw files" option enabled. As it was taking very long, I wanted to cancel this
and to run it at night. Clicking the "Cancel this operation" button at 31% did
nothing.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338200

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Progress Manager

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338200

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Cancel this operation"     |Cancelling tags assigment
                   |does not work               |in file metadata does not
                   |                            |work

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338200

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Maik,

In this file, the loop to process image with tags assignment is performed by
FileActionMngr. See ImageDescEditTab::slotApplyAllChanges().

I check code in FileActionMngr and it's connected to Progress Manager.

Can you reproduce the dysfunction ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338200

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Created attachment 93679
  --> https://bugs.kde.org/attachment.cgi?id=93679&action=edit
cancelworker.patch

With this patch, the write metadata to DB and files can be canceled.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338200

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cancelling tags assigment   |Cancelling tags assigment
                   |in file metadata does not   |in file metadata does not
                   |work                        |work [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338200

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Patch sound fine for me...
But we must know the current talk between Veaceslav and Marcel about KF5 port
dysfunctions from FileActionMngr. I CC you for info by private mail.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338200

--- Comment #4 from Gilles Caulier <[hidden email]> ---
MAik,

I forwarded the thread between Veaceslav and Marcel.

Did you manage to backport this patch to Frameworks branch ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338200

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.12.0
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/14f77f54d47de008a249360
                   |                            |942449a4d04f60aa1

--- Comment #5 from Maik Qualmann <[hidden email]> ---
Git commit 14f77f54d47de008a249360942449a4d04f60aa1 by Maik Qualmann.
Committed on 21/07/2015 at 20:44.
Pushed by mqualmann into branch 'master'.

apply patch #93679 to writing the metadata to the DB and the files can be
canceled
FIXED-IN: 4.12.0

M  +2    -1    NEWS
M  +39   -0    app/fileaction/databaseworkeriface.cpp
M  +11   -2    app/fileaction/fileactionmngr_p.cpp
M  +1    -0    app/fileaction/fileactionmngr_p.h
M  +19   -0    app/fileaction/fileworkeriface.cpp

http://commits.kde.org/digikam/14f77f54d47de008a249360942449a4d04f60aa1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=338200

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Git commit 5493e5b912c4b2c9df0fc1cb05539fd542e5129d by Maik Qualmann.
Committed on 29/07/2015 at 17:11.
Pushed by mqualmann into branch 'frameworks'.

backport commit #14f77f54d47de008a249360942449a4d04f60aa1 from git/master to
frameworks branch

M  +39   -0    libs/fileactionmanager/databaseworkeriface.cpp
M  +11   -2    libs/fileactionmanager/fileactionmngr_p.cpp
M  +1    -0    libs/fileactionmanager/fileactionmngr_p.h
M  +19   -0    libs/fileactionmanager/fileworkeriface.cpp

http://commits.kde.org/digikam/5493e5b912c4b2c9df0fc1cb05539fd542e5129d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel