[digikam] [Bug 338081] New: Support HDR DNG images from HDRMerge

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

            Bug ID: 338081
           Summary: Support HDR DNG images from HDRMerge
           Product: digikam
           Version: 4.2.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

HDRMerge is an awesome FOSS program from Javier Celaya for generating a high
dynamic range raw image in the DNG format from a bracketed raw set.
https://github.com/jcelaya/hdrmerge

Please add support for correctly displaying the thumbnails from these raw
images. They follow standards and should therefore be supported.
You can download a sample image from:
http://rawtherapee.com/shared/test_images/hdrmerge_045.dng

Currently digiKam shows neither the thumbnail nor the embedded JPEG preview.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #1 from DrSlony <[hidden email]> ---
With "[x] Embedded preview loads full-sized images" checked, thumbnails are not
shown but clicking on a thumb does show the large preview.
http://i.imgur.com/abRoxR9.jpg

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |UPSTREAM
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
RAW preview including DNG file are processed by libraw in background. Please
report this problem to Libraw team.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #3 from DrSlony <[hidden email]> ---
Hi Gilles, thank your for responding. I can't find libraw's bugzilla, can you
point me? I sent them a message but these are usually ignored if they're not
filed in the correct place.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Sound like libraw use GitHub issue manager. I can seen 8 entries closed :

https://github.com/LibRaw/LibRaw/issues?q=is%3Aissue+is%3Aclosed

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #5 from DrSlony <[hidden email]> ---
Do you also use libraw to extract the embedded JPEG thumbnail and preview
image?
Because digiKam DOES show the embedded preview, but it does NOT show the
thumbnail. My request is for digiKam to show the embedded preview and thumbnail
so that these DNG images can be managed.

ps. I wrote in comment 0 that it does not show the embedded preview - this is
wrong, 4.2.0 does show the preview. Maybe I had an older version of some
dependency back then. Now I'm using 4.2.0 and previews are shown after clicking
on the DNG, but still no thumbs.

digiKam version 4.2.0
CPU cores: 8
Demosaic GPL2 pack support: No
Demosaic GPL3 pack support: No
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: Yes
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibEigen: 3.2.0
LibExiv2: 0.24
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.13.3
LibKExiv2: 2.3.1
LibKGeoMap: 2.0.0
LibKdcraw: 2.4.2
LibLCMS: 2060
LibLensFun: 0.2.8-0
LibPGF: 6.12.27 - external shared library
LibPNG: 1.6.12
LibQt: 4.8.5
LibRaw: 0.16.0-Beta1
LibTIFF: LIBTIFF, Version 4.0.3 Copyright (c) 1988-1996 Sam Leffler Copyright
(c) 1991-1996 Silicon Graphics, Inc.
Marble Widget: 0.18.3 (stable release)
Parallelized PGF codec: No
Parallelized demosaicing: Yes
RawSpeed codec support: No
Database backend: QSQLITE
Kipi-Plugins: 4.2.0
LibKface: 3.0.0
LibKipi: 2.1.0
LibOpenCV: 2.4.5

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Yes, libraw is used in Both case.

Note Exiv2 has also a method to extract preview from DNG. Please report this
problem too in Exiv2 bugzilla.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #7 from DrSlony <[hidden email]> ---
Filed:
https://github.com/LibRaw/LibRaw/issues/39
http://dev.exiv2.org/issues/980

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|UPSTREAM                    |---
             Status|RESOLVED                    |UNCONFIRMED

--- Comment #8 from DrSlony <[hidden email]> ---
LibRaw refuse to support even simple extraction of the embedded JPEG thumbnail.
I can already extract BOTH preview images from that DNG using exiv2-0.24.
Preview-2 is large, preview-1 is small, thumbnail-sized in fact (256x172). It
could be used for the thumbnail in digiKam.

exiv2 -ep1 hdrmerge_045.dng

To reiterate:
1- digiKam already shows the large preview when you click on the thumbnail, but
it shows no thumbnail.
2- exiv2 can extract both previews,
3- so you could use it to get the small preview for the thumbnail.

I removed the "resolved - upstream" status as one upstream refused to do
anything (libraw), and the other already supports it (exiv2). So now it's up to
digiKam to make use of exiv2's ability to get the thumb.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Thumbnails

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Can you share some DNG files to test here ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #10 from DrSlony <[hidden email]> ---
Sure, there is a link to one in my original comment here:
http://rawtherapee.com/shared/test_images/hdrmerge_045.dng

Let me know if you need more.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #11 from DrSlony <[hidden email]> ---
I discussed this with the Exiv2 devs (See comment 7 for the link) and it
appears that Exiv2 is working correctly. No Exif thumbnail exists inside this
image, so digiKam should use the embedded preview-1 image as the thumbnail.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #12 from Gilles Caulier <[hidden email]> ---
Yes, reproducible here :

digikam(72287)/digikam (core) Digikam::DImg::load:
"/Users/gilles/Pictures/photos.test/hdrmerge_045.dng"  : RAW file identified
digikam(72287)/digikam (core) Digikam::JPEGUtils::isJpegImage: mimetype =
"TIFF"  ext =  "DNG"
digikam(72287)/digikam (core) Digikam::ThumbnailCreator::createThumbnail:
Cannot create thumbnail for
"/Users/gilles/Pictures/photos.test/hdrmerge_045.dng"
digikam(72287)/digikam (core) Digikam::ThumbnailCreator::load: Thumbnail is
null for  "/Users/gilles/Pictures/photos.test/hdrmerge_045.dng"

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #13 from Gilles Caulier <[hidden email]> ---
First problem confirmed Libraw 0.16 cannot extract embedded preview and half
preview with this DNG file :

digikam(75049)/digikam (core) Digikam::ThumbnailCreator::load: Thumbnail is
null for  "/Users/gilles/Pictures/photos.test/hdrmerge_045.dng"
digikam(75049)/digikam (core) Digikam::ThumbnailCreator::createThumbnail:
Trying to load Embedded preview with libraw
digikam(75049)/digikam (core) Digikam::ThumbnailCreator::createThumbnail:
Trying to load half preview with libraw

This debug statements just proof that libraw is not able to work with this file
without to use a full demosaicing method.

Typically this DNG is badly encoded by HDRMerge.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Other point : as libraw cannot play with this DNG, Image cannot be loaded in
image editor...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #15 from DrSlony <[hidden email]> ---
1- How is it "badly encoded"?
2- digiKam uses exiv2, and exiv2 can extract the preview. That would be enough
for the thumbnail to let us manage these files using digiKam.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #16 from DrSlony <[hidden email]> ---
"Programs using a library like libkdcraw/libraw to fully read the raw image and
obtain the preview. They fail, because libraw does not know how to read the
float data. Since reading the data and the preview is performed in just one
call to open(), the preview is not available when reading the data fails"
https://github.com/jcelaya/hdrmerge/issues/27#issuecomment-53459385

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |4.3.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/617f203acb9fec474c95c3d
                   |                            |bd7660adb1dcc57f7

--- Comment #17 from Gilles Caulier <[hidden email]> ---
Git commit 617f203acb9fec474c95c3dbd7660adb1dcc57f7 by Gilles Caulier.
Committed on 01/09/2014 at 06:05.
Pushed by cgilles into branch 'master'.

For dumy DNG file badbly encode and unsupported by libraw, try to use Exiv2
preview extraction to render thumbnail.
FIXED-IN: 4.3.0

M  +13   -1    libs/threadimageio/thumbnailcreator.cpp

http://commits.kde.org/digikam/617f203acb9fec474c95c3dbd7660adb1dcc57f7

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #18 from Gilles Caulier <[hidden email]> ---
DrSlony,

The RAW Demosaicing problem still here. As HDRMerge do not provide a valid DNG
file which can be processed with libraw, report this problem to HDRMerge team
for future fixes. This problem cannot be solved in digiKam code.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=338081

--- Comment #19 from DrSlony <[hidden email]> ---
CG thank you VERY much for this patch! Seeing thumbs will make things so much
easier :)
I don't need digiKam to read the raw data, just showing the thumbnails is
enough.

ps. I've been collaborating with various teams for HDR-DNG thumbnail/preview
support, and I sent the report links to Javier Celaya (the HDRMerge dev). I
pasted the link in comment #16. As far as I am aware the DNG files are not
"badly encoded", there is nothing wrong with them. The only problem is libraw
does not supporting floating point data, and attempts to read both the raw data
and the thumb in one call, so if reading the raw data fails, which it will,
then reading the thumb will fail too, which it should not.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel