[digikam] [Bug 337011] New: Image Quality Sorter doesn't apply labels

[Robert Susmilch]

https://bugs.kde.org/show_bug.cgi?id=337011

            Bug ID: 337011
           Summary: Image Quality Sorter doesn't apply labels
    Classification: Unclassified
           Product: digikam
           Version: 4.1.0
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Maintenance
          Assignee: [hidden email]
          Reporter: [hidden email]

Running image quality sorter with various settings for the different reject,
pending and accepted thresholds, as well as weights doesn't do anything (or at
least apply the labels.)

Reproducible: Always

Steps to Reproduce:
1. Open maintenance tool
2. Choose albums, tags, etc to scan
3. Choose image quality sorter
4. Combinations of thresholds and weights don't seem to matter
5. Click ok to run image quality sorter
6. Active process shows it running
7. When done, either use labels filter or advanced search, no labels have been
applied...
Actual Results:  
No labels applied, however manual rejected, pending and accepted labels work as
expected

Expected Results:  
Image quality sorter should apply labels based on settings

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337011

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
I CC Gowtham Ashok who is original author of this feature...

Note : with  digiKam 4.1.0 we now depend of OpenCV 2.4.9

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gowtham Ashok]

https://bugs.kde.org/show_bug.cgi?id=337011

--- Comment #2 from Gowtham Ashok <[hidden email]> ---
I am looking into this. The algorithm is not getting run at all, according to
debug log.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337011

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Gowtham,

Any progress about your investigations in this file ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Henrique Santos Fernandes]

https://bugs.kde.org/show_bug.cgi?id=337011

Henrique Santos Fernandes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Henrique Santos Fernandes <[hidden email]> ---
Archlinux

version 4.5  it does nothing.

What can i do to help?

Thanks

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Schwenk]

https://bugs.kde.org/show_bug.cgi?id=337011

Johannes Schwenk <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Johannes Schwenk <[hidden email]> ---
I can confirm this behavior for 4.6.0 and OpenCV 2.4.9 on Ubuntu amd64. Do you
need additional information? How can I help?

Also, the scanner does not honor the album selection. Even when I am selecting
only one album, the process runs for all albums in the collection. I will open
another bug report for this.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337011

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Created attachment 90758
  --> https://bugs.kde.org/attachment.cgi?id=90758&action=edit
qualitysorter.patch

This patch restore the function of quality sorter in maintenance thread.
The quality sorter seems provide accurate results.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337011

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Image Quality Sorter        |Image Quality Sorter
                   |doesn't apply labels        |doesn't apply labels
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337011

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90758|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337011

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Created attachment 90760
  --> https://bugs.kde.org/attachment.cgi?id=90760&action=edit
qualitysorter2.patch

Patch 2 fixes the dysfunction when selecting the Scanmode.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337011

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.8.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/c4956b73fc290015fbe8c1e
                   |                            |6d6153b01874473e3
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Git commit c4956b73fc290015fbe8c1e6d6153b01874473e3 by Gilles Caulier.
Committed on 05/02/2015 at 09:38.
Pushed by cgilles into branch 'master'.

apply patch #90760 from Maik Qualmann to restore Image Quality Sorter tool
functionnalities
FIXED-IN: 4.8.0

M  +2    -1    NEWS
M  +50   -37   libs/database/imgqsort/imgqsort.cpp
M  +3    -2    libs/database/imgqsort/imgqsort.h
M  +11   -7    utilities/maintenance/imagequalitytask.cpp
M  +1    -1    utilities/maintenance/maintenancedlg.cpp

http://commits.kde.org/digikam/c4956b73fc290015fbe8c1e6d6153b01874473e3

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337011

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Git commit b2d67ec88b62a0d9801a6835e8900be87281e3d6 by Gilles Caulier.
Committed on 05/02/2015 at 10:31.
Pushed by cgilles into branch 'frameworks'.

backport comit #c4956b73fc290015fbe8c1e6d6153b01874473e3 from git/master to
frameworks brnach

M  +50   -37   libs/database/imgqsort/imgqsort.cpp
M  +3    -2    libs/database/imgqsort/imgqsort.h
M  +11   -7    utilities/maintenance/imagequalitytask.cpp
M  +1    -1    utilities/maintenance/maintenancedlg.cpp

http://commits.kde.org/digikam/b2d67ec88b62a0d9801a6835e8900be87281e3d6

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337011

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Created attachment 90951
  --> https://bugs.kde.org/attachment.cgi?id=90951&action=edit
delete.patch

Coverity Scan found a defect in the qualitysorter2.patch. This patch should fix
it.

>>> Deleting array variable "maxIdx" with non-array delete in "delete maxIdx".

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337011

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Git commit 32397e04f48da794cba8d8e33eb0ba015b495f84 by Gilles Caulier.
Committed on 06/02/2015 at 21:57.
Pushed by cgilles into branch 'master'.

apply patch #90951

M  +2    -2    libs/database/imgqsort/imgqsort.cpp

http://commits.kde.org/digikam/32397e04f48da794cba8d8e33eb0ba015b495f84

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337011

--- Comment #12 from Gilles Caulier <[hidden email]> ---
Git commit 824e2ece4f58ebabc461866968b736761d73a029 by Gilles Caulier.
Committed on 06/02/2015 at 21:59.
Pushed by cgilles into branch 'frameworks'.

backport commit #c4956b73fc290015fbe8c1e6d6153b01874473e3 from git/master to
frameworks branch

M  +1    -1    libs/database/imgqsort/imgqsort.cpp

http://commits.kde.org/digikam/824e2ece4f58ebabc461866968b736761d73a029

diff --git a/libs/database/imgqsort/imgqsort.cpp
b/libs/database/imgqsort/imgqsort.cpp
index d2583aa..ea2570f 100644
--- a/libs/database/imgqsort/imgqsort.cpp
+++ b/libs/database/imgqsort/imgqsort.cpp
@@ -340,7 +340,7 @@ double ImgQSort::blurdetector() const
     qCDebug(DIGIKAM_GENERAL_LOG) << "The maximum of the edge intensity is " <<
maxval;
     qCDebug(DIGIKAM_GENERAL_LOG) << "The result of the edge intensity is  " <<
blurresult;

-    delete maxIdx;
+    delete [] maxIdx;
     return blurresult;
 }

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel