[digikam] [Bug 336127] New: Rename pattern textbox not tall enough and uses hard-coded font colors

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

            Bug ID: 336127
           Summary: Rename pattern textbox not tall enough and uses
                    hard-coded font colors
    Classification: Unclassified
           Product: digikam
           Version: 4.0.0
          Platform: Gentoo Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

The rename pattern textbox is not tall enough, so I don't see underscores:
http://i.imgur.com/9rvwTJ9.png
Can you guess with set of double-quotes has the underscore?

Also the colors are hard-coded, so it's hard to see that blue color.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from DrSlony <[hidden email]> ---
This has not been touched in 4.2.0.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=336127

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Advanced Rename

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=336127

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0                       |4.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

--- Comment #2 from DrSlony <[hidden email]> ---
Still present in 4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.2.0                       |4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=336127

Paul <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Paul <[hidden email]> ---
Created attachment 89246
  --> https://bugs.kde.org/attachment.cgi?id=89246&action=edit
Rename pattern textbox.

Theme related?

Underscores visible here... using Version 4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

--- Comment #4 from DrSlony <[hidden email]> ---
I tried the following and it made no difference:
- digiKam > Settings > Theme
- System Settings > Workspace Appearance > Window Decorations
- System Settings > Workspace Appearance > Desktop Theme
- System Settings > Application Appearance > Style > Widget style
- System Settings > Application Appearance > Style > Colors

Changing the font
- System Settings > Application Appearance > Style > Fonts > General
has an influence. When I use DejaVu Sans, Droid Sans or Ubuntu Sans then I
don't see the underscores, when I use some other whacky font then I do. Either
way, ALL other applications work fine using any of these fonts, so this issue
must be resolved within this rename dialog, at least by adding bottom padding.
http://i.imgur.com/Ew8okvJ.png

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=336127

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Paul, it's easy to verify. Go to digiKam/Configuration dialog into Misc
Section, and change widget style.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=336127

--- Comment #6 from Paul <[hidden email]> ---
Created attachment 89250
  --> https://bugs.kde.org/attachment.cgi?id=89250&action=edit
Rename pattern textbox - Oxygen widgets

Changing the widget style that digiKam uses to Oxygen (from qtcurve I normally
use) results in the text box becoming too small vertically, as DrSlony
reported.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.4.0                       |4.5.0

--- Comment #7 from DrSlony <[hidden email]> ---
Still present in 4.5.0. Also a problem elsewhere, e.g. in the "customize
filename" textbox in the BQM
http://i.imgur.com/zgNJJzL.png
"[file] _ underscores here _ _ _"

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

--- Comment #8 from DrSlony <[hidden email]> ---
Still a problem in 4.6.0.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

--- Comment #9 from DrSlony <[hidden email]> ---
I tried the following widget styles:
Oxygen, Phase, Windows, Motif, CDE, Plastique and Cleanlooks.
Cleanlooks is the only one where I could see the underscores.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=336127

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.5.0                       |4.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=336127

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Created attachment 90196
  --> https://bugs.kde.org/attachment.cgi?id=90196&action=edit
renameinput.patch

This patch fixes the incorrect size of the rename input and change the blue
color in light blue.
I tested it with different fonts / sizes and different styles.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=336127

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rename pattern textbox not  |Rename pattern textbox not
                   |tall enough and uses        |tall enough and uses
                   |hard-coded font colors      |hard-coded font colors
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=336127

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/6d4982ebee343bd6f168cab
                   |                            |5c4961fc1f57aebdc
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Git commit 6d4982ebee343bd6f168cab5c4961fc1f57aebdc by Gilles Caulier.
Committed on 03/01/2015 at 10:11.
Pushed by cgilles into branch 'master'.

Apply patch #90196 from Maik Qualmann to fix advance rename pattern box GUI
FIXED-IN : 4.7.0

M  +2    -1    NEWS
M  +7    -3    utilities/advancedrename/advancedrenameinput.cpp
M  +1    -1    utilities/advancedrename/common/highlighter.cpp

http://commits.kde.org/digikam/6d4982ebee343bd6f168cab5c4961fc1f57aebdc

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=336127

--- Comment #12 from Gilles Caulier <[hidden email]> ---
Git commit 95b693303f45d5ca360b87fc775916fe635d3656 by Gilles Caulier.
Committed on 03/01/2015 at 10:19.
Pushed by cgilles into branch 'frameworks'.

backport commit # 6d4982ebee343bd6f168cab5c4961fc1f57aebdc from git/master to
frameworks branch

M  +6    -3    utilities/advancedrename/advancedrenameinput.cpp
M  +1    -1    utilities/advancedrename/common/highlighter.cpp

http://commits.kde.org/digikam/95b693303f45d5ca360b87fc775916fe635d3656

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel