[digikam] [Bug 335718] New: Tag manager: Removing a tag turns entries in "Quick Access List" to "All tags"

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=335718

            Bug ID: 335718
           Summary: Tag manager: Removing a tag turns entries in "Quick
                    Access List" to "All tags"
    Classification: Unclassified
           Product: digikam
           Version: 4.1.0
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]

Reproducible: Always

Steps to Reproduce:
1. Create a tag "testtag" in the tree structure.
2. Add the tag "testtag" to the "Quick Access List".
3. Delete the tag "testtag" in the tree structure.
Actual Results:  
The item that was previously the entry for "testtag" in the "Quick Access List"
now reads "All tags". It can not be removed from the "Quick Access List" via
the context menu.

Expected Results:  
The removed tag should be removed from the "Quick Access List".

Closing and re-opening the tag editor clears the list from the broken tag
references.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=335718

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #1 from Veaceslav Munteanu <[hidden email]> ---
Confirmed.. investigating...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=335718

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/a7d349d08601f48cacec238
                   |                            |9047d3d7c40407b0f

--- Comment #2 from Veaceslav Munteanu <[hidden email]> ---
Git commit a7d349d08601f48cacec2389047d3d7c40407b0f by Veaceslav Munteanu.
Committed on 08/06/2014 at 14:59.
Pushed by munteanu into branch 'master'.

M  +3    -1    NEWS
M  +0    -4    digikam/tags/tagsmanager/models/tagmngrlistmodel.cpp
M  +1    -0    digikam/tags/tagsmanager/taglist.cpp

http://commits.kde.org/digikam/a7d349d08601f48cacec2389047d3d7c40407b0f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=335718

--- Comment #3 from Michael G. Hansen <[hidden email]> ---
Created attachment 87069
  --> https://bugs.kde.org/attachment.cgi?id=87069&action=edit
Duplicate entries after deletion

Hi Veaceslav,

the entry in the quick access list is now properly deleted. However, if the tag
corresponding to the currently active filter is deleted, some other filter, for
example "All tags" should be selected IMHO. Currently, no new selection is
made.

Also, if I add tags 1,2,3, then set a filter using quick access list on 2, then
delete 2, the tree view shows 1,1,3 as shown in the screenshot...

Best regards,

Michael

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=335718

Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=335718

--- Comment #4 from Veaceslav Munteanu <[hidden email]> ---
Hmm... actually, with previous commit I set to reset to default All Tags when a
selected entry is deleted.. but the is not visual feedback that is selected...
I will look into it..

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=335718

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Tag manager: Removing a tag |MANAGER : removing a tag
                   |turns entries in "Quick     |turns entries in "Quick
                   |Access List" to "All tags"  |Access List" to "All tags"

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=335718

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|http://commits.kde.org/digi |http://commits.kde.org/digi
                   |kam/a7d349d08601f48cacec238 |kam/57204f0cc849f4e4c6ccc5f
                   |9047d3d7c40407b0f           |2963a1f2f0a0ec4dd

--- Comment #5 from Veaceslav Munteanu <[hidden email]> ---
Git commit 57204f0cc849f4e4c6ccc5f2963a1f2f0a0ec4dd by Veaceslav Munteanu.
Committed on 02/09/2014 at 13:08.
Pushed by munteanu into branch 'master'.

M  +2    -1    NEWS
M  +4    -0    digikam/tags/tagsmanager/taglist.cpp

http://commits.kde.org/digikam/57204f0cc849f4e4c6ccc5f2963a1f2f0a0ec4dd

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=335718

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=335718

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tags                        |Tags-Manager

--
You are receiving this mail because:
You are the assignee for the bug.