[digikam] [Bug 332280] New: digikam-4.0.0-beta3/core/libs/dimg/filters/transform/freerotationfilter.cpp:94] -> [/home/dcb/rpmbuild/BUILD/digikam-4.0.0-beta3/core/libs/dimg/filters/transform/freerotationfilter.cpp:92]: (style) Same expression on both sides of '||'.

[dcb314]

https://bugs.kde.org/show_bug.cgi?id=332280

            Bug ID: 332280
           Summary: digikam-4.0.0-beta3/core/libs/dimg/filters/transform/f
                    reerotationfilter.cpp:94] ->
                    [/home/dcb/rpmbuild/BUILD/digikam-4.0.0-beta3/core/lib
                    s/dimg/filters/transform/freerotationfilter.cpp:92]:
                    (style) Same expression on both sides of '||'.
    Classification: Unclassified
           Product: digikam
           Version: 4.0.0-beta3
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Filters
          Assignee: [hidden email]
          Reporter: [hidden email]

Source code is

    if (p1.x() < 0 ||
        p2.y() < 0 ||
        p1.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

Maybe something like

    if (p1.x() < 0 ||
        p1.y() < 0 ||
        p2.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

was intended.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332280

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/5ac520779fce2238610e079
                   |                            |36ca8ecaa7802a177

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Git commit 5ac520779fce2238610e07936ca8ecaa7802a177 by Gilles Caulier.
Committed on 18/03/2014 at 12:47.
Pushed by cgilles into branch 'master'.

fix comparison arguments in head of calculateAngle fonction
FIXED-IN: 4.0.0

M  +22   -24   libs/dimg/filters/transform/freerotationfilter.cpp
M  +5    -5    libs/dimg/filters/transform/freerotationfilter.h

http://commits.kde.org/digikam/5ac520779fce2238610e07936ca8ecaa7802a177

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332280

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|digikam-4.0.0-beta3/core/li |freerotationfilter.cpp:92:
                   |bs/dimg/filters/transform/f |(style) Same expression on
                   |reerotationfilter.cpp:94]   |both sides of '||'.
                   |->                          |
                   |[/home/dcb/rpmbuild/BUILD/d |
                   |igikam-4.0.0-beta3/core/lib |
                   |s/dimg/filters/transform/fr |
                   |eerotationfilter.cpp:92]:   |
                   |(style) Same expression on  |
                   |both sides of '||'.         |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332280

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0-beta3                 |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel