[digikam] [Bug 331597] New: Tags are not sorted in UI

[Michal Sylwester]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #19 from Michal Sylwester <[hidden email]> ---
Ok, thats fine with me :)

I was just afraid that its getting away from the model suggested by qt, making
things confusing. Or at least it got quite confusing for me when I was trying
to debug this problem, and the sort role was never requested for albums the way
I expected it to happen according to qt docs. It suggested that the specialized
code should be where the value for sort order is returned, so that's what I was
looking for, and that's what I tried to do with my patch. Oh, I'm getting
boring again...

Anyway, I'm glad this will make it into the 4.0 :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mohamed]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #20 from Mohamed <[hidden email]> ---
That discussion was useful and active, and not boring at all.
Thanks for reporting the issue to the bugzilla.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #21 from Gilles Caulier <[hidden email]> ---
Git commit fa2ae1d7254c3b08e1a94d840aac06623722752e by Mohamed Anwer.
Committed on 08/05/2014 at 03:16.
Pushed by mohamedanwer into branch 'master'.

Removing magic number and polish

M  +4    -3    libs/models/albumfiltermodel.cpp

http://commits.kde.org/digikam/fa2ae1d7254c3b08e1a94d840aac06623722752e

diff --git a/libs/models/albumfiltermodel.cpp
b/libs/models/albumfiltermodel.cpp
index d095a90..42b43d7 100644
--- a/libs/models/albumfiltermodel.cpp
+++ b/libs/models/albumfiltermodel.cpp
@@ -342,15 +342,16 @@ bool AlbumFilterModel::lessThan(const QModelIndex& left,
const QModelIndex& righ
     QVariant valRight = right.data(sortRole());

     AlbumSettings::AlbumSortOrder sortRole =
AlbumSettings::instance()->getAlbumSortOrder();
+    AlbumSettings::StringComparisonType strComparisonType =
AlbumSettings::instance()->getStringComparisonType();

     if (leftAlbum && rightAlbum)
     {
-        if(leftAlbum->type() == 0 && rightAlbum->type()== 0)//checking for
PAlbums
+        if(leftAlbum->type() == Album::PHYSICAL && rightAlbum->type()==
Album::PHYSICAL)
         {
             switch (sortRole)
             {
                 case AlbumSettings::ByFolder:
-                    switch
(AlbumSettings::instance()->getStringComparisonType())
+                    switch (strComparisonType)
                     {
                         case AlbumSettings::Natural:
                             return
KStringHandler::naturalCompare(leftAlbum->title(), rightAlbum->title(),
sortCaseSensitivity()) < 0;
@@ -369,7 +370,7 @@ bool AlbumFilterModel::lessThan(const QModelIndex& left,
const QModelIndex& righ
         {
             if((valLeft.type() == QVariant::String) && (valRight.type() ==
QVariant::String))
             {
-                switch (AlbumSettings::instance()->getStringComparisonType())
+                switch (strComparisonType)
                 {
                     case AlbumSettings::Natural:
                         return
KStringHandler::naturalCompare(valLeft.toString(), valRight.toString(),
sortCaseSensitivity()) < 0;

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #22 from Gilles Caulier <[hidden email]> ---
Mohamed, Michal,

Can be conderate this entry fixed or not for 4.0.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michal Sylwester]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #23 from Michal Sylwester <[hidden email]> ---
I'd say close this as fixed for 4.0.0 (tags are sorted, and this is what this
bug is about), and open a separate bug for fixing the other issues (fix
category sort and work out how to sort albums with same date). I guess it can
be done together with the other planned work Mohamed mentioned.

Michal

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331597

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.0.0
         Resolution|---                         |FIXED

--- Comment #24 from Gilles Caulier <[hidden email]> ---
Thanks Michal,

I close this file. Don't forget to report others issues in new files

Thanks for your feedback

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mohamed]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #25 from Mohamed <[hidden email]> ---
Mr Michal,
Would you please mention how to reproduce the problem of sorting "by category",
because sorting by category works for me as expected.
Thanks in advance.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michal Sylwester]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #26 from Michal Sylwester <[hidden email]> ---
Hi Mohamed,

Sorry, my mistake, category sort works fine. I think my problem is that
updating metadata does not automatically updates the treeview, I have to
trigger it manually (like by clicking on the column header). Can you reproduce
this?

Michal

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mohamed]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #27 from Mohamed <[hidden email]> ---
Yes, I know that.
It can be considered a wish.

Mohamed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331597

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0-beta3                 |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel