[digikam] [Bug 328457] New: Watermark tool doesn't apply zero margins

[tosca]

https://bugs.kde.org/show_bug.cgi?id=328457

            Bug ID: 328457
           Summary: Watermark tool doesn't apply zero margins
    Classification: Unclassified
           Product: digikam
           Version: 3.5.0
          Platform: Fedora RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Batch Queue Manager
          Assignee: [hidden email]
          Reporter: [hidden email]

When adding a watermark with both X and Y margins set to 0%, there seem to be
at least 1 remaining pixel on one or two margin(s).

Reproducible: Always

Steps to Reproduce:
1. put a picture in the batch queue
2. set up the watermark tool with a .png file bigger than the picture, and set
size to 100% and X and Y margins to 0
3. run BQM
Actual Results:  
Generated picture always has at least 1 pixel margin on one or two margins,
depending on the placement choice.

Expected Results:  
Zero margins on all four sides of the picture.

I use this tool to add a drop shadow on all four sides of the picture, to add
it more depth. But this won't work if there some margins remain on one or two
sides.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=328457

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Watermark tool doesn't      |BQM Watermark tool :
                   |apply zero margins          |doesn't apply zero margins

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=328457

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Tool-Inse
                   |                            |rtText

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=328457

Ahmed Fathi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmed.fathi.abdelmageed@gma
                   |                            |il.com

--- Comment #1 from Ahmed Fathi <[hidden email]> ---
Created attachment 103576
  --> https://bugs.kde.org/attachment.cgi?id=103576&action=edit
a patch to solve the margin problem

HI , I solved this "bug" and here is the batch .
In the following post I will send screenshots

There were two problems :-

First in the function calls : watermarkRect.moveTopRight() ,
watermarkRect.moveBottomLeft(), watermarkRect.moveBottomRight() , We needed to
pass (Width -1 ) and (height -1 ) instead of Width and height.

The second problem was that the watermark photo has a different aspect ration
than the original photo. An option to "Keep Aspect ratio" of the waterMark was
used, so however large the watermark Image was , keeping its aspect ratio will
always leave spaces in the actual image.
Changing the option from Qt::KeepAspectRatio  to  Qt::IgnoreAspectRatio  will
solve the problem and make the watermark always have the aspect ratio of the
original photo as @mnaugendre requires. but it is not logical to Always ignore
the aspect ratio of the watermark and stretch it to be exactly like the image.
So I added a new checkbox to allow the user to ignore the water mark aspect
ratio If that is what he really needs , which is unchecked by default.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=328457

--- Comment #2 from Ahmed Fathi <[hidden email]> ---
Created attachment 103577
  --> https://bugs.kde.org/attachment.cgi?id=103577&action=edit
Screen shots for before and after the batch

Screen shots for
1- before the batch
2- after the batch with the new Checkbox Checked
3- after the batch with the new Checkbox UnChecked

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=328457

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |5.5.0
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/921115bd46668b1ce54db3
                   |                            |2080d6d2f76c10ea52
         Resolution|---                         |FIXED

--- Comment #3 from [hidden email] ---
Git commit 921115bd46668b1ce54db32080d6d2f76c10ea52 by Gilles Caulier.
Committed on 22/01/2017 at 10:48.
Pushed by cgilles into branch 'master'.

apply patch #103576 from Ahmed Fathi
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +61   -41   utilities/queuemanager/tools/decorate/watermark.cpp
M  +1    -1    utilities/queuemanager/tools/decorate/watermark.h

https://commits.kde.org/digikam/921115bd46668b1ce54db32080d6d2f76c10ea52

--
You are receiving this mail because:
You are the assignee for the bug.