[digikam] [Bug 328294] New: bootstrap.local invokes wrong shell

[Sven Coenye]

https://bugs.kde.org/show_bug.cgi?id=328294

            Bug ID: 328294
           Summary: bootstrap.local invokes wrong shell
    Classification: Unclassified
           Product: digikam
           Version: 3.5.0
          Platform: Debian stable
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: setup
          Assignee: [hidden email]
          Reporter: [hidden email]

In Debian Wheezy and derivatives, the default shell was changed from Bash to
Dash. Dash offers better performance during boot but does not support all
Bash's extensions to POSIX.
bootstrap.local invokes /bin/sh but the CLEANROOT test uses Bash specific
syntax. As a result, it now fails to run properly.

This script should either invoke /bin/bash, or the CLEANROOT test should be
changed to use POSIX syntax (i.e. use = instead of ==).

(There are dozens more scripts in the source tree doing the same thing. At the
moment, I can't say which ones would break as I'm just starting to get 3.5.0 to
compile.)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=328294

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|setup                       |Portability

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Sven,

If you have a patch, i can apply it to git/master...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Sven Coenye]

https://bugs.kde.org/show_bug.cgi?id=328294

--- Comment #2 from Sven Coenye <[hidden email]> ---
Created attachment 83889
  --> https://bugs.kde.org/attachment.cgi?id=83889&action=edit
Patch to make CLEANROOT test POSIX safe

This makes bootstrap.local run properly under Dash without having to invoke
Bash.

(Note: I'm an SVN operator. This was my first attempt at a Git patch. Beware...
;-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=328294

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/scra
                   |                            |tch/mwiesweg/digikam-sc/907
                   |                            |9970a9239b2bed5d12c39e50282
                   |                            |957470e5eb

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Git commit 9079970a9239b2bed5d12c39e50282957470e5eb by Gilles Caulier.
Committed on 03/12/2013 at 07:01.
Pushed by cgilles into branch 'master'.

Apply patch #83889 to be compatible with POSIX
FIXED-IN: 4.0.0

M  +1    -1    bootstrap.local

http://commits.kde.org/scratch/mwiesweg/digikam-sc/9079970a9239b2bed5d12c39e50282957470e5eb

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=328294

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|bootstrap.local invokes     |bootstrap.local invokes
                   |wrong shell                 |wrong shell [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel