[digikam] [Bug 324349] New: Removing tags limited to 250 selected pictures

[Slobodan Simic]

https://bugs.kde.org/show_bug.cgi?id=324349

            Bug ID: 324349
           Summary: Removing tags limited to 250 selected pictures
    Classification: Unclassified
           Product: digikam
           Version: 3.3.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Database
          Assignee: [hidden email]
          Reporter: [hidden email]

Option to remove tag is grayed out if you select more than 250 pictures while
when assigning tags you can do it to entire collection. So if you assign some
tag to a pictures by mistake, when you removing it you need to select 250 by
250...
It's a bit annoying when you have few thousands of photos.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=324349

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]
          Component|Database                    |Tags

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Veaceslav,

Can you confirm this problem through your Tags Manager ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=324349

--- Comment #2 from Veaceslav Munteanu <[hidden email]> ---
I will check it on my desktop computer, with my laptop, I don't have a enough
big collection :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=324349

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #3 from Veaceslav Munteanu <[hidden email]> ---
Here is the relevant piece of code & comment about performace:

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/utils/contextmenuhelper.cpp#L500

it's limited to 250 indeed :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=324349

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Right.

As it's a limitation in context menu option, this behavior can be/must be
different in Tags Manager.

Also, this limitation must show a message-box warnings...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=324349

--- Comment #5 from Veaceslav Munteanu <[hidden email]> ---
Tags Manager is a little bit different:

It should be like Delete Selected Tag from Images

But here is Select images and remove Tag.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=324349

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/c2ba1fa1d43c04e9e7b72dd
                   |                            |43a32d4c645ab0d5d

--- Comment #6 from Marcel Wiesweg <[hidden email]> ---
Git commit c2ba1fa1d43c04e9e7b72dd43a32d4c645ab0d5d by Marcel Wiesweg.
Committed on 03/09/2013 at 20:04.
Pushed by mwiesweg into branch 'master'.

I believe this performance check ended with the wrong result of cutting
the feature instead of cutting "intelligent" checks.
If >250 images are selected, do not check if they have tags - that may be
costly - but simply
leave the action enabled.

M  +2    -2    digikam/utils/contextmenuhelper.cpp

http://commits.kde.org/digikam/c2ba1fa1d43c04e9e7b72dd43a32d4c645ab0d5d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=324349

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel