[digikam] [Bug 323165] New: Delete pictures and folders are not removed from table-view

[Thomas Arend]

https://bugs.kde.org/show_bug.cgi?id=323165

            Bug ID: 323165
           Summary: Delete pictures and folders are not removed from
                    table-view
    Classification: Unclassified
           Product: digikam
           Version: 3.2.0
          Platform: openSUSE RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: grave
          Priority: NOR
         Component: TableView
          Assignee: [hidden email]
          Reporter: [hidden email]

Delete pictures and folders are not removed from table-view.

Reproducible: Always

Steps to Reproduce:
1. Select a picture
2. Delete it or move it to trash
3.
Actual Results:  
Preview jumps to next picture but the deleted picture is not removed from
preview / table view. When reselecting delete picture an error message is
displayed saying picture does not exist.

Expected Results:  
Deleted pictures should be removed from of lists / table views or light room
views.

This feature is know unusable for productive use.

I remember we had this problem in an earlier version. No need to reintroduce
old bugs!

Digikam was a good working horse.  Was! Would be nice if you make less but
better tested changes.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=323165

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #1 from Smit Mehta <[hidden email]> ---
Hi Thomas

Thanks for your feedback.

I confirm this bug. I shall look into it.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=323165

--- Comment #2 from Smit Mehta <[hidden email]> ---
@Gilles

I think there is some inherent problem with updating the views. In all the
three modes, there is NO code to handle the updation of the views. There is
only code for moving the selection to the next image. I can reproduce it in
icon, preview and table mode. See if you can do it as well.

See the relevant code here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/items/digikamimageview.cpp#L524

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/tableview.cpp#L443

Also, there is a 'signalItemsChanged()' in TableView, which by name, I thought
would take care of this. But there is NO code to catch this signal in the
entire project. Am I missing anything here?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=323165

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.2.0                       |3.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323165

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Smit,

Table View have been written by Michael. I CC him...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=323165

--- Comment #4 from Michael G. Hansen <[hidden email]> ---
Hi Smit,

signalImagesChanged is caught here:
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/digikamview.cpp#L482

Deletion works fine on my system using digiKam 3.2 and I think I made hardly
any changes after that version, so tableview code is probably not be to blame
here. Also, tableview mostly monitors the ImageModel, which takes care of
deletion on its own. Maybe using git bisect may help to find the problem...

Michael

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=323165

--- Comment #5 from Michael G. Hansen <[hidden email]> ---
Of course I mean signalItemsChanged ;-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=323165

--- Comment #6 from Smit Mehta <[hidden email]> ---
Hi Michael

Can you please update your digiKam to git/master and see if you can reproduce
the bug?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=323165

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Smit Mehta <[hidden email]> ---
Hi

Current git/master works fine. I didn't realise that I was on dev/tagmngr
branch.

@Veaceslav, by git bisect, I have been able to narrow down the problem to these
two commits.
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/a074c3cb6ffac139ab67bec4eaad6c513477e051
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/c2bae8a55ebda8e6a7d7a157dcd5218a575a25b3

Kindly see if you can reproduce the bug. If yes, then fix it. :-)

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=323165

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |UNCONFIRMED
     Ever confirmed|1                           |0

--- Comment #8 from Veaceslav Munteanu <[hidden email]> ---
Thank you Smit, I was able to track it down. It was only my mistake when
porting to QList, I didn't find any other bugs related to this issue.

And I can't reproduce this bug anymore...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=323165

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/606db1c6a50ab5644f6870d
                   |                            |6050f9bb49911197d

--- Comment #9 from Smit Mehta <[hidden email]> ---
Git commit 606db1c6a50ab5644f6870d6050f9bb49911197d by Smit Mehta.
Committed on 11/08/2013 at 23:58.
Pushed by smitmehta into branch 'master'.

update

M  +2    -1    NEWS

http://commits.kde.org/digikam/606db1c6a50ab5644f6870d6050f9bb49911197d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=323165

--- Comment #10 from Veaceslav Munteanu <[hidden email]> ---
Well, this is odd... after all is not necessary to change something in
TableView to break it.

Also, what I learnt from tracking the bug on my branch, that changes in
ImageAlbumModel can be a source of bugs...

P.s. Anyone with Suse rpms that can confirm this bug?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel