digiKam › digikam-devel

[digikam] [Bug 320304] New: Aspect ratio not rounded, displays useless fractions

Classic

List

8 messages Options

Options

Michael G. Hansen

[digikam] [Bug 320304] New: Aspect ratio not rounded, displays useless fractions

https://bugs.kde.org/show_bug.cgi?id=320304

Bug ID: 320304
Summary: Aspect ratio not rounded, displays useless fractions
Classification: Unclassified
Product: digikam
Version: 3.3.0
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: minor
Priority: NOR
Component: general
Assignee: [hidden email]
Reporter: [hidden email]

For images which do not have exactly an aspect ratio of for example 3:2, the
aspect ratio is for example displayed as 1953:1301 (1.50). However, 1953:1301
is not really useful for human interpretation ;-) I suggest to use rounding for
the conversion to fractions, and instead display more digits for the
non-fractional display, allowing the user to easily see how closely the image
resembles the aspect ratio: 3:2 (1.5012).

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 320304] Aspect ratio not rounded, displays useless fractions

https://bugs.kde.org/show_bug.cgi?id=320304

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[hidden email],
| |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Pankaj,

I remember that you have work on Aspect Ratio info features in the past.

Any help are welcome here...

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 320304] Aspect ratio not rounded, displays useless fractions

In reply to this post by Michael G. Hansen

https://bugs.kde.org/show_bug.cgi?id=320304

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|general |Usability

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 320304] Aspect ratio not rounded and displays useless fractions

In reply to this post by Michael G. Hansen

https://bugs.kde.org/show_bug.cgi?id=320304

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Aspect ratio not rounded, |Aspect ratio not rounded
|displays useless fractions |and displays useless
| |fractions

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 320304] Aspect ratio not rounded and displays useless fractions

In reply to this post by Michael G. Hansen

https://bugs.kde.org/show_bug.cgi?id=320304

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Git commit 477c457262854d83374961cbdb6d38d5aa1adf42 by Gilles Caulier.
Committed on 11/09/2014 at 09:13.
Pushed by cgilles into branch 'master'.

Factorize : use same code in tooltip and icon-view to show image Aspect Ratio
information.

M +0 -1 app/settings/applicationsettings.h
M +1 -43 app/utils/tooltipfiller.cpp
M +0 -1 app/utils/tooltipfiller.h
M +5 -3 app/views/tableview/tableview_column_item.cpp
M +42 -0 libs/imageproperties/imagepropertiestab.cpp
M +8 -0 libs/imageproperties/imagepropertiestab.h
M +11 -41 libs/widgets/itemview/itemviewimagedelegate.cpp

http://commits.kde.org/digikam/477c457262854d83374961cbdb6d38d5aa1adf42

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 320304] Aspect ratio not rounded and displays useless fractions

In reply to this post by Michael G. Hansen

https://bugs.kde.org/show_bug.cgi?id=320304

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |http://commits.kde.org/digi
| |kam/6a185199cbc523fc82908f8
| |fa05579b2b1c1214d
Status|UNCONFIRMED |RESOLVED
Version Fixed In| |4.4.0

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Git commit 6a185199cbc523fc82908f8fa05579b2b1c1214d by Gilles Caulier.
Committed on 11/09/2014 at 13:01.
Pushed by cgilles into branch 'master'.

Round image aspect ratio fraction to be more human readbale
Addd aspect ration info in image properties panel
FIXED-IN: 4.4.0

M +2 -1 NEWS
M +1 -1 app/utils/tooltipfiller.cpp
M +54 -51 app/views/tableview/tableview_column_item.cpp
M +5 -0 libs/imageproperties/imagepropertiessidebar.cpp
M +11 -0 libs/imageproperties/imagepropertiessidebardb.cpp
M +109 -30 libs/imageproperties/imagepropertiestab.cpp
M +4 -3 libs/imageproperties/imagepropertiestab.h
M +1 -1 libs/widgets/itemview/itemviewimagedelegate.cpp

http://commits.kde.org/digikam/6a185199cbc523fc82908f8fa05579b2b1c1214d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 320304] Aspect ratio not rounded and displays useless fractions

In reply to this post by Michael G. Hansen

https://bugs.kde.org/show_bug.cgi?id=320304

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Git commit e9f2f599ce5853a3ae686c2d3346228fc7c03053 by Gilles Caulier.
Committed on 11/09/2014 at 13:25.
Pushed by cgilles into branch 'master'.

missing to add aspect ratio info in camera image properties tab

M +44 -30 libs/imageproperties/cameraitempropertiestab.cpp
M +3 -3 libs/imageproperties/imagepropertiessidebardb.cpp
M +1 -0 libs/imageproperties/imagepropertiestab.cpp

http://commits.kde.org/digikam/e9f2f599ce5853a3ae686c2d3346228fc7c03053

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

bugzilla_noreply

[digikam] [Bug 320304] Aspect ratio not rounded and displays useless fractions

In reply to this post by Michael G. Hansen

https://bugs.kde.org/show_bug.cgi?id=320304

[hidden email] changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|Usability |ImageEditor

--
You are receiving this mail because:
You are the assignee for the bug.