[digikam] [Bug 318834] New: Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] New: Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

            Bug ID: 318834
           Summary: Images vanish and Properties not shown if image is
                    picked from Image Thumbbar on right and dropped on to
                    the Thumbbar itself
    Classification: Unclassified
           Product: digikam
           Version: 3.2.0-git
          Platform: Ubuntu Packages
               URL: https://drive.google.com/folderview?id=0B6h7Clvq1U_-MU
                    RsMUhJMlQ3TXM&usp=sharing
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
          Assignee: [hidden email]
          Reporter: [hidden email]

If I pick an Image from the Image Thumbbar on the right of Image Editor, and
drop it onto the Image Thumbbar itself, then all images except the picked one
vanishes and Properties sidebar on the left becomes unable to show properties
of even the single image that remains.

*True for ImageEditor opened with single Image or Multiple Images.

*Bug only in Digikam:ImageEditor Image ThumbBar(on the right), not in ShowFoto
Thumbbar as it does not use drag and drop or Light Digikam Image Thumbbar as it
supports Grouping of Images on Drag and Drop. It is not even in Light Table
Image Thumbbar.

Reproducible: Always

Steps to Reproduce:
1.Open Digikam,select 1 or more Images and Open them with ImageEditor using
F4(or Edit).The properties of the images are shown.
2.Pick an image from the ImageEditor:Image ThumbBar(on the left)
3.Drop it onto the Image ThumbBar itself.
Actual Results:  
All Images except the picked one vanishes and Properties in the properties
sidebar(on the left) are not shown thereon(even after clicking on the image
that remained in the ImageThumbBar).

Expected Results:  
Images in the ImageThumbbar(left) must not vanish,they should occupy their
original position in the ThumbBar.
Properties in the properties sidebar(right) must not vanish, they should be
shown according to the current selection whether the image is drag&dropped or
not.

PlatForm & OS : KDE Linux Mint 14

Digikam Version: 3.2-beta2 (git)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #1 from Pravesh Gupta <[hidden email]> ---
URL for the proper Info of the bug.
https://drive.google.com/folderview?id=0B6h7Clvq1U_-MURsMUhJMlQ3TXM&usp=sharing
H
ere you can find the screenshots and info related to the bug.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
I think this is a side effect of model/view coded from Album GUI icon-view and
re-used to Image Editor thumbbar.

In fact, icons from thumbbar use model from icon-view. Try to use D&D in
icon-view in same context and look if dysfunction is reproducible. If i
remember D&D in icon-view create a "Group Here" of items. This must be the same
effect in thumbbar, but of course, we don't need grouping feature here...

Anyway, a typical fix in my mind will be to disable D&D from thumbbar to
thumbbar. D&D from Thumbbar  to another place in digiKam (and vis-versa)digikam
 must still enabled.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Pravesh Gupta
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #3 from Pravesh Gupta <[hidden email]> ---
If I make m_readonly attribute of ImageDragDropHandler as false by
d->dragDrogHandler->setReadonly(false) (line 355) of main.cpp of ImageEditor,
this bug disappears but then I cannot drop image from the digiKam window to
ImageEditor Window.

I think dropEvent() (line 207) function of ImageDragDropHandler.cpp have to be
reimplemented to detect whether the D&D is from thumbbar to thumbbar and then
return false if detected.

ImageEditor main.cpp :-
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/main/imagewindow.cpp

ImageDragDropHandler.cpp
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/dragdrop/imagedragdrop.cpp

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #4 from Gilles Caulier <[hidden email]> ---
> I think dropEvent() (line 207) function of ImageDragDropHandler.cpp have to be >reimplemented to detect whether the D&D is from thumbbar to thumbbar and then return >false if detected.

==> Yes, exactly. patch is welcome...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Pravesh Gupta
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #5 from Pravesh Gupta <[hidden email]> ---
Or we can reimplement the slotDroppedOnThumbbar function of imageWindow.cpp to
checkout whether the dropped image already resides in the thumbbar and if yes
then return false.

Line 594 of imagewindow.cpp

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/main/imagewindow.cpp

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #6 from Gilles Caulier <[hidden email]> ---
You can try this way

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Pravesh Gupta
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #7 from Pravesh Gupta <[hidden email]> ---
Created attachment 79505
  --> https://bugs.kde.org/attachment.cgi?id=79505&action=edit
Patch for bug id=318834

Since we don't want the files to be dropped which are already present in the
ImageEditor ThumbBar, we only want new files to be edited and dropped and thus
dropEvent() does not come into play. If we drop files, which are already
present in the thumbbar, they would not be loaded as they were already present
in the thumbbar, only the new files will replace the old files.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself

Pravesh Gupta
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #8 from Pravesh Gupta <[hidden email]> ---
Gilles,
Please review the patch.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Images vanish and           |Images vanish and
                   |Properties not shown if     |Properties not shown if
                   |image is picked from Image  |image is picked from Image
                   |Thumbbar on right and       |Thumbbar on right and
                   |dropped on to the Thumbbar  |dropped on to the Thumbbar
                   |itself                      |itself [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/3111747abdbf9f153977f55
                   |                            |7b890eccb05852a96

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Git commit 3111747abdbf9f153977f557b890eccb05852a96 by Gilles Caulier.
Committed on 28/04/2013 at 13:59.
Pushed by cgilles into branch 'master'.

apply modified patch #79505 from Pravesh Gupta

M  +22   -1    utilities/imageeditor/main/imagewindow.cpp

http://commits.kde.org/digikam/3111747abdbf9f153977f557b890eccb05852a96

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Pravesh Gupta
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

Pravesh Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |---

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Pravesh,

Why did you turn bug status ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Pravesh Gupta
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

Pravesh Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

Sorry for that. I was also searching that who turned bug status.
I think I accidently changed it.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

--- Comment #12 from Gilles Caulier <[hidden email]> ---
I do it automatically through git commit...

http://community.kde.org/Sysadmin/GitKdeOrgManual#Commit_hook_keywords

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 318834] Images vanish and Properties not shown if image is picked from Image Thumbbar on right and dropped on to the Thumbbar itself [patch]

Gilles Caulier-4
In reply to this post by Pravesh Gupta
https://bugs.kde.org/show_bug.cgi?id=318834

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.2.0-git                   |3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel