[digikam] [Bug 317943] New: Auto rotate/flip using EXIF Information destroys pictures

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

            Bug ID: 317943
           Summary: Auto rotate/flip using EXIF Information destroys
                    pictures
    Classification: Unclassified
           Product: digikam
           Version: 3.1.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

In an album, I have used the tool:
Image > Auto rotate/flip using EXIF Information

As a result, 95% of the pictures were rotated as expected, but a few pictures
were not or worse were destroyed (i.e. some part of the picture is lost -> I
have put this bug 'critical') !

Actually there are differents problems:
- two pictures were not rotated (orientation remains 'right-top', even after
runing again the autorotate tool)
- some pictures were destroyed: the bottom or the left side of the picture is
lost: see attachments
- some temporary files (JpegRotator-xxxx.digikamtempfile.jpgxxxx) remained in
the pictures' directory (see attachments)

Reproducible: Sometimes




Version of digikam: 3.0 and 3.1
No problem with previous versions (2.*)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #1 from Nicofo <[hidden email]> ---
Created attachment 78687
  --> https://bugs.kde.org/attachment.cgi?id=78687&action=edit
Destroyed picture 1 (bottom part of the picture lost !!)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #2 from Nicofo <[hidden email]> ---
Created attachment 78688
  --> https://bugs.kde.org/attachment.cgi?id=78688&action=edit
Destroyed picture 2 (left part of the picture lost !!)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #3 from Nicofo <[hidden email]> ---
Created attachment 78689
  --> https://bugs.kde.org/attachment.cgi?id=78689&action=edit
Temporary file

This file should have been deleted. As it was not, that probably indicates that
something went wrong...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #4 from Nicofo <[hidden email]> ---
Created attachment 78690
  --> https://bugs.kde.org/attachment.cgi?id=78690&action=edit
Temporary file2

Rem: there was also an empty file:
JpegRotator-aq8526.digikamtempfile.jpg8526

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=317943

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Which image format do you try to rotate : JPEG ?

Which libJPEG you use ? Go to Help/components Info for details.

Check also in your system if jpegturbo lib is installed...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #6 from Nicofo <[hidden email]> ---
(In reply to comment #5)
> Which image format do you try to rotate : JPEG ?
Yes. ~170 jpg files
> Which libJPEG you use ? Go to Help/components Info for details.
LibJPEG: 62
> Check also in your system if jpegturbo lib is installed...
Yes, I guess so:
$ rpm -qa|grep jpeg|sort
libjpeg-turbo-1.2.90-1.fc18.i686
libjpeg-turbo-utils-1.2.90-1.fc18.i686
mjpegtools-libs-2.0.0-5.fc18.i686
openjpeg-libs-1.5.1-4.fc18.i686

> Gilles Caulier
Thanks for your rapid answer !

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #7 from Gilles Caulier <[hidden email]> ---
JPEGTurbo can be the problem. We have never tested it.

Can you run:

- kdebugdialog and trun on digiKam and KExiv2 debug spaces.
- digiKam from a console and process JPEG rotation.
- report console trace here.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #8 from Nicofo <[hidden email]> ---
Created attachment 78691
  --> https://bugs.kde.org/attachment.cgi?id=78691&action=edit
digikam output

Log file attached, as demanded.
This time, I have still problems with:
- IMG_4072.JPG (left side of the picture lost + other distortions)
- IMG_4086.JPG => empty file => picture entirely lost !
- JpegRotator-w11195.digikamtempfile.jpg temporay file (which seems to be the
bottom part of the previous picture IMG_4086)
- JpegRotator-M11195.digikamtempfile.jpg temporay file

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #9 from Nicofo <[hidden email]> ---
(In reply to comment #7)
> JPEGTurbo can be the problem. We have never tested it.
Additional info: I have now Fedora 18 and digikam 3.1,
but with my previous Fedora installation (Fedora 16, digikam 2.5), I had also
libjpeg-turbo.i686 (1.2.1-1.fc16) and no bug.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Strange no ?

digikam(11195)/digikam (core) Digikam::JPEGUtils::jpegutils_jpeg_error_exit:
Jpegutils error, aborting operation: Output file write error --- out of disk
space?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #11 from Nicofo <[hidden email]> ---
(In reply to comment #10)
> Strange no ?
>
> digikam(11195)/digikam (core) Digikam::JPEGUtils::jpegutils_jpeg_error_exit:
> Jpegutils error, aborting operation: Output file write error --- out of disk
> space?
My pictures are on a NTFS windows partition, with 12Go free space.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #12 from Gilles Caulier <[hidden email]> ---
On my computer, i cannot reproduce the problem.

Sure i don't use NTFS, only Ext4. Perhaps it's the problem.

On my computer libjpeg-turbo is installed, including the compatibilty component
to emulate old libjpeg (version 8) with MMX/SSE2 accelerated
compresion/decompression support.

libjpeg-devel:
        The libjpeg-devel package includes the header files necessary for
        developing programs which will manipulate JPEG files using
        the libjpeg library.

        If you are going to develop programs which will manipulate JPEG images,
        you should install libjpeg-devel.  You'll also need to have the libjpeg
        package installed.
:http://sourceforge.net/projects/libjpeg-turbo

libjpeg8:
        This package contains the library needed to run programs dynamically
        linked with libjpeg-turbo.
:http://sourceforge.net/projects/libjpeg-turbo

Can you try to use a non NTFS file system to host JPEG file and perform
rotation to see if problem is reproducible or not ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=317943

Reinhard Biegel <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #13 from Reinhard Biegel <[hidden email]> ---
I can confirm the problem here on my PC. Symptoms exacly as described by user
Nicofo. Noticed it when batch-rotating some images (selecting multiple files
and execute rotation with keyboard shortcut).

I'm using digikam 3.0.0 on a gentoo x86_64 system with libjpeg-turbo 1.2.90,
images located on ext4.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Reinhard,

I also use ext4 and libjpeg-turbo 1.2.90 under Linux Mageia2, and i cannot
reproduce the problem.

Perhaps do you have a better debug trace in the console following my comment #7
?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #15 from Nicofo <[hidden email]> ---
I have tried on an EXT4 fs -> as Reinhard Biegel, the bug is still there ->
it's not related to the files system.

I have the impression that the pictures destroyed are more numerous if computer
is busy by other programs. Or also if for instance dolphin (in preview mode)
updates the pictures at the same time that digikam rotates them.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #16 from Reinhard Biegel <[hidden email]> ---
Created attachment 78914
  --> https://bugs.kde.org/attachment.cgi?id=78914&action=edit
digikam console log (rotation of 56 images)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #17 from Reinhard Biegel <[hidden email]> ---
Created attachment 78916
  --> https://bugs.kde.org/attachment.cgi?id=78916&action=edit
digikam console log (rotation of 4 images)

Sorry for the delay. Updated to 3.1.0, KDE 4.10.2, Qt is 4.8.4 btw.

First log: rotation of 56 images at once (single run). Leaves 9 temporary Files
with filesizes of 0 B, 2 B, a few KiB and 2 files with a few MiB. The bigger
ones seem to contain jpeg data, one of them can partially be read, the other
one cannot be read at all. 2 B files contain 0xFF 0xD8.

Second log: rotation of 4 images at once (multiple runs until images are
damaged). Left 2 Files with 0 B and 2 B respectively. I think first damages
occured at second last run.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=317943

--- Comment #19 from Nicofo <[hidden email]> ---
Hi,
I have made some tests with other software:
- jhead -autorot *.JPG     =>  no problem
- ImageMagick : convert -auto-orient IMG.JPG IMG_NEW.JPG  (done for 50 images
in batch)  => no problem
- gwenview : gwenview doesn't have an autorotate function, so I've made a lot
of rotations with several images at the same time instead => never had any
problem

=> I can only reproduce this bug in digikam.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=317943

Alexander Stein <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.stein@informatik.
                   |                            |tu-chemnitz.de

--- Comment #20 from Alexander Stein <[hidden email]> ---
I also have this problem that after auto-rotate from within an album some
pictures (jpegs) got destroyed completely (0 Bytes) or only 1/3 of the right
side is still there (the left 2/3 are pure gray) as with destroyed picture
attachments from Nicofo.
There seem to be a race condition during rotation. I store both raw and jpeg
from my camera and noticed today that the companion jpeg to the raw file (both
file name prefixes are identical) doesn't match. I took photos of cocktails and
now DSC00954.ARW is an orange one and DSC00954.JPG is a light blue one which I
shot 9 days later.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel