[digikam] [Bug 316620] New: htmlexport don't builds

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=316620

            Bug ID: 316620
           Summary: htmlexport don't builds
    Classification: Unclassified
           Product: digikam
           Version: 3.1.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

htmlexport kipi-plugin don't builds

Reproducible: Always

Actual Results:  
This commit makes impossible compilation of htmlexport even if libxml2 and
libxslt reported as found
http://quickgit.kde.org/?p=kipi-plugins.git&a=commitdiff&h=b5514a7616b3a5b25f678af13fa2573ba1ea3b0f&o=plain


Reverting this patch makes possible htmlexport compilation.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=316620

Rex Dieter <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #1 from Rex Dieter <[hidden email]> ---
confirmed, htmlexport plugin doesn't get built

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=316620

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Kevin Kofler <[hidden email]> ---
These 3 lines:
+    if (NOT LIBXSLT_EXSLT_LIBRARIES AND NOT LIBXSLT_LIBRARIES)
+        set(LIBXSLT_EXSLT_LIBRARIES ${LIBXSLT_LIBRARIES})
+    endif (NOT LIBXSLT_EXSLT_LIBRARIES AND NOT LIBXSLT_LIBRARIES)
in the patch are wrong:
1. There's a typo or thinko (3 times), it should say LIBEXSLT_LIBRARIES
everywhere in these 3 lines, not LIBXSLT_LIBRARIES.
2. There should be no NOT in front of LIBEXSLT_LIBRARIES in the if condition.

In other words, the above 3 lines should read:
+    if (NOT LIBXSLT_EXSLT_LIBRARIES AND LIBEXSLT_LIBRARIES)
+        set(LIBXSLT_EXSLT_LIBRARIES ${LIBEXSLT_LIBRARIES})
+    endif (NOT LIBXSLT_EXSLT_LIBRARIES AND LIBEXSLT_LIBRARIES)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=316620

--- Comment #3 from nucleo <[hidden email]> ---
htmlexport builds with changes from Comment 2.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=316620

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Sound like we only just wrap this cmake code to IF(APPLE) statements

If this patch is not applied, it don't compile under Macports.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=316620

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|htmlexport don't builds     |htmlexport doesn't build

--- Comment #5 from Kevin Kofler <[hidden email]> ---
No IF(APPLE) needed. Just fix the errors in the patch as per comment #2 and it
will work everywhere.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=316620

--- Comment #6 from nucleo <[hidden email]> ---
Created attachment 78013
  --> https://bugs.kde.org/attachment.cgi?id=78013&action=edit
patch based on comment 2

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=316620

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kipi
                   |                            |-plugins/006b3f415f6636508d
                   |                            |95160b0d22c10da5c32717

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Git commit 006b3f415f6636508d95160b0d22c10da5c32717 by Gilles Caulier.
Committed on 13/03/2013 at 17:09.
Pushed by cgilles into branch 'master'.

apply patch #78013 from Nucleo

M  +3    -3    CMakeLists.txt

http://commits.kde.org/kipi-plugins/006b3f415f6636508d95160b0d22c10da5c32717

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=316620

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=316620

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|htmlexport doesn't build    |html export doesn't build
          Component|general                     |HTMLGallery

--
You are receiving this mail because:
You are the assignee for the bug.