[digikam] [Bug 315574] New: Bad performace when Tag-related Sidebars (Tag management / Filter) are open

[Antonio Larrosa Jimenez]

https://bugs.kde.org/show_bug.cgi?id=315574

Antonio Larrosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #16 from Antonio Larrosa <[hidden email]> ---
I'm using digikam 4.4.0 and noticed this problem too. For me (with over 2300
tags in my database) it took over 40 seconds to regenerate the tag tree view
(and my intention was to reorganize the tags, so it was quite unacceptable to
wait around 40 seconds each time I renamed or deleted a tag).

I looked into the source code and debugged digikam to find that every time I
stopped it, it was inside the icon loader, although most of my tags have the
same icon and in total, I think there are 3 or 4 different icons in use. So I
implemented an icon cache and now I can't even measure how long it takes since
it's instantaneous.

I'm attaching the patch below.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Antonio Larrosa Jimenez]

https://bugs.kde.org/show_bug.cgi?id=315574

--- Comment #17 from Antonio Larrosa <[hidden email]> ---
Created attachment 89100
  --> https://bugs.kde.org/attachment.cgi?id=89100&action=edit
Added an icon cache to AlbumThumbnailLoader to reduce the calls to
iconLoader->loadIcon

QCache uses a default of 100 entries, which I think is enough for most uses

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=315574

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CORE : bad performance when |CORE : bad performance when
                   |Tag-related Sidebars (Tag   |Tag-related Sidebars (Tag
                   |management / Filter) are    |management / Filter) are
                   |open                        |open [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=315574

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.5.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/8f7f1f80e596b5205bd06c2
                   |                            |900e07e05dd23e46b

--- Comment #18 from Gilles Caulier <[hidden email]> ---
Git commit 8f7f1f80e596b5205bd06c2900e07e05dd23e46b by Gilles Caulier.
Committed on 12/10/2014 at 12:49.
Pushed by cgilles into branch 'master'.

Apply patch #89100 from Antonio Larrosa to add Tags thumbnails tags cache for
album tree-view
FIXED-IN: 4.5.0

M  +30   -17   app/album/albumthumbnailloader.cpp
M  +7    -6    app/album/albumthumbnailloader.h

http://commits.kde.org/digikam/8f7f1f80e596b5205bd06c2900e07e05dd23e46b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=315574

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Database                    |Database-Thumbs

--
You are receiving this mail because:
You are the assignee for the bug.