digiKam › digikam-devel

[digikam] [Bug 314952] New: Import window should not lock the interface while reading photos

Classic

List

17 messages Options

Options

DrSlony-4

[digikam] [Bug 314952] New: Import window should not lock the interface while reading photos

https://bugs.kde.org/show_bug.cgi?id=314952

Bug ID: 314952
Summary: Import window should not lock the interface while
reading photos
Classification: Unclassified
Product: digikam
Version: 3.0.0
Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
Severity: wishlist
Priority: NOR
Component: Import
Assignee: [hidden email]
Reporter: [hidden email]

I had to wait 90 seconds before the Import window showed that I have 2052 raw
photos on a 32B memory card. During these 90 seconds I could have configured
the import settings, e.g. worked on the custom file renaming format, but I
couldn't. The 90 seconds were completely non-productive.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

https://bugs.kde.org/show_bug.cgi?id=314952

Teemu Rytilahti <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[hidden email]

--- Comment #1 from Teemu Rytilahti <[hidden email]> ---
Probably related to thumbnail loading, which is related to other downloading
tasks I think. See also #314953.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #2 from Teemu Rytilahti <[hidden email]> ---
*** Bug 314951 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #3 from Teemu Rytilahti <[hidden email]> ---
The duplicate bug entry is related to informing the user about the amount of
photos available, and is thus related to this one.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #4 from Teemu Rytilahti <[hidden email]> ---
*** Bug 314950 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #5 from Teemu Rytilahti <[hidden email]> ---
*** Bug 296649 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

Teemu Rytilahti <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

Teemu Rytilahti <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[hidden email]

--- Comment #6 from Teemu Rytilahti <[hidden email]> ---
*** Bug 283054 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #7 from Teemu Rytilahti <[hidden email]> ---
Git commit 880354561b9ecd2a799def6aa0847cc80dcfa567 by Teemu Rytilahti.
Committed on 29/12/2013 at 16:44.
Pushed by rytilahti into branch 'master'.

Speed-up the UI, first step to fix 314952.
- Fix caching by using QWriteLocks when the cache is being written. We need to
do this, because QCache is not thread-safe.
- Don't request image data from the camera just to get the name of it when
requesting a thumbnail, because we have the list already available after
getting the file list.

M +5 -5 utilities/importui/backend/cameracontroller.cpp
M +1 -0 utilities/importui/main/importui_p.h
M +16 -3 utilities/importui/models/importthumbnailmodel.cpp

http://commits.kde.org/digikam/880354561b9ecd2a799def6aa0847cc80dcfa567

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #8 from Teemu Rytilahti <[hidden email]> ---
Git commit 0c836cb940f4276eaecfbf2995f75d974b794752 by Teemu Rytilahti.
Committed on 29/12/2013 at 23:58.
Pushed by rytilahti into branch 'master'.

Add previewPossible field to CamItemInfo that is used to decide whether the
thumbnail is being queried from the backend.
This speeds up loading of thumbnails as it'll just use the mimetype icon when
the backend says the thumbnails are not supported.
This is especially crucial for gphoto2 backend as it'll otherwise throw a lot
of errors and slows down remarkably. Also probably speeds the UMS backend too
as we don't try to parse the unsupported files.

Note, that CamItemInfo's operators were not changed except the debugging one.

M +3 -0 utilities/importui/backend/camiteminfo.cpp
M +1 -0 utilities/importui/backend/camiteminfo.h
M +5 -0 utilities/importui/backend/gpcamera.cpp
M +7 -1 utilities/importui/backend/umscamera.cpp
M +4 -1 utilities/importui/models/importthumbnailmodel.cpp

http://commits.kde.org/digikam/0c836cb940f4276eaecfbf2995f75d974b794752

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #9 from Teemu Rytilahti <[hidden email]> ---
Those commits I made are relevant to this bug, but the main issue is that
getting the folder listing is blocking and it takes long time (at least with
PTP backend of gphoto2). The next step is to make that incremental and then
this bug should be fixed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

Teemu Rytilahti <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Version Fixed In| |4.0.0
Resolution|--- |FIXED
Latest Commit| |http://commits.kde.org/digi
| |kam/c64fea2e8545d97628c2827
| |52f74082f2d2e7812

--- Comment #10 from Teemu Rytilahti <[hidden email]> ---
Git commit c64fea2e8545d97628c282752f74082f2d2e7812 by Teemu Rytilahti.
Committed on 02/01/2014 at 09:18.
Pushed by rytilahti into branch 'master'.

Don't block the import UI by waiting for a complete folder listing for the
whole device, but build the model gradually.

The new flow goes like this:
1. When a connection to a camera is made, call methods for loading files and
subfolders for the root folder.
2. The backend reports via signal about the subfolders in given folder.
3. Request is being made to download file listing for the returned subfolders,
and then check for their subfolders.
4. Repeat until finished.
FIXED-IN:4.0.0

M +22 -13 utilities/importui/backend/cameracontroller.cpp
M +2 -1 utilities/importui/backend/cameracontroller.h
M +1 -1 utilities/importui/backend/dkcamera.cpp
M +6 -3 utilities/importui/backend/dkcamera.h
M +17 -46 utilities/importui/backend/gpcamera.cpp
M +1 -2 utilities/importui/backend/gpcamera.h
M +37 -38 utilities/importui/backend/umscamera.cpp
M +1 -1 utilities/importui/backend/umscamera.h
M +7 -1 utilities/importui/main/importui.cpp
M +1 -0 utilities/importui/models/importthumbnailmodel.cpp

http://commits.kde.org/digikam/c64fea2e8545d97628c282752f74082f2d2e7812

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Teemu Rytilahti

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

Teemu Rytilahti <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---

--- Comment #11 from Teemu Rytilahti <[hidden email]> ---
Actually let's reopen this. While the commits help as you don't have to wait so
long anymore, the widgets themselves are still disabled while there is
something going on in the background...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[hidden email]

--- Comment #12 from Gilles Caulier <[hidden email]> ---
In next 4.1.0 (current implementation from git/master) i re-introduced a thumb
cache controller for import tool.

This problem still exist using this code ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

--- Comment #13 from Gilles Caulier <[hidden email]> ---
DrSlony,

Do you seen my previous comment ? Can you reproduce this problem using last
digiKam 4.2.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

DrSlony-4

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

DrSlony <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED

--- Comment #14 from DrSlony <[hidden email]> ---
Hello

Tested now in 4.2.0 with just over 1192 raw photos on an SD card. I cannot
reproduce the delay - within a second the Windows fills up and shows me I have
1192 items on the card.

Thank you for fixing it.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 314952] Import window should not lock the interface while reading photos

In reply to this post by DrSlony-4

https://bugs.kde.org/show_bug.cgi?id=314952

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In|4.0.0 |4.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel