[digikam] [Bug 313190] New: Thumbnails of faces not rotated correctly according to the configuration settings

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

            Bug ID: 313190
           Summary: Thumbnails of faces not rotated correctly according to
                    the configuration settings
    Classification: Unclassified
           Product: digikam
           Version: 2.9.0
          Hardware: MS Windows
                OS: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Face Management
          Assignee: [hidden email]
          Reporter: [hidden email]

The setting "Configure DigiKam -> Metadata -> Rotation -> Show image/thumbnails
rotated according to the orientation flag." don't apply to the thumbnails of
faces' people for images only with an orientation flag and pixel data not
changed.

Reproducible: Always

Steps to Reproduce:
For example:

1. Take an image with only an orientation flag: due to the "Configure DigiKam
-> Metadata -> Rotation -> Show image/thumbnails rotated according to the
orientation flag." setting, the image and thumbnails are correctly rotated
(even if the pixel data of the image file are oriented differently);

2. Tag a face.
Actual Results:  
The face thumbnail is oriented as the pixel data file and not as the
orientation flag.

Expected Results:  
As the image and thumbnail, the face's thumbnail must be rotated according to
the orientation flag.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
I dont understand the problem. Do you change the mentioned setting? Which
thumbnails are shown incorrectly where and when?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #2 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Created attachment 76448
  --> https://bugs.kde.org/attachment.cgi?id=76448&action=edit
The original file view

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #3 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Created attachment 76449
  --> https://bugs.kde.org/attachment.cgi?id=76449&action=edit
The original file viewed in digiKam

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #4 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Created attachment 76450
  --> https://bugs.kde.org/attachment.cgi?id=76450&action=edit
The image with orientation tag applied

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #5 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Created attachment 76451
  --> https://bugs.kde.org/attachment.cgi?id=76451&action=edit
The image with orientation tag applied and face area definition

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #6 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Created attachment 76452
  --> https://bugs.kde.org/attachment.cgi?id=76452&action=edit
The bug: the wrong oriented face thumbnail

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #7 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Marcel,

(In reply to comment #1)
> I dont understand the problem. Do you change the mentioned setting?

Yes, the setting is set.

> Which thumbnails are shown incorrectly where and when?

Screenshots:
    1. The original file view (attachment #76448);
    2. The original file viewed in digiKam (attachment #76449);
    3. The image with orientation tag applied  (attachment #76450);
    4. The image with orientation tag applied and face area definition
(attachment #76451);
    5. The bug: the wrong oriented face thumbnail  (attachment #76452).

Jean-Martial

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #8 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Steel  UNCONFIRMED?

Jean-Martial

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=313190

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #9 from Veaceslav Munteanu <[hidden email]> ---
Hello Jean,

Yes I can confirm this bung. In fact digikam doesn't rotate face tags from
database.

I was working on implementing FaceTag write for digikam and came across to the
issue that it doesn't update facetags. Now I have implemented rotation for
images rotated pixel-by-pixel(not by exif flag).

My implementation is still experimental and it's not even in digikam's git.

I'm aware of this one and I will fix this one after stabilizing code that
update tags.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jean-Martial NDOUTOUME NFENGONE]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #10 from Jean-Martial NDOUTOUME NFENGONE <[hidden email]> ---
Hello Veaceslav,

Thanks for your comment.

So, work in progress…

Jean-Martial

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=313190

--- Comment #11 from Marcel Wiesweg <[hidden email]> ---
I can confirm this, it is easily reproducable.
Veaceslav: This is probably not related to your work in the branch, there is no
"new" rotation involved, any image with the rotation flag set by the camera
exhibits this behavior. I suspect an interaction when rotation-by-database was
introduced.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=313190

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |3.2.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/57c3b7249e9b9b1e20c4da1
                   |                            |3d3a013dfda93ddbb

--- Comment #12 from Marcel Wiesweg <[hidden email]> ---
Git commit 57c3b7249e9b9b1e20c4da13d3a013dfda93ddbb by Marcel Wiesweg.
Committed on 18/04/2013 at 22:07.
Pushed by mwiesweg into branch 'master'.

Do not exif-rotate face thumbnails twice.
Clean up an unused parameter in ThumbnailCreator.
FIXED-IN: 3.2.0

M  +2    -1    NEWS
M  +69   -68   libs/threadimageio/thumbnailcreator.cpp
M  +4    -4    libs/threadimageio/thumbnailcreator.h
M  +2    -1    libs/threadimageio/thumbnailloadthread.cpp

http://commits.kde.org/digikam/57c3b7249e9b9b1e20c4da13d3a013dfda93ddbb

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel