digikam 0.9.2 libs/lprof compile error

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

digikam 0.9.2 libs/lprof compile error

Sean McClain
Apparently, lcms (little cms) used to provide a macro called BOOL, and
the digikam source hasn't been patched/updated to reflect the fact
that it doesn't anymore. Since this just generates, well, a bool, I
decided to replace every reference to BOOL in libs/lprof/* with the
macro versions of lcms newer than 1.17 provide, LCMSBOOL. That is to
say,

for library in libs/lprof/*.c libs/lprof/*.cpp; do sed -i $library -e
's/BOOL/LCMS&/g'; done

(if you don't use the above command, don't worry if whatever editor
you use to do the regex replace is case-insensitive; there's only one
occurence of lowercase 'bool', and it's in a comment; I went through
and did all the edits by hand to make sure there were no surprises.
Just change every BOOL to LCMSBOOL)

I did this on another machine I don't have direct access to from this
machine, so unfortunately I don't have a suggested patch. However, it
should be trivial to generate one. In addition, there's no added
concern with BOOL being somehow more generic than LCMS, as there are
other LCMS macros already in place that would have to be replaced
anyway if the digikam maintainers decided to use a different cms.

And I'm happy to say that, as of my writing this, it has compiled and installed.
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users
Reply | Threaded
Open this post in threaded view
|

Re: digikam 0.9.2 libs/lprof compile error

Gilles Caulier-4
0.9.2 is a little bit old.

this problem have been already fixed since a long time :

https://bugs.kde.org/show_bug.cgi?id=148930

Please update to 0.9.6 for KDE3 or 0.10.0 for KDE4

Gilles Caulier

2009/11/2 Sean McClain <[hidden email]>:

> Apparently, lcms (little cms) used to provide a macro called BOOL, and
> the digikam source hasn't been patched/updated to reflect the fact
> that it doesn't anymore. Since this just generates, well, a bool, I
> decided to replace every reference to BOOL in libs/lprof/* with the
> macro versions of lcms newer than 1.17 provide, LCMSBOOL. That is to
> say,
>
> for library in libs/lprof/*.c libs/lprof/*.cpp; do sed -i $library -e
> 's/BOOL/LCMS&/g'; done
>
> (if you don't use the above command, don't worry if whatever editor
> you use to do the regex replace is case-insensitive; there's only one
> occurence of lowercase 'bool', and it's in a comment; I went through
> and did all the edits by hand to make sure there were no surprises.
> Just change every BOOL to LCMSBOOL)
>
> I did this on another machine I don't have direct access to from this
> machine, so unfortunately I don't have a suggested patch. However, it
> should be trivial to generate one. In addition, there's no added
> concern with BOOL being somehow more generic than LCMS, as there are
> other LCMS macros already in place that would have to be replaced
> anyway if the digikam maintainers decided to use a different cms.
>
> And I'm happy to say that, as of my writing this, it has compiled and installed.
> _______________________________________________
> Digikam-users mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-users
>
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users