digiKam 0.9.3 release cycle

[Gerhard Kulzer]

Dear all digiKam fans and users!

The digiKam development team is happy to release 0.9.3-beta1
(http://digikam3rdparty.free.fr/0.9%20releases/digikam-0.9.3-beta1.tar.bz2).
The digiKam tarball can be downloaded from SourceForge as well
(http://sourceforge.net/project/showfiles.php?group_id=42641).

digiKam 0.9.3 will probably be the last release before we will switch over to
KDE4 which will see a totally revamped digiKam.

New features of the camera interface:

 * The camera interface is now used to import new images into collections.
 * There are new options to download pictures and delete them from the camera
   at the same time.
 * Support of Drag & Drop to download files from camera to album window.
 * A progress bar has been added to indicate the available space in the
   Album Library Path

Improvements:

 * Updated internal CImg library to last stable 1.2.3 (released at 2007/08/24)
 * Color scheme theme are now XML based (instead X11 format).

Bug-fixes of KDE BUGZILLA (alias B.K.O | http://bugs.kde.org):

001 ==> 120450 : Strange helper lines behavior in ratio crop tool.
002 ==> 147248 : Image info doesn't follow image in the editor.
003 ==> 147147 : digiKam does not apply tags to some selected images.
004 ==> 143200 : Mass renaming with F2 crashes digiKam.
005 ==> 147347 : Showfoto crashes when opening twice multiple files.
006 ==> 147269 : digiKam finds but fails to use libkdcraw.
007 ==> 147263 : Some icons are missing.
008 ==> 146636 : Adjust levels plugin: helper line for sliders.
009 ==> 147671 : Portability problem in configure script.
010 ==> 147670 : Compilation problems on NetBSD in greycstoration.
011 ==> 147362 : Tool-tip for zoom indicator is below the screen if window is
maximized.
012 ==> 145017 : Deleting an image from within digiKam does not update the
digiKam database.
013 ==> 148925 : Light Table thumb bar not updated when deleting images.
014 ==> 148971 : run-on menu entry "digiKamThemeDesigner".
015 ==> 148930 : digiKam-0.9.2 does not compile with lcms-1.17.
016 ==> 141774 : Auto-rotate does not work however KIPI rotation works.
017 ==> 103350 : Original image is silently overwritten when saving.
018 ==> 144431 : Add option in Camera Download Dialog.
019 ==> 131407 : Use camera GUI also for import of images from different
locations.
020 ==> 143934 : Cannot download all photos from camera.
021 ==> 147119 : Can't link against static libjasper, configure reports jasper
is missing.
022 ==> 147439 : It is too easy to delete a search.
023 ==> 147687 : Error when downloading and converting images.
024 ==> 137590 : Be able to modify the extension of images in the interface.
025 ==> 139024 : Camera GUI new items selection doesn't work.
026 ==> 139519 : digiKam silently fails to import when out of disc space.
027 ==> 149469 : Excessive trash confirmation dialogs after album is deleted.
028 ==> 148648 : Color managed previews not working in all plugins.
029 ==> 126427 : In "rename file" dialog, the 2nd picture is (and can't) not
be displayed.
030 ==> 144336 : Selecting pictures on the camera makes scroll-bar jump back
to the top of the list.
031 ==> 136927 : Failed to download file DCP_4321.jpg. Do you want to
continue? and when continue is clicked the same warning comes on for the next
image and so on.
032 ==> 146083 : Bugs in drag and drop.
033 ==> 147854 : Put images into an emptied light-table.
034 ==> 149578 : libjpeg JPEG sub-sampling setting is not user-controllable.
035 ==> 149685 : Go to next photo after current photo deletion (vs. to
previous photo).
036 ==> 148233 : Adding texture generates black image.
037 ==> 147311 : Light Table RAW images does not rotate as def. by EXIF info.
038 ==> 146773 : Metadata sources preference when sorting images.
039 ==> 140133 : Metadata Edit Picture Comments Syncs to IPTC and EXIF when
option is de-selected .
040 ==> ML : Lost toolbar after building from svn

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Finale date? How much time I have to update translations?

m.

----------------------------------------------------
ATRAKCYJNE NIERUCHOMOŚCI W ZAKOPANEM !!!
Apartamenty, Domy, Działki, Pensjonaty, Hotele, Lokale użytkowe...
Kliknij: http://klik.wp.pl/?adr=www.bachledanieruchomosci.pl&sid=54


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Mik,

There are at least 2 patches to apply on svn from Arnd. This can be done for beta2.
Strings freeze can be done too at beta2

release plan proposal :

- 0.9.3-beta1 15/10 (done)
- 0.9.3-beta2 22/10 (i18n frozen)
- 0.9.3-rc 5/11 (release candidate if necessary)
- 0.9.3 12/11

About a possible 0.9.4, this depand of :

- progress and finalization of digiKam 0.10.0 for KDE4. Originally this is planed for Christmas to be sync with KDE4 release date.
- possible delay of KDE4 env. I think than release plan will be delayed There are to much part from KDE4libs witch have been changed. A lots of bugs reports will be done after kde4libs release (witch is planed before KDE4 env release - November if i remember)
- bug report on digiKam for KDE3

To resume, i'm favorable to a 0.9.4 release. KDE4 will not be published immediately by default around the world. KDE3 will still the default env for a long time (6 ~ 9 month i think).

But of course i'm not alone to decide. Comments are welcome...

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Gilles Caulier wrote:

> About a possible 0.9.4, this depand of :
>
> - progress and finalization of digiKam 0.10.0 for KDE4. Originally this
> is planed for Christmas to be sync with KDE4 release date.
> - possible delay of KDE4 env. I think than release plan will be delayed
> There are to much part from KDE4libs witch have been changed. A lots of
> bugs reports will be done after kde4libs release (witch is planed before
> KDE4 env release - November if i remember)
> - bug report on digiKam for KDE3
>
> To resume, i'm favorable to a 0.9.4 release. KDE4 will not be published
> immediately by default around the world. KDE3 will still the default env
> for a long time (6 ~ 9 month i think).

Great !

> But of course i'm not alone to decide. Comments are welcome...

I agree :)

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

Am Tuesday 09 October 2007 schrieb Gilles Caulier:
> To resume, i'm favorable to a 0.9.4 release. KDE4 will not be published
> immediately by default around the world. KDE3 will still the default env
> for a long time (6 ~ 9 month i think).

It all depends on the avaiablility of KDE4 at least in the "unstable" type of
distros. My feeling is also that 0.9.4 will see the light of its old days.

Gerhard


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

There are a couple of bugs with patches, which could go
into the next beta, after review:

- "Search for non-voted pics"
  http://bugs.kde.org/show_bug.cgi?id=147426
  Marcel, could you have a look at the patch?

- "easier navigation between albums, tags and collections"
  http://bugs.kde.org/show_bug.cgi?id=96894
  Mikolaj has checked the patch.
  There seems to be a small glitch with complex searches,
  which I haven't be able to track down.
  Overall it seems that the opinion was to apply this
  patch anyway. (Still Gilles might see the problem quickly ;-),
  see comment #25)

- I am not sure about this bug with attached patch
  http://bugs.kde.org/show_bug.cgi?id=147429
  Either this bug will be marked as invalid, or the patch
  might solve the issue.
  Gerhard, what do you think about comment #6 ?

- scroll left-pane to the selected album/date on start-up
  http://bugs.kde.org/show_bug.cgi?id=144815
  I think that this patch could be applied, after review.
  (Saving the image item and such as discussed in coment #5
   can be done separately - I will have a look next week ...)

Some more issues, which might be "easy" to solve for a
data-base/search expert:
- "Wish: Search including sub-albums"
  http://bugs.kde.org/show_bug.cgi?id=149026
- "Search using Tag Name does not work"
  http://bugs.kde.org/show_bug.cgi?id=141037
Marcel, what do you think about these two?

Well, that's all which comes to my mind now ;-).

Best, Arnd

P.S.: What about a bug-squashing week-end?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia wtorek 09 październik 2007, Gilles Caulier napisał:
>
> But of course i'm not alone to decide. Comments are welcome...

11.12 - AFAIR official tagging of KDE 4.0 and  release few days later
Beginning of January - PR fest in Google HQ. That will give KDE4 much
publicity. It would be good  if digiKam 0.10 would be ready for that.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/10/9, Mikolaj Machowski <[hidden email]>:

Dnia wtorek 09 październik 2007, Gilles Caulier napisał:
>
> But of course i'm not alone to decide. Comments are welcome...

11.12 - AFAIR official tagging of KDE 4.0 and  release few days later
Beginning of January - PR fest in Google HQ. That will give KDE4 much
publicity. It would be good  if digiKam 0.10 would be ready for that.

you is really optimist (:=)))...

We will try to give a suitable digiKam 0.10.0 at this date... But nothing is sure.

Marcel, we can do certainly a beta release, but i'm not sure about a final release
 

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia wtorek 09 październik 2007, Gilles Caulier napisał:

> 2007/10/9, Mikolaj Machowski <[hidden email]>:
> > Dnia wtorek 09 październik 2007, Gilles Caulier napisał:
> > > But of course i'm not alone to decide. Comments are welcome...
> >
> > 11.12 - AFAIR official tagging of KDE 4.0 and  release few days later
> > Beginning of January - PR fest in Google HQ. That will give KDE4 much
> > publicity. It would be good  if digiKam 0.10 would be ready for that.
>
> you is really optimist (:=)))...
>
> We will try to give a suitable digiKam 0.10.0 at this date... But
> nothing is sure.

Second date is beginning of February when spring round of distro
releases will be freezed.

Third date is after those spring releases are, well, released, April or
somewhat.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer-3]

Am Tuesday 09 October 2007 schrieb Gilles Caulier:

> Mik,
>
> There are at least 2 patches to apply on svn from Arnd. This can be done
> for beta2.
> Strings freeze can be done too at beta2
>
> release plan proposal :
>
> - 0.9.3-beta1 15/10 (done)
> - 0.9.3-beta2 22/10 (i18n frozen)
> - 0.9.3-rc 5/11 (release candidate if necessary)
> - 0.9.3 12/11
>
> About a possible 0.9.4, this depand of :
>
> - progress and finalization of digiKam 0.10.0 for KDE4. Originally this is
> planed for Christmas to be sync with KDE4 release date.
> - possible delay of KDE4 env. I think than release plan will be delayed
> There are to much part from KDE4libs witch have been changed. A lots of
> bugs reports will be done after kde4libs release (witch is planed before
> KDE4 env release - November if i remember)
> - bug report on digiKam for KDE3
>
> To resume, i'm favorable to a 0.9.4 release. KDE4 will not be published
> immediately by default around the world. KDE3 will still the default env
> for a long time (6 ~ 9 month i think).
>
> But of course i'm not alone to decide. Comments are welcome...
>
> Gilles

Hi Gilles,
I'm back at my desk.
Except for the German po compile problem there was no negative feedback on
beta1. Now, since you put the great filters into place, I think it would be
time to do a string freeze and issue beta2.
What's your opinion?

Gerhard

--
><((((º> ¸.·´¯`·... ><((((º> ¸.·´¯`·...¸ ><((((º>
http://www.gerhard.fr

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/10/28, Gerhard Kulzer <[hidden email]>:

Am Tuesday 09 October 2007 schrieb Gilles Caulier:
> Mik,
>
> There are at least 2 patches to apply on svn from Arnd. This can be done
> for beta2.
> Strings freeze can be done too at beta2
>

> release plan proposal :
>
> - 0.9.3-beta1 15/10 (done)
> - 0.9.3-beta2 22/10 (i18n frozen)
> - 0.9.3-rc 5/11 (release candidate if necessary)
> - 0.9.3 12/11
>
> About a possible 0.9.4, this depand of :
>
> - progress and finalization of digiKam 0.10.0 for KDE4. Originally this is
> planed for Christmas to be sync with KDE4 release date.
> - possible delay of KDE4 env. I think than release plan will be delayed
> There are to much part from KDE4libs witch have been changed. A lots of
> bugs reports will be done after kde4libs release (witch is planed before
> KDE4 env release - November if i remember)
> - bug report on digiKam for KDE3
>
> To resume, i'm favorable to a 0.9.4 release. KDE4 will not be published
> immediately by default around the world. KDE3 will still the default env
> for a long time (6 ~ 9 month i think).

>
> But of course i'm not alone to decide. Comments are welcome...
>
> Gilles

Hi Gilles,
I'm back at my desk.
Except for the German po compile problem there was no negative feedback on
beta1. Now, since you put the great filters into place, I think it would be
time to do a string freeze and issue beta2.
What's your opinion?

Gerhard

Agree for me.

Arnd, there are few patches from you in queue to apply on svn. With one change something in i18n strings ? If i18n is frozen now, only undependant i18n patches can be apply to svn until final release. Fine for you ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

Hi,

On Sun, 28 Oct 2007, Gilles Caulier wrote:
[...]
> 2007/10/28, Gerhard Kulzer <[hidden email]>:
[...]

> > I'm back at my desk.
> > Except for the German po compile problem there was no negative feedback on
> > beta1. Now, since you put the great filters into place, I think it would
> > be
> > time to do a string freeze and issue beta2.
> > What's your opinion?
> >
> > Gerhard
> >
> > Agree for me.
>
> Arnd, there are few patches from you in queue to apply on svn. With one
> change something in i18n strings ? If i18n is frozen now, only undependant
> i18n patches can be apply to svn until final release. Fine for you ?

The list of bugs with patches, which are not yet applied are
- search for non-voted pics
  http://bugs.kde.org/show_bug.cgi?id=147426
  (does not involve i18n strings)

- rights issue:
  http://bugs.kde.org/show_bug.cgi?id=145252
 (does not involve i18n strings)

- goto patch (essentially done ..)
  http://bugs.kde.org/show_bug.cgi?id=96894
  This *does* involve i18n strings.
  For this reason, and because it is one of the really
  higher rated wishes (>100 !) I would be very happy if it
  could get integrated into 0.9.3.
  There are also a couple of other bugs/wishes, which could
  be addressed if this is applied ...

- goto position on the LHS
   http://bugs.kde.org/show_bug.cgi?id=144815
  (does not involve i18n strings)

So from my point of view, it would be nice if all the patches
could make it into 0.9.3, but most importantly the goto patch ;-).
Then there are also the patches by Guillaume Castagnino
(can't find the BKO entry right now), and maybe some others...?

Generally I would encourage that patches get a
faster review/apply procedure:
- if too much time passes, the patches don't apply anymore
- if too much time passes, the patch author usually
  will have forgotten about the details, and in case of
  questions it may be difficult to answer them ...
- quick review/apply can be very motivating for further contributions.
(Don't get me wrong: I am not blaming anyone, no bad feelings or so,
and perfectly understand why things are as they are,
just my 2cents ...)

Best wishes,

Arnd

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/10/9, Arnd Baecker <[hidden email]>:

There are a couple of bugs with patches, which could go
into the next beta, after review:

- "Search for non-voted pics"
  http://bugs.kde.org/show_bug.cgi?id=147426
  Marcel, could you have a look at the patch?

- "easier navigation between albums, tags and collections"
  http://bugs.kde.org/show_bug.cgi?id=96894
  Mikolaj has checked the patch.
  There seems to be a small glitch with complex searches,
  which I haven't be able to track down.
  Overall it seems that the opinion was to apply this
  patch anyway. (Still Gilles might see the problem quickly ;-),
  see comment #25)

- I am not sure about this bug with attached patch
  http://bugs.kde.org/show_bug.cgi?id=147429
  Either this bug will be marked as invalid, or the patch
  might solve the issue.
  Gerhard, what do you think about comment #6 ?

- scroll left-pane to the selected album/date on start-up
  http://bugs.kde.org/show_bug.cgi?id=144815
  I think that this patch could be applied, after review.
  (Saving the image item and such as discussed in coment #5
   can be done separately - I will have a look next week ...)

Some more issues, which might be "easy" to solve for a
data-base/search expert:
- "Wish: Search including sub-albums"
  http://bugs.kde.org/show_bug.cgi?id=149026
- "Search using Tag Name does not work"
  http://bugs.kde.org/show_bug.cgi?id=141037
Marcel, what do you think about these two?

Well, that's all which comes to my mind now ;-).

Best, Arnd

P.S.: What about a bug-squashing week-end?

Why not... but I'm currently available monday and tuesday all the days. It's hollidays time for me during one week.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Mik,

We will take time to release 0.9.3. There is no urgent delay to respect. I think than a final release date around december is fine.

And before, we need beta2, beta3 and rc to be sure than all work fine. I want a very polished release for christmas (:=)))

Gilles

2007/10/9, Mikołaj Machowski <[hidden email]>:

Finale date? How much time I have to update translations?

m.

----------------------------------------------------
ATRAKCYJNE NIERUCHOMOŚCI W ZAKOPANEM !!!
Apartamenty, Domy, Działki, Pensjonaty, Hotele, Lokale użytkowe...
Kliknij: http://klik.wp.pl/?adr=www.bachledanieruchomosci.pl&sid=54


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/10/9, Arnd Baecker <[hidden email]>:

There are a couple of bugs with patches, which could go
into the next beta, after review:

- "Search for non-voted pics"
  http://bugs.kde.org/show_bug.cgi?id=147426
  Marcel, could you have a look at the patch?

Marcel,

I have review this patch for KDE3 and it sound fine for me...

but Rating information place have changed in DB for KDE4, and this patch must be adapted.Can you take a look ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

- "easier navigation between albums, tags and collections"
   http://bugs.kde.org/show_bug.cgi?id=96894
  Mikolaj has checked the patch.
  There seems to be a small glitch with complex searches,
  which I haven't be able to track down.
  Overall it seems that the opinion was to apply this
  patch anyway. (Still Gilles might see the problem quickly ;-),
  see comment #25)

This is the big one. I will take a look...

- I am not sure about this bug with attached patch
  http://bugs.kde.org/show_bug.cgi?id=147429
  Either this bug will be marked as invalid, or the patch
  might solve the issue.
  Gerhard, what do you think about comment #6 ?

Gerhard ?
 

- scroll left-pane to the selected album/date on start-up
  http://bugs.kde.org/show_bug.cgi?id=144815
  I think that this patch could be applied, after review.
  (Saving the image item and such as discussed in coment #5
   can be done separately - I will have a look next week ...)

This one is fine for me Arnd, Let's go to apply it on svn...

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/10/9, Arnd Baecker <[hidden email]>:

There are a couple of bugs with patches, which could go
into the next beta, after review:

- "Search for non-voted pics"
  http://bugs.kde.org/show_bug.cgi?id=147426
  Marcel, could you have a look at the patch?

- "easier navigation between albums, tags and collections"
  http://bugs.kde.org/show_bug.cgi?id=96894
  Mikolaj has checked the patch.
  There seems to be a small glitch with complex searches,
  which I haven't be able to track down.
  Overall it seems that the opinion was to apply this
  patch anyway. (Still Gilles might see the problem quickly ;-),
  see comment #25)

Arnd,

Trying to apply to patch agaonst current KDE3 svn failed :

[gilles@localhost digikam]$ patch -p0 < 96894.patch
patching file digikam/digikamview.cpp
patching file digikam/datefolderview.cpp
patching file digikam/album.cpp
patching file digikam/albumiconview.cpp
Hunk #1 FAILED at 79.
Hunk #2 succeeded at 171 (offset 1 line).
Hunk #3 succeeded at 347 (offset 1 line).
Hunk #4 succeeded at 409 (offset 1 line).
Hunk #5 succeeded at 560 (offset 1 line).
Hunk #6 succeeded at 689 (offset 5 lines).
Hunk #7 succeeded at 710 (offset 5 lines).
Hunk #8 succeeded at 770 (offset 5 lines).
Hunk #9 succeeded at 2075 (offset 5 lines).
1 out of 9 hunks FAILED -- saving rejects to file digikam/albumiconview.cpp.rej
patching file digikam/tagfolderview.h
patching file digikam/iconview.h
patching file digikam/iconview.cpp
patching file digikam/albumfolderview.h
patching file digikam/albumfolderview.cpp
patching file digikam/digikamview.h
patching file digikam/datefolderview.h
patching file digikam/albumiconview.h

Can you regenerate it please ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > There are a couple of bugs with patches, which could go
> > into the next beta, after review:
> >
> > - "Search for non-voted pics"
> >   http://bugs.kde.org/show_bug.cgi?id=147426
> >   Marcel, could you have a look at the patch?
>
> Marcel,
>
> I have review this patch for KDE3 and it sound fine for me...
>
> but Rating information place have changed in DB for KDE4, and this patch
> must be adapted.Can you take a look ?

The rating has now a real place in db, this means that every image is
initialized with whatever DMetadata::getImageRating returns, which is -1 when
no information is found.
Currently in the UI a rating of 0 is treated like a rating of -1, and maybe
this is right so. (a matter of definition)
So in 0.10, searching for "no rating" would mean searching for -1 and/or 0.


>
> Gilles


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Hi,

Arnd Baecker wrote:

>> Arnd, there are few patches from you in queue to apply on svn. With one
>> change something in i18n strings ? If i18n is frozen now, only undependant
>> i18n patches can be apply to svn until final release. Fine for you ?
>
> The list of bugs with patches, which are not yet applied are
> - search for non-voted pics
>   http://bugs.kde.org/show_bug.cgi?id=147426
>   (does not involve i18n strings)
>
> - rights issue:
>   http://bugs.kde.org/show_bug.cgi?id=145252
>  (does not involve i18n strings)
>
> - goto patch (essentially done ..)
>   http://bugs.kde.org/show_bug.cgi?id=96894
>   This *does* involve i18n strings.
>   For this reason, and because it is one of the really
>   higher rated wishes (>100 !) I would be very happy if it
>   could get integrated into 0.9.3.
>   There are also a couple of other bugs/wishes, which could
>   be addressed if this is applied ...
>
> - goto position on the LHS
>    http://bugs.kde.org/show_bug.cgi?id=144815
>   (does not involve i18n strings)
>

Note, there's also the one about the lighttable :
http://bugs.kde.org/show_bug.cgi?id=150296

For me, it looks good :)

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

On Tue, 30 Oct 2007, Marcel Wiesweg wrote:

> > > There are a couple of bugs with patches, which could go
> > > into the next beta, after review:
> > >
> > > - "Search for non-voted pics"
> > >   http://bugs.kde.org/show_bug.cgi?id=147426
> > >   Marcel, could you have a look at the patch?
> >
> > Marcel,
> >
> > I have review this patch for KDE3 and it sound fine for me...
> >
> > but Rating information place have changed in DB for KDE4, and this patch
> > must be adapted.Can you take a look ?
>
> The rating has now a real place in db, this means that every image is
> initialized with whatever DMetadata::getImageRating returns, which is -1 when
> no information is found.
> Currently in the UI a rating of 0 is treated like a rating of -1, and maybe
> this is right so. (a matter of definition)
> So in 0.10, searching for "no rating" would mean searching for -1 and/or 0.

Sor for the patch at
http://bugs.kde.org/show_bug.cgi?id=147426
the logic to be considered for 0.10  are the cases:

a) For val = 0:
   i)   >= 0  corresponds to search for >=-1
        I.e, choose:  val = -1, op = GTE
   ii)  == 0  corresponds to search for ==0 or == -1
        I.e, choose: val = 0, op = LTE
   iii) <= 0  corresponds to search for ==0 or == -1
        i.E. choose val = 0, op = LTE
b) For val >0:
   <  val
   <= val
   != val
So case b) does not need any special treatment anymore
as -1 < 0 ;-).

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel