code cleanup

[Jens Müller-10]

Hi all,

histogrambox and curvesbox use enum type 'HistogramScale' for get and set
methods (defined in globals.h), but use int for get and set methods for
channeltype as there is also a enum type 'ChannelType' also defined in
globals.h. I want to make channeltype type-safe (use ChannelType enum) and
have therefore to touch a dozen of files. Are there any objections against?

Another thing: there a lot of '#if KDCRAW_VERSION < 0x000400' define switches
across the code, but according for README only libkdcraw >= 0.4.0 is
supported. What about this?

Regards, Jens
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Am 02.02.2010 20:29 schrieb Jens Müller:
> histogrambox and curvesbox use enum type 'HistogramScale' for get and set
> methods (defined in globals.h), but use int for get and set methods for
> channeltype as there is also a enum type 'ChannelType' also defined in
> globals.h. I want to make channeltype type-safe (use ChannelType enum) and
> have therefore to touch a dozen of files. Are there any objections against?

I also notice this some time ago and tried to fix it but gave up after
so many places that needed a change. But I would definitiley say that
this is is the right way.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Hi all,
>
> histogrambox and curvesbox use enum type 'HistogramScale' for get and set
> methods (defined in globals.h), but use int for get and set methods for
> channeltype as there is also a enum type 'ChannelType' also defined in
> globals.h. I want to make channeltype type-safe (use ChannelType enum) and
> have therefore to touch a dozen of files. Are there any objections against?

Fine for me.

>
> Another thing: there a lot of '#if KDCRAW_VERSION < 0x000400' define
>  switches across the code, but according for README only libkdcraw >= 0.4.0
>  is supported. What about this?

0.4.0 was released with KDE SC 4.2. I think it's ok to remove support for 0.3
and later.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel