bug 179209:proposed patch

[Saurabh Patel]

Hello,

  I submitted a patch for bug at foll. link:https://bugs.kde.org/show_bug.cgi?id=179209

Plz review it.

Also is it right way to submit a patch or there is some other by which it is to be done

Thanks

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

to propose a patch in a bugzilla entry is fine for me.

There is also KDE reviewboard, but personaltly it's increase complexity to manage bug report. Instead to have one tool to control, we have two one... As time is limited to switch from one to another one, and as bugzilla is the most important tool to handle, there is no need to create a entry in RB if a bugzilla entry already exist.

The only advantage of reviewboard is for patch where no bugzilla entry exist yet..

About your patch, you drop the properties of album checked to see if it's in collection or not. With certain KIPI host it will work, for some other no...

Also, BatchProcessImages tools, are progressively replaced by BQM in digiKam. In the future, this plugin will be dropped.

In fact, you will see that a similar entry already exist to BQM (:=))). If something must be do, it's in BQM, not in kipi tool.

https://bugs.kde.org/show_bug.cgi?id=196894

Gilles Caulier

2013/4/2 Saurabh Patel <[hidden email]>

Hello,

  I submitted a patch for bug at foll. link:https://bugs.kde.org/show_bug.cgi?id=179209

Plz review it.

Also is it right way to submit a patch or there is some other by which it is to be done

Thanks

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel