SVN commit 845390 by cgilles:
Raw Import tool : - Separate preview and settings implementation from dialog. In fact the dialog will deseapear and editor will support a widget stack mechanism to display canvas view or tool preview. This will include all image plugins (but it's not yet done.)! Note than the settings will be hosted by a new right sidebar tab which will be visible only when the tool running. This moc-up is similar than Risto paper. I'm sure than Mik will be very impatient to test it (:=))) -Add Lineary adjustmant using curve widget (as UFRAW). Still Color management improvements to do to complete RAW Import tool. Please, let's me more free time... CCMAIL: [hidden email] M +2 -1 Makefile.am M +63 -440 rawimportdlg.cpp M +7 -2 rawimportdlg.h M +24 -31 rawpreview.cpp M +3 -4 rawpreview.h AM rawsettingsbox.cpp [License: GPL (v2+)] AM rawsettingsbox.h [License: GPL (v2+)] _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Dnia Monday 11 of August 2008, Gilles Caulier napisał:
> SVN commit 845390 by cgilles: > > Raw Import tool : > - Separate preview and settings implementation from dialog. In fact the > dialog will deseapear and editor will support a widget stack mechanism > to display canvas view or tool preview. This will include all image > plugins (but it's not yet done.)! As I am writing this it looks like it is almost done. There are rough edges but will not comment on that because don't know if this is on "commentable" level or not. > Note than the settings will be hosted > by a new right sidebar tab which will be visible only when the tool > running. This moc-up is similar than Risto paper. I'm sure than Mik will > be very impatient to test it (:=))) :) > -Add Lineary adjustmant using curve widget (as UFRAW). Doesn't work :( (svn 845503) Widget is there, I can play with curve but without effects. > Please, let's me more free time... Sure, take your time :) You are doing excellent work. Since RAW import dialog itself is almost complete I will allow myself for some remarks ;) - not clear way for zoom. Ctrl-MouseWheel works but definitely not enough - especially no way to set 1:1 zoom factor - cannot abandon action and return to Album view, have to import with default settings and close editor window to return there; should be Cancel action which will return user directly to main window - most RAW import tools I know use E.V. for exposure correction - 99% of users will expect that somewhere - some way to save settings and use those profiles to import other photos? - even when imported with 16-bit checkbox unchecked Properties in image editor shows that image as 48 bpp - but when saved as tiff (without any other settings changed) this is regular 24 bpp image. I understand this is because in IE this is still 48 bpp RAW image it will be only later exported with 24 bpp depth - but this is misleading. - I have FujiCCD - when I select 'don't stretch or rotate pixels' preview is OK (rotated 45 degrees), but imported is rotated image. m. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
2008/8/11 Mikolaj Machowski <[hidden email]>:
> Dnia Monday 11 of August 2008, Gilles Caulier napisał: >> SVN commit 845390 by cgilles: >> >> Raw Import tool : >> - Separate preview and settings implementation from dialog. In fact the >> dialog will deseapear and editor will support a widget stack mechanism >> to display canvas view or tool preview. This will include all image >> plugins (but it's not yet done.)! > > As I am writing this it looks like it is almost done. There are rough > edges but will not comment on that because don't know if this is on > "commentable" level or not. > >> Note than the settings will be hosted >> by a new right sidebar tab which will be visible only when the tool >> running. This moc-up is similar than Risto paper. I'm sure than Mik will >> be very impatient to test it (:=))) > > :) > >> -Add Lineary adjustmant using curve widget (as UFRAW). > > Doesn't work :( (svn 845503) > Widget is there, I can play with curve but without effects. It take effect to press on preview for the moment. > >> Please, let's me more free time... > > Sure, take your time :) You are doing excellent work. > > Since RAW import dialog itself is almost complete I will allow myself > for some remarks ;) > > - not clear way for zoom. Ctrl-MouseWheel works but definitely not > enough - especially no way to set 1:1 zoom factor yes zoom/pan button are missing. When dialog will be removed, the editor zooming buttons from toolbar will be used for that. > - cannot abandon action and return to Album view, have to import with > default settings and close editor window to return there; should be > Cancel action which will return user directly to main window yes. same problem here. when dialog will be removed, you just need to close editore. that all. > - most RAW import tools I know use E.V. for exposure correction - 99% of > users will expect that somewhere well the unit is EV in current exposure settings. What that you need exactly ? > - some way to save settings and use those profiles to import other > photos? Ah. yes. it's in my todo list, but in the future with KDE4 only, because i will use DB for that. In KDE3, RAW import remember settings between sessions. > - even when imported with 16-bit checkbox unchecked Properties in image > editor shows that image as 48 bpp - but when saved as tiff (without > any other settings changed) this is regular 24 bpp image. I understand > this is because in IE this is still 48 bpp RAW image it will be only > later exported with 24 bpp depth - but this is misleading. No it's abnormal. i will try to reproduce here. > - I have FujiCCD - when I select 'don't stretch or rotate pixels' > preview is OK (rotated 45 degrees), but imported is rotated image. It's another problem. i will try to check it too... If you can, please send me in private a RAW sample from you Fuji camera. I have only one Fuji sample in my RAW repository. Thanks for this report. Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
2008/8/11 Mikolaj Machowski <[hidden email]>:
> Dnia Monday 11 of August 2008, Gilles Caulier napisał: >> SVN commit 845390 by cgilles: >> >> Raw Import tool : >> - Separate preview and settings implementation from dialog. In fact the >> dialog will deseapear and editor will support a widget stack mechanism >> to display canvas view or tool preview. This will include all image >> plugins (but it's not yet done.)! > > As I am writing this it looks like it is almost done. There are rough > edges but will not comment on that because don't know if this is on > "commentable" level or not. > >> Note than the settings will be hosted >> by a new right sidebar tab which will be visible only when the tool >> running. This moc-up is similar than Risto paper. I'm sure than Mik will >> be very impatient to test it (:=))) > > :) > >> -Add Lineary adjustmant using curve widget (as UFRAW). > > Doesn't work :( (svn 845503) > Widget is there, I can play with curve but without effects. > >> Please, let's me more free time... > > Sure, take your time :) You are doing excellent work. > > Since RAW import dialog itself is almost complete I will allow myself > for some remarks ;) > > - not clear way for zoom. Ctrl-MouseWheel works but definitely not > enough - especially no way to set 1:1 zoom factor > - cannot abandon action and return to Album view, have to import with > default settings and close editor window to return there; should be > Cancel action which will return user directly to main window > - most RAW import tools I know use E.V. for exposure correction - 99% of > users will expect that somewhere > - some way to save settings and use those profiles to import other > photos? > - even when imported with 16-bit checkbox unchecked Properties in image > editor shows that image as 48 bpp - but when saved as tiff (without > any other settings changed) this is regular 24 bpp image. I understand > this is because in IE this is still 48 bpp RAW image it will be only > later exported with 24 bpp depth - but this is misleading. It's not reproductible here. I have loaded a DNG raw file in editor using RAW import with 16 bits color depth, and saved it to tiff as well. Target file use the right color depth. Look my screenshot : http://digikam3rdparty.free.fr/Screenshots/temp/raw2tiff16bits.png Best Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Dnia Tuesday 12 of August 2008, Gilles Caulier napisał:
> > - even when imported with 16-bit checkbox unchecked Properties in > > image editor shows that image as 48 bpp - but when saved as tiff > > (without any other settings changed) this is regular 24 bpp image. I > > understand this is because in IE this is still 48 bpp RAW image it > > will be only later exported with 24 bpp depth - but this is > > misleading. > > It's not reproductible here. I have loaded a DNG raw file in editor > using RAW import with 16 bits color depth, and saved it to tiff as > well. Target file use the right color depth. Look my screenshot : > > http://digikam3rdparty.free.fr/Screenshots/temp/raw2tiff16bits.png For 16-bits its working for me too. Did you try with 8-bit import? m. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier-4
Dnia Tuesday 12 of August 2008, Gilles Caulier napisał:
> >> -Add Lineary adjustmant using curve widget (as UFRAW). > > > > Doesn't work :( (svn 845503) > > Widget is there, I can play with curve but without effects. > > It take effect to press on preview for the moment. Doesn't work for me. > > - most RAW import tools I know use E.V. for exposure correction - 99% > > of users will expect that somewhere > > well the unit is EV in current exposure settings. What that you need > exactly ? Where is it noted? I see Exposure Exposure with -0.50 +0.50 range Somewhere in White Balance? BTW I think layout of White Balance in RAW import and White Balance as plugin should be more similar. m. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier-4
Dnia Tuesday 12 of August 2008, Gilles Caulier napisał:
> If you can, please send me in private a RAW sample from you Fuji > camera. I have only one Fuji sample in my RAW repository. Do you know this site: http://raw.fotosite.pl/ m. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
2008/8/12 Mikolaj Machowski <[hidden email]>:
> Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: >> >> -Add Lineary adjustmant using curve widget (as UFRAW). >> > >> > Doesn't work :( (svn 845503) >> > Widget is there, I can play with curve but without effects. >> >> It take effect to press on preview for the moment. > > Doesn't work for me. > Hum. I have simplified image loading with commit #846035. checkout and try again >> > - most RAW import tools I know use E.V. for exposure correction - 99% >> > of users will expect that somewhere >> >> well the unit is EV in current exposure settings. What that you need >> exactly ? > > Where is it noted? I see Exposure Exposure with -0.50 +0.50 range Shift+F1 over the slider... > > Somewhere in White Balance? BTW I think layout of White Balance in RAW > import and White Balance as plugin should be more similar. yes, i will improve it again Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
2008/8/12 Mikolaj Machowski <[hidden email]>:
> Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: >> If you can, please send me in private a RAW sample from you Fuji >> camera. I have only one Fuji sample in my RAW repository. > > Do you know this site: > > http://raw.fotosite.pl/ Very interresting. Thanks for the link Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier-4
Dnia Tuesday 12 of August 2008, Gilles Caulier napisał:
> 2008/8/12 Mikolaj Machowski <[hidden email]>: > > Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: > >> >> -Add Lineary adjustmant using curve widget (as UFRAW). > >> > > >> > Doesn't work :( (svn 845503) > >> > Widget is there, I can play with curve but without effects. > >> > >> It take effect to press on preview for the moment. > > > > Doesn't work for me. > > Hum. I have simplified image loading with commit #846035. checkout and > try again attached image. > >> > - most RAW import tools I know use E.V. for exposure correction - > >> > 99% of users will expect that somewhere > >> > >> well the unit is EV in current exposure settings. What that you need > >> exactly ? > > > > Where is it noted? I see Exposure Exposure with -0.50 +0.50 range > > Shift+F1 over the slider... OK - but why only -0.5 +0.5 range? I would expect more like -3 +3 range for fixing of badly broken images. m. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel crvs.jpg (23K) Download Attachment |
2008/8/13 Mikolaj Machowski <[hidden email]>:
> Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: >> 2008/8/12 Mikolaj Machowski <[hidden email]>: >> > Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: >> >> >> -Add Lineary adjustmant using curve widget (as UFRAW). >> >> > >> >> > Doesn't work :( (svn 845503) >> >> > Widget is there, I can play with curve but without effects. >> >> >> >> It take effect to press on preview for the moment. >> > >> > Doesn't work for me. >> >> Hum. I have simplified image loading with commit #846035. checkout and >> try again > > Well, now it takes effect but widget is completely broken. See > attached image. Sound like your curves saved in rc file beween session is broken somewhere. Press curve reset button (on the bottom left) and try again > >> >> > - most RAW import tools I know use E.V. for exposure correction - >> >> > 99% of users will expect that somewhere >> >> >> >> well the unit is EV in current exposure settings. What that you need >> >> exactly ? >> > >> > Where is it noted? I see Exposure Exposure with -0.50 +0.50 range >> >> Shift+F1 over the slider... > > OK - but why only -0.5 +0.5 range? I would expect more like -3 +3 range > for fixing of badly broken images. > you have right. I will fix it. Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Dnia Thursday 14 of August 2008, Gilles Caulier napisał:
> > Well, now it takes effect but widget is completely broken. See > > attached image. > > Sound like your curves saved in rc file beween session is broken > somewhere. Press curve reset button (on the bottom left) and try again It wasn't only rc file. Had to make distclean in digikam directory and build from scratc - but it works now, thanks. m. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier-4
On Wednesday 13 August 2008 08:18:24 Gilles Caulier wrote: > 2008/8/13 Mikolaj Machowski <[hidden email]>: > > Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: > >> 2008/8/12 Mikolaj Machowski <[hidden email]>: > >> > Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: > >> >> >> -Add Lineary adjustmant using curve widget (as UFRAW). > >> >> > > >> >> > Doesn't work :( (svn 845503) > >> >> > Widget is there, I can play with curve but without effects. > >> >> > >> >> It take effect to press on preview for the moment. > >> > > >> > Doesn't work for me. > >> > >> Hum. I have simplified image loading with commit #846035. checkout and > >> try again > > > > Well, now it takes effect but widget is completely broken. See > > attached image. > > Sound like your curves saved in rc file beween session is broken > somewhere. Press curve reset button (on the bottom left) and try again > > >> >> > - most RAW import tools I know use E.V. for exposure correction - > >> >> > 99% of users will expect that somewhere > >> >> > >> >> well the unit is EV in current exposure settings. What that you need > >> >> exactly ? > >> > > >> > Where is it noted? I see Exposure Exposure with -0.50 +0.50 range > >> > >> Shift+F1 over the slider... > > > > OK - but why only -0.5 +0.5 range? I would expect more like -3 +3 range > > for fixing of badly broken images. > > you have right. I will fix it. > > Gilles Hi Gilles, I've been battling for hours with this error in 0.9.5-svn because I want to test the rawimport, but I can't find a remedy. Configuration goes fine and then I get this error message: ... config.status: creating config.h config.status: config.h is unchanged config.status: executing depfiles commands -- digiKam configure results ------------------- -- using internal libsqlite3...... YES -- libgphoto2 library found....... YES -- libtiff library found..... .... YES -- libpng library found........... YES -- libjasper library found........ YES -- liblcms library found.......... YES -- libkipi library found.......... YES -- libkexiv2 library found........ YES -- libkdcraw library found........ YES ------------------------------------------------ Good - your configure finished. Start make now ./configure --prefix=/usr make: *** No rule to make target `../acinclude.m4', needed by `Makefile.in'. Stop. When I use the tarball of 0.9.4 all compiles well. So I don't believe that I've lost some dependency files. Got any idea? Thanks in advance Gerhard _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Gerhard,
from where are you starting configure? From within graphics or digiKam? To make configure work fine I suggest to start from the graphics folder (like mentioned on the digiKam website). If your checkout is a little bit older and you were able to compile before, you might need to repeat those steps: make -f Makefile.cvs ./configure --enable-debug=full --prefix=/usr (or appropriate path) Sometimes the autotools don't recognize that something significant has changed and they don't update all the makefile dependencies. On Saturday 16 August 2008 08:38:38 Gerhard Kulzer wrote: > Good - your configure finished. Start make now > > ./configure --prefix=/usr > make: *** No rule to make target `../acinclude.m4', needed by > `Makefile.in'. Stop. > This looks like the described autotools problem in the above post. I hope this will fix it. Andi _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
On Saturday 16 August 2008 09:49:09 Andi Clemens wrote: > Gerhard, > > from where are you starting configure? From within graphics or digiKam? To > make configure work fine I suggest to start from the graphics folder (like > mentioned on the digiKam website). I alway configure from graphics, I actually use a script that has been running just fine over the last two years without changes. I did not update my autotools recently. > If your checkout is a little bit older and you were able to compile before, > you might need to repeat those steps: > > make -f Makefile.cvs > ./configure --enable-debug=full --prefix=/usr (or appropriate path) Sure, always like that, and I build in a separate folder which is removed clean every time. Gerhard > Sometimes the autotools don't recognize that something significant has > changed and they don't update all the makefile dependencies. > > On Saturday 16 August 2008 08:38:38 Gerhard Kulzer wrote: > > Good - your configure finished. Start make now > > > > ./configure --prefix=/usr > > make: *** No rule to make target `../acinclude.m4', needed by > > `Makefile.in'. Stop. > > This looks like the described autotools problem in the above post. I hope > this will fix it. > > Andi > _______________________________________________ > Digikam-devel mailing list > https://mail.kde.org/mailman/listinfo/digikam-devel _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Hmm strange, I just did a fresh checkout and configure, works fine here...
Andi On Saturday 16 August 2008 10:25:11 Gerhard Kulzer wrote: > On Saturday 16 August 2008 09:49:09 Andi Clemens wrote: > > Gerhard, > > > > from where are you starting configure? From within graphics or digiKam? > > To make configure work fine I suggest to start from the graphics folder > > (like mentioned on the digiKam website). > > I alway configure from graphics, I actually use a script that has been > running just fine over the last two years without changes. I did not update > my autotools recently. > > > If your checkout is a little bit older and you were able to compile > > before, you might need to repeat those steps: > > > > make -f Makefile.cvs > > ./configure --enable-debug=full --prefix=/usr (or appropriate path) > > Sure, always like that, and I build in a separate folder which is removed > clean every time. > > Gerhard > > > Sometimes the autotools don't recognize that something significant has > > changed and they don't update all the makefile dependencies. > > > > On Saturday 16 August 2008 08:38:38 Gerhard Kulzer wrote: > > > Good - your configure finished. Start make now > > > > > > ./configure --prefix=/usr > > > make: *** No rule to make target `../acinclude.m4', needed by > > > `Makefile.in'. Stop. > > > > This looks like the described autotools problem in the above post. I hope > > this will fix it. > > > > Andi > > _______________________________________________ > > Digikam-devel mailing list > > [hidden email] > > https://mail.kde.org/mailman/listinfo/digikam-devel _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gerhard Kulzer-3
Dnia Saturday 16 of August 2008, Gerhard Kulzer napisał:
> On Saturday 16 August 2008 09:49:09 Andi Clemens wrote: > > Gerhard, > > > > from where are you starting configure? From within graphics or > > digiKam? To make configure work fine I suggest to start from the > > graphics folder (like mentioned on the digiKam website). > > I alway configure from graphics, I actually use a script that has been > running just fine over the last two years without changes. I did not > update my autotools recently. > You need at least make distclean, or even fresh checkout of whole digikam dir. m. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gerhard Kulzer-3
2008/8/16, Gerhard Kulzer <[hidden email]>:
> On Wednesday 13 August 2008 08:18:24 Gilles Caulier wrote: >> 2008/8/13 Mikolaj Machowski <[hidden email]>: >> > Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: >> >> 2008/8/12 Mikolaj Machowski <[hidden email]>: >> >> > Dnia Tuesday 12 of August 2008, Gilles Caulier napisał: >> >> >> >> -Add Lineary adjustmant using curve widget (as UFRAW). >> >> >> > >> >> >> > Doesn't work :( (svn 845503) >> >> >> > Widget is there, I can play with curve but without effects. >> >> >> >> >> >> It take effect to press on preview for the moment. >> >> > >> >> > Doesn't work for me. >> >> >> >> Hum. I have simplified image loading with commit #846035. checkout and >> >> try again >> > >> > Well, now it takes effect but widget is completely broken. See >> > attached image. >> >> Sound like your curves saved in rc file beween session is broken >> somewhere. Press curve reset button (on the bottom left) and try again >> >> >> >> > - most RAW import tools I know use E.V. for exposure correction - >> >> >> > 99% of users will expect that somewhere >> >> >> >> >> >> well the unit is EV in current exposure settings. What that you need >> >> >> exactly ? >> >> > >> >> > Where is it noted? I see Exposure Exposure with -0.50 +0.50 range >> >> >> >> Shift+F1 over the slider... >> > >> > OK - but why only -0.5 +0.5 range? I would expect more like -3 +3 range >> > for fixing of badly broken images. >> >> you have right. I will fix it. >> >> Gilles > > Hi Gilles, > I've been battling for hours with this error in 0.9.5-svn because I want to > test the rawimport, but I can't find a remedy. Configuration goes fine and > then I > get this error message: > ... > config.status: creating config.h > config.status: config.h is unchanged > config.status: executing depfiles commands > > -- digiKam configure results ------------------- > -- using internal libsqlite3...... YES > -- libgphoto2 library found....... YES > -- libtiff library found..... .... YES > -- libpng library found........... YES > -- libjasper library found........ YES > -- liblcms library found.......... YES > -- libkipi library found.......... YES > -- libkexiv2 library found........ YES > -- libkdcraw library found........ YES > ------------------------------------------------ > > Good - your configure finished. Start make now > > ./configure --prefix=/usr > make: *** No rule to make target `../acinclude.m4', needed by `Makefile.in'. > > Stop. > > When I use the tarball of 0.9.4 all compiles well. So I don't believe that > I've lost some dependency files. > Got any idea? > > Thanks in advance > Gerhard With KDE3 code, you need to checkout admin folder with all autotools macros relevant of KDE3. Are you checkout this folder as described here : http://www.digikam.org/drupal/download?q=download/svn best Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |