branches/extragear/kde3/graphics/digikam/utilities/imageeditor/rawimport

[Gilles Caulier-4]

SVN commit 847711 by cgilles:

digiKam fromKDE3 branch : re-design again RAW Import settings layout: Now it's more clear to have
all RAW decoding settings and all Post processing settings separated by a tab widget. All Raw decoding require
to demosaic image to take effect. Post processing settings take effect imediatly (demosaised image is cached in memory)
Add Brightness adjustement in post processing group.
CCMAIL: [hidden email]


 M  +14 -17    rawimportdlg.cpp  
 M  +2 -2      rawimportdlg.h  
 M  +3 -2      rawpostprocessing.cpp  
 M  +126 -69   rawsettingsbox.cpp  
 M  +4 -1      rawsettingsbox.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia Sunday 17 of August 2008, Gilles Caulier napisał:
> SVN commit 847711 by cgilles:
>
> digiKam fromKDE3 branch : re-design again RAW Import settings layout:
> Now it's more clear to have all RAW decoding settings and all Post
> processing settings separated by a tab widget. All Raw decoding require
> to demosaic image to take effect. Post processing settings take effect
> imediatly (demosaised image is cached in memory) Add Brightness
> adjustement in post processing group.

Great developments.

Still miss some things from plugins and I hope they will appear:

- colorpicker for white balance
- over/under exposure indicators.

I would suggest using phrase "Luminosity Curve" instead of plain curve
(or something similar). When user can view different histograms for
image (s)he can not understand which curve is playable.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/8/17 Mikolaj Machowski <[hidden email]>:

> Dnia Sunday 17 of August 2008, Gilles Caulier napisał:
>> SVN commit 847711 by cgilles:
>>
>> digiKam fromKDE3 branch : re-design again RAW Import settings layout:
>> Now it's more clear to have all RAW decoding settings and all Post
>> processing settings separated by a tab widget. All Raw decoding require
>> to demosaic image to take effect. Post processing settings take effect
>> imediatly (demosaised image is cached in memory) Add Brightness
>> adjustement in post processing group.
>
> Great developments.
>
> Still miss some things from plugins and I hope they will appear:
>
> - colorpicker for white balance

This is already implemented in background into libkdcraw. for digiKam
i need to patch PreviewWidget. It's in my TODO list

> - over/under exposure indicators.

Same here.

>
> I would suggest using phrase "Luminosity Curve" instead of plain curve
> (or something similar). When user can view different histograms for
> image (s)he can not understand which curve is playable.

Well, i have limited the name of this view to prevent big size of
toolbox on the right side. Perhaps a whatthis is enough ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

> I would suggest using phrase "Luminosity Curve" instead of plain curve
> (or something similar). When user can view different histograms for
> image (s)he can not understand which curve is playable.
>

Done in svn

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia Monday 18 of August 2008, Gilles Caulier napisał:
> > I would suggest using phrase "Luminosity Curve" instead of plain curve
> > (or something similar). When user can view different histograms for
> > image (s)he can not understand which curve is playable.
>
> Done in svn

Thanks, everything looks nice - especially new "reset" buttons.

Small typo: Embeded -> Embedded. Patch attached.

m.


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Thanks Mik,

I have applied your patch!

Andi

On Monday 18 August 2008 21:34:05 Mikolaj Machowski wrote:

> Dnia Monday 18 of August 2008, Gilles Caulier napisał:
> > > I would suggest using phrase "Luminosity Curve" instead of plain curve
> > > (or something similar). When user can view different histograms for
> > > image (s)he can not understand which curve is playable.
> >
> > Done in svn
>
> Thanks, everything looks nice - especially new "reset" buttons.
>
> Small typo: Embeded -> Embedded. Patch attached.
>
> m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Mik, Andi,

Color Management is implemented in RAW Import, using dcraw color profile rules.

http://digikam3rdparty.free.fr/Screenshots/temp/rawimport/rawimport1-sRGB.png

It give strange results (overexposed pixels) when a camera color
profile is used.

http://digikam3rdparty.free.fr/Screenshots/temp/rawimport/rawimport4-Dynax5d_to_sRGB.png

I suspect a problem in dcraw since i can reproduce it directly with
dcraw command line tool, outside libkdcraw (it's not a problem with my
code (:=)))). Look the same result in ufraw :

http://digikam3rdparty.free.fr/Screenshots/temp/rawimport/UFRaw-Dynax5d_to_sRGB.png

I have contacted Dave Coffin for that. I wait and see...

In all case, i'm not satisfied by this Color Management workflow. It
require to re-decode RAW image to apply color management. Like CM is a
post processed job, i will certainly use the CM interface implemented
in digiKam (thrue DImg component).

Best

Gilles

2008/8/18 Mikolaj Machowski <[hidden email]>:

> Dnia Monday 18 of August 2008, Gilles Caulier napisał:
>> > I would suggest using phrase "Luminosity Curve" instead of plain curve
>> > (or something similar). When user can view different histograms for
>> > image (s)he can not understand which curve is playable.
>>
>> Done in svn
>
> Thanks, everything looks nice - especially new "reset" buttons.
>
> Small typo: Embeded -> Embedded. Patch attached.
>
> m.
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia Monday 18 of August 2008, Gilles Caulier napisał:
> Mik, Andi,
>
> Color Management is implemented in RAW Import, using dcraw color profile
> rules.

Works OK as far as I can test.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer-3]

On Monday 18 August 2008 22:21:03 Gilles Caulier wrote:

> Mik, Andi,

>

> Color Management is implemented in RAW Import, using dcraw color profile

> rules.

>

> http://digikam3rdparty.free.fr/Screenshots/temp/rawimport/rawimport1-sRGB.p

>ng

>

> It give strange results (overexposed pixels) when a camera color

> profile is used.

Gilles, I finally got 0.9.5 compiled (it was a lndir problem. I link the source folders to a build folder with lndir, and it doesn't work anymore the same way as in the past. When I do a cp -a all compiles well) and RAW import tool working. It is really great and easy to use!

For the first time I can apply my Canon profiles and they make sense. What I mean is in the past they gave strange results to say the least. Now the changes they do to the images is inline with the variations I get when I use the profiles within the camera.

Gerhard

> http://digikam3rdparty.free.fr/Screenshots/temp/rawimport/rawimport4-Dynax5

>d_to_sRGB.png

>

> I suspect a problem in dcraw since i can reproduce it directly with

> dcraw command line tool, outside libkdcraw (it's not a problem with my

> code (:=)))). Look the same result in ufraw :

>

> http://digikam3rdparty.free.fr/Screenshots/temp/rawimport/UFRaw-Dynax5d_to_

>sRGB.png

>

> I have contacted Dave Coffin for that. I wait and see...

>

> In all case, i'm not satisfied by this Color Management workflow. It

> require to re-decode RAW image to apply color management. Like CM is a

> post processed job, i will certainly use the CM interface implemented

> in digiKam (thrue DImg component).

>

> Best

>

> Gilles

>

> 2008/8/18 Mikolaj Machowski <[hidden email]>:

> > Dnia Monday 18 of August 2008, Gilles Caulier napisał:

> >> > I would suggest using phrase "Luminosity Curve" instead of plain curve

> >> > (or something similar). When user can view different histograms for

> >> > image (s)he can not understand which curve is playable.

> >>

> >> Done in svn

> >

> > Thanks, everything looks nice - especially new "reset" buttons.

> >

> > Small typo: Embeded -> Embedded. Patch attached.

> >

> > m.

> >

> >

> > _______________________________________________

> > Digikam-devel mailing list

> > [hidden email]

> > https://mail.kde.org/mailman/listinfo/digikam-devel

>

> _______________________________________________

> Digikam-devel mailing list

> [hidden email]

> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/8/19 Gerhard Kulzer <[hidden email]>:

> On Monday 18 August 2008 22:21:03 Gilles Caulier wrote:
>
>> Mik, Andi,
>
>>
>
>> Color Management is implemented in RAW Import, using dcraw color profile
>
>> rules.
>
>>
>
>>
>> http://digikam3rdparty.free.fr/Screenshots/temp/rawimport/rawimport1-sRGB.p
>
>>ng
>
>>
>
>> It give strange results (overexposed pixels) when a camera color
>
>> profile is used.
>
> Gilles, I finally got 0.9.5 compiled (it was a lndir problem. I link the
> source folders to a build folder with lndir, and it doesn't work anymore the
> same way as in the past. When I do a cp -a all compiles well) and RAW import
> tool working. It is really great and easy to use!

Thanks Gerhard. I have recieve the response from Dave. My overexposed
pixel is duing of autogamma adjustement set before CM. I can fix it to
decrease gamma in post processed settings.

So, the behaviours is normal.

>
> For the first time I can apply my Canon profiles and they make sense. What I
> mean is in the past they gave strange results to say the least. Now the
> changes they do to the images is inline with the variations I get when I use
> the profiles within the camera.

well, i supose than it's a side effect of auto gamma applied to image
with RAW import. In the pass, with Color Management plugin, the
imported RAW image become only in RAW space (linear) without auto
gamma. this give strange effect.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel