a little patch to add 3d border around icon item...

[Gilles Caulier-4]

Hi all,

I have just tried to play with new QPainter effect from Qt4. Why not to add a little 3D border around icon item like this :

http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-01.png
http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-02.png
http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-03.png

Patch relevant is very small:

http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch

What do you you think about ?

Best

Gilles


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hmm to be honest, I liked the old style better... maybe this could be a
settings option (or even a stylesheet element for our themes)?

Andi


On Thursday 11 December 2008 14:57:29 Gilles Caulier wrote:

> Hi all,
>
> I have just tried to play with new QPainter effect from Qt4. Why not to add
> a little 3D border around icon item like this :
>
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dborderic
>onviewkde4-01.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dborderic
>onviewkde4-02.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dborderic
>onviewkde4-03.png
>
> Patch relevant is very small:
>
> http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch
>
> What do you you think about ?
>
> Best
>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/12/11 Andi Clemens <[hidden email]>

Hmm to be honest, I liked the old style better... maybe this could be a
settings option (or even a stylesheet element for our themes)?

this is not a stylesheet element. the code draw a decorative border using advanced QPainter method instead to do a simple 1 pixel black line.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Thu, Dec 11, 2008 at 9:45 AM, Gilles Caulier
<[hidden email]> wrote:
>
>
> 2008/12/11 Andi Clemens <[hidden email]>
>>
>> Hmm to be honest, I liked the old style better... maybe this could be a
>> settings option (or even a stylesheet element for our themes)?
>
> this is not a stylesheet element. the code draw a decorative border using
> advanced QPainter method instead to do a simple 1 pixel black line.

The minimalist in me is screaming against this "feature. At the very
least, please make it optional and disabled by default.
I personally don't see any purpose to this other than making the
interface look more "modern". I'd appreciate if you could show the
same screenshots but without this border for comparison.
Since I don't have time to understand the code right now, I don't know
if this border will be an issue for someone who wants to fit as many
thumbnails on the screen as possible, but his needs to be considered.


--
Michael Ploujnikov
http://plouj.com/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/12/11 Michael [Plouj] Ploujnikov <[hidden email]>

On Thu, Dec 11, 2008 at 9:45 AM, Gilles Caulier
<[hidden email]> wrote:
>
>
> 2008/12/11 Andi Clemens <[hidden email]>
>>
>> Hmm to be honest, I liked the old style better... maybe this could be a
>> settings option (or even a stylesheet element for our themes)?
>
> this is not a stylesheet element. the code draw a decorative border using
> advanced QPainter method instead to do a simple 1 pixel black line.

The minimalist in me is screaming against this "feature. At the very
least, please make it optional and disabled by default.
I personally don't see any purpose to this other than making the
interface look more "modern". I'd appreciate if you could show the
same screenshots but without this border for comparison.
Since I don't have time to understand the code right now, I don't know
if this border will be an issue for someone who wants to fit as many
thumbnails on the screen as possible, but his needs to be considered.

Look how Gwenview render thumbnail icons, it give a similar view.

This give a more KDE4 look...

Gilles
 

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

But gwenview seems to render a shadow instead of a border, which looks nicer.
Somehow this 3D-border seems to be too thick and distracting.

Andi

On Thursday 11 December 2008 16:07:35 Gilles Caulier wrote:

> 2008/12/11 Michael [Plouj] Ploujnikov <[hidden email]>
>
> > On Thu, Dec 11, 2008 at 9:45 AM, Gilles Caulier
> >
> > <[hidden email]> wrote:
> > > 2008/12/11 Andi Clemens <[hidden email]>
> > >
> > >> Hmm to be honest, I liked the old style better... maybe this could be
> > >> a settings option (or even a stylesheet element for our themes)?
> > >
> > > this is not a stylesheet element. the code draw a decorative border
> > > using advanced QPainter method instead to do a simple 1 pixel black
> > > line.
> >
> > The minimalist in me is screaming against this "feature. At the very
> > least, please make it optional and disabled by default.
> > I personally don't see any purpose to this other than making the
> > interface look more "modern". I'd appreciate if you could show the
> > same screenshots but without this border for comparison.
> > Since I don't have time to understand the code right now, I don't know
> > if this border will be an issue for someone who wants to fit as many
> > thumbnails on the screen as possible, but his needs to be considered.
>
> Look how Gwenview render thumbnail icons, it give a similar view.
>
> This give a more KDE4 look...
>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia Thursday 11 December 2008, Gilles Caulier napisał:

> Hi all,
>
> I have just tried to play with new QPainter effect from Qt4. Why not to
> add a little 3D border around icon item like this :
>
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dborde
>riconviewkde4-01.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dborde
>riconviewkde4-02.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dborde
>riconviewkde4-03.png
>
> Patch relevant is very small:
>
> http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch
>
> What do you you think about ?

Tentatively yes. But be prepared for protests later :)

I think by default border is a bit too dark and wide.

I achieved interesting results by replacing 128 in QColor declaration
with 96 and set radius to 3. IMO it integrates better - especially in
colored themes and when thumbnails are set to smaller images.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia Thursday 11 December 2008, Mikolaj Machowski napisał:
> I achieved interesting results by replacing 128 in QColor declaration
> with 96 and set radius to 3. IMO it integrates better - especially in
> colored themes and when thumbnails are set to smaller images.

Screenshots:

http://www.witkacy.hg.pl/var/bigth.png
http://www.witkacy.hg.pl/var/smallth.png

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/12/11 Andi Clemens <[hidden email]>

But gwenview seems to render a shadow instead of a border, which looks nicer.
Somehow this 3D-border seems to be too thick and distracting.

The way of gwenview is very similar, but it move from few pixel the border on the right bottom to give a better 3D effect... I will make a second try

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Thu, Dec 11, 2008 at 10:07 AM, Gilles Caulier
<[hidden email]> wrote:
>
> This give a more KDE4 look...

Wouldn't it be better to use some Qt widget to make sure that this
works with custom Qt themes and is future-proof?

--
Michael Ploujnikov
http://plouj.com/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/12/11 Michael [Plouj] Ploujnikov <[hidden email]>

On Thu, Dec 11, 2008 at 10:07 AM, Gilles Caulier

<[hidden email]> wrote:
>

> This give a more KDE4 look...

Wouldn't it be better to use some Qt widget to make sure that this
works with custom Qt themes and is future-proof?

Not curretnyl, because iconview object is based on Qt3 support for Qt4. We have planed to port in pure Qt4 later than 0.10.0.

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

On Thu, 11 Dec 2008, Gilles Caulier wrote:

> Hi all,
>
> I have just tried to play with new QPainter effect from Qt4. Why not to add
> a little 3D border around icon item like this :
>
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-01.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-02.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-03.png
>
> Patch relevant is very small:
>
> http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch
>
> What do you you think about ?

To be honest: I don't like it at all, please make anything
like this optional ....

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/12/11 Arnd Baecker <[hidden email]>

On Thu, 11 Dec 2008, Gilles Caulier wrote:

> Hi all,
>
> I have just tried to play with new QPainter effect from Qt4. Why not to add
> a little 3D border around icon item like this :
>
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-01.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-02.png
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-03.png
>
> Patch relevant is very small:
>
> http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch
>
> What do you you think about ?

To be honest: I don't like it at all, please make anything
like this optional ....

I don't want to add an option just for that...

I have fully rewrittent his patch now. Untouched thumbnail loader  and fixed against icon item implementation (like it must be done in the future by pure Qt4 Model/view code)

The frame is now very very discret (3 pixels no more, and code is the same than GWenview + some optimization.

Look the screenshot :

http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-04.png

Patch is at the same place:

http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch

Of course revert previous patch before to compile with this one...

I hope this one will have a better audience (:=)))

Best

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Thu, Dec 11, 2008 at 4:23 PM, Gilles Caulier
<[hidden email]> wrote:

>
>
> 2008/12/11 Arnd Baecker <[hidden email]>
>>
>> On Thu, 11 Dec 2008, Gilles Caulier wrote:
>>
>> > Hi all,
>> >
>> > I have just tried to play with new QPainter effect from Qt4. Why not to
>> > add
>> > a little 3D border around icon item like this :
>> >
>> >
>> > http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-01.png
>> >
>> > http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-02.png
>> >
>> > http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-03.png
>> >
>> > Patch relevant is very small:
>> >
>> > http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch
>> >
>> > What do you you think about ?
>>
>> To be honest: I don't like it at all, please make anything
>> like this optional ....
>
> I don't want to add an option just for that...
>
> I have fully rewrittent his patch now. Untouched thumbnail loader  and fixed
> against icon item implementation (like it must be done in the future by pure
> Qt4 Model/view code)
>
> The frame is now very very discret (3 pixels no more, and code is the same
> than GWenview + some optimization.
>
> Look the screenshot :
>
> http://digikam3rdparty.free.fr/Screenshots/temp/3dbordericonkde4/3dbordericonviewkde4-04.png
>
> Patch is at the same place:
>
> http://digikam3rdparty.free.fr/misc.tarballs/3dbordericonviewkde4.patch
>
> Of course revert previous patch before to compile with this one...
>
> I hope this one will have a better audience (:=)))

It does look more discrete this way :). I like that it looks almost
like a shadow now.



--
Michael Ploujnikov
http://plouj.com/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia Thursday 11 December 2008, Gilles Caulier napisał:
>
> I hope this one will have a better audience (:=)))

Looks much better now :)

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel