Void method in imagehistorygraph is returning something

Hi,

the following code returns something, although the function is marked as  
void:
http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/imagehistory/imagehistorygraph_boost.h#357

Any idea?

Andi

--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

OH... Great. Why i can't see this warning with GCC, MinGW and MSVC ? How do you compile digiKam ? Which options you use ?

Marcel, which value must be returned ? Bool ?

Gilles Caulier

2011/6/11 Andi Clemens <[hidden email]>

Hi,

the following code returns something, although the function is marked as
void:
http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/imagehistory/imagehistorygraph_boost.h#357

Any idea?

Andi

--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

My custom settings for GCC are:
-pedantic -fopenmp


But I guess the warning came from Eclipse, not GCC.

Andi


On Sat, 11 Jun 2011 12:21:11 +0200, Gilles Caulier  
<[hidden email]> wrote:

> OH... Great. Why i can't see this warning with GCC, MinGW and MSVC ? How  
> do
> you compile digiKam ? Which options you use ?
>
> Marcel, which value must be returned ? Bool ?
>
> Gilles Caulier
>
> 2011/6/11 Andi Clemens <[hidden email]>
>
>> Hi,
>>
>> the following code returns something, although the function is marked as
>> void:
>>
>> http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/imagehistory/imagehistorygraph_boost.h#357
>>
>> Any idea?
>>
>> Andi
>>
>> --
>> Using Opera's revolutionary email client: http://www.opera.com/mail/
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>

--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Ah Eclipse do not use GCC in background. I never used it... I'm suprized that a new compiler have been written for Eclipse...

Gilles

2011/6/11 Andi Clemens <[hidden email]>

My custom settings for GCC are:
-pedantic -fopenmp


But I guess the warning came from Eclipse, not GCC.

Andi

On Sat, 11 Jun 2011 12:21:11 +0200, Gilles Caulier
<[hidden email]> wrote:

> OH... Great. Why i can't see this warning with GCC, MinGW and MSVC ? How
> do
> you compile digiKam ? Which options you use ?
>
> Marcel, which value must be returned ? Bool ?
>
> Gilles Caulier
>
> 2011/6/11 Andi Clemens <[hidden email]>
>
>> Hi,
>>
>> the following code returns something, although the function is marked as
>> void:
>>
>> http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/imagehistory/imagehistorygraph_boost.h#357
>>
>> Any idea?
>>
>> Andi
>>
>> --
>> Using Opera's revolutionary email client: http://www.opera.com/mail/
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>

--

Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Sure it uses GCC in the background, but it does some extra checks during  
compiling.
:-)

Andi


On Sat, 11 Jun 2011 14:27:28 +0200, Gilles Caulier  
<[hidden email]> wrote:

> Ah Eclipse do not use GCC in background. I never used it... I'm suprized
> that a new compiler have been written for Eclipse...
>
> Gilles
>
> 2011/6/11 Andi Clemens <[hidden email]>
>
>> My custom settings for GCC are:
>> -pedantic -fopenmp
>>
>>
>> But I guess the warning came from Eclipse, not GCC.
>>
>> Andi
>>
>>
>> On Sat, 11 Jun 2011 12:21:11 +0200, Gilles Caulier
>> <[hidden email]> wrote:
>>
>> > OH... Great. Why i can't see this warning with GCC, MinGW and MSVC ?  
>> How
>> > do
>> > you compile digiKam ? Which options you use ?
>> >
>> > Marcel, which value must be returned ? Bool ?
>> >
>> > Gilles Caulier
>> >
>> > 2011/6/11 Andi Clemens <[hidden email]>
>> >
>> >> Hi,
>> >>
>> >> the following code returns something, although the function is  
>> marked as
>> >> void:
>> >>
>> >>
>> http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/imagehistory/imagehistorygraph_boost.h#357
>> >>
>> >> Any idea?
>> >>
>> >> Andi
>> >>
>> >> --
>> >> Using Opera's revolutionary email client: http://www.opera.com/mail/
>> >> _______________________________________________
>> >> Digikam-devel mailing list
>> >> [hidden email]
>> >> https://mail.kde.org/mailman/listinfo/digikam-devel
>> >>
>>
>>
>> --
>> Using Opera's revolutionary email client: http://www.opera.com/mail/
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>

--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> the following code returns something, although the function is marked as
> void:
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/imagehis
> tory/imagehistorygraph_boost.h#357

put() returns void, so it may be valid C++ or not, but nothing is wrong and
the word "return" could just be removed
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel