Version checking for KF5CalendarCore and KF5AkonadiContact in bootstrap.linux seems wrong.

[Eric Valette]

In debian (and upstream as shipped with kde 15.08.2)
KF5CalendarCoreConfigVersion.cmake has a version equal to 4.82.0, same
for KF5AkonadiContactConfigVersion.cmake.

But during bootstrap.linux, a version at least equal to 15.08.2 is
expected which is the version number of the KDE framework but not the
kdepim version.

Or did I miss something?

-- eric


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2015-12-16 19:01 GMT+01:00 Eric Valette <[hidden email]>:

In debian (and upstream as shipped with kde 15.08.2) KF5CalendarCoreConfigVersion.cmake has a version equal to 4.82.0, same for KF5AkonadiContactConfigVersion.cmake.

But during bootstrap.linux, a version at least equal to 15.08.2 is expected which is the version number of the KDE framework but not the kdepim version.

If i remember, kdepim still under developement for KF5 and as i can see in KDE core mailing list, the project is currently in split mode to make undependant and small frameworks

I other words, i set the kdepim* release ID in digiKam cmake accordingly with git repository value that i found in frameworks. It's possible that all change in the future. The 4.82.0 is typically an ID under development not yet finalized with for 5.x. Probably KF5::kdepim package is outdated in Debian.

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Eric Valette]

On 16/12/2015 21:45, Gilles Caulier wrote:

> I other words, i set the kdepim* release ID in digiKam cmake accordingly
> with git repository value that i found in frameworks. It's possible that
> all change in the future. The 4.82.0 is typically an ID under
> development not yet finalized with for 5.x. Probably KF5::kdepim package
> is outdated in Debian.

4.82.0 is the version that comes with 15.08.2 as delivered upstream but
that is still not integrated into frameworks

And what is puzzling me is on one side:

find_package(KF5 ${KF5_MIN_VERSION}
              OPTIONAL_COMPONENTS
              Archive      # for FlashExport
              ThreadWeaver # for Panorama
              CalendarCore # for Calendar
)

with the KF5_MIN_VERSION equal to 5.1.0

and on the other side:


PRINT_OPTIONAL_LIBRARY_STATUS("libkcalcore"
"https://projects.kde.org/projects/kde/pim/kcalcore"
"(version >= 4.81.0)"                 "Kipi-plugins
will be compiled without libkcalcore support."     KF5CalendarCore_FOUND)

I have 4.82.0 on my system and appart the failing check, if I set a
version number > 5.1.0 all is fine at leat at compil level.

-- eric

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Eric Valette]

On 16/12/2015 21:53, Eric Valette wrote:

Proposed fix attached...

> On 16/12/2015 21:45, Gilles Caulier wrote:
>
>> I other words, i set the kdepim* release ID in digiKam cmake accordingly
>> with git repository value that i found in frameworks. It's possible that
>> all change in the future. The 4.82.0 is typically an ID under
>> development not yet finalized with for 5.x. Probably KF5::kdepim package
>> is outdated in Debian.
>
> 4.82.0 is the version that comes with 15.08.2 as delivered upstream but
> that is still not integrated into frameworks
>
> And what is puzzling me is on one side:
>
> find_package(KF5 ${KF5_MIN_VERSION}
>               OPTIONAL_COMPONENTS
>               Archive      # for FlashExport
>               ThreadWeaver # for Panorama
>               CalendarCore # for Calendar
> )
>
> with the KF5_MIN_VERSION equal to 5.1.0
>
> and on the other side:
>
>
> PRINT_OPTIONAL_LIBRARY_STATUS("libkcalcore"
> "https://projects.kde.org/projects/kde/pim/kcalcore" "(version >=
> 4.81.0)"                 "Kipi-plugins
> will be compiled without libkcalcore support."     KF5CalendarCore_FOUND)
>
> I have 4.82.0 on my system and appart the failing check, if I set a
> version number > 5.1.0 all is fine at leat at compil level.
>
> -- eric
>

--
    __
   /  `                   Eric Valette
  /--   __  o _.           6 rue Paul Le Flem
(___, / (_(_(__         35740 Pace

Tel: [phone] Fax: [phone]
E-mail: [hidden email]




_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Fixed with this commit :

http://commits.kde.org/kipi-plugins/740a16039889cd06fb447ff7d61baf12421cc022

Gilles Caulier

2015-12-16 22:48 GMT+01:00 Eric Valette <[hidden email]>:

On 16/12/2015 21:53, Eric Valette wrote:

Proposed fix attached...

On 16/12/2015 21:45, Gilles Caulier wrote:

I other words, i set the kdepim* release ID in digiKam cmake accordingly
with git repository value that i found in frameworks. It's possible that
all change in the future. The 4.82.0 is typically an ID under
development not yet finalized with for 5.x. Probably KF5::kdepim package
is outdated in Debian.

4.82.0 is the version that comes with 15.08.2 as delivered upstream but
that is still not integrated into frameworks

And what is puzzling me is on one side:

find_package(KF5 ${KF5_MIN_VERSION}
              OPTIONAL_COMPONENTS
              Archive      # for FlashExport
              ThreadWeaver # for Panorama
              CalendarCore # for Calendar
)

with the KF5_MIN_VERSION equal to 5.1.0

and on the other side:


PRINT_OPTIONAL_LIBRARY_STATUS("libkcalcore"
"https://projects.kde.org/projects/kde/pim/kcalcore" "(version >=
4.81.0)"                 "Kipi-plugins
will be compiled without libkcalcore support."     KF5CalendarCore_FOUND)

I have 4.82.0 on my system and appart the failing check, if I set a
version number > 5.1.0 all is fine at leat at compil level.

-- eric

--
   __
  /  `                          Eric Valette
 /--   __  o _.                 6 rue Paul Le Flem
(___, / (_(_(__                 35740 Pace

Tel: <a href="tel:%2B33%20%280%292%2099%2085%2026%2076" value="[phone]" target="_blank">[phone]   Fax: <a href="tel:%2B33%20%280%292%2099%2085%2026%2076" value="[phone]" target="_blank">[phone]
E-mail: [hidden email]

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel