Status of face detection

classic Classic list List threaded Threaded
87 messages Options
12345
Reply | Threaded
Open this post in threaded view
|

Re: Status of face detection

Marcel Wiesweg

> I'd just like to add, that I also have just the moving slider, not the
> progressbar (Qt4.7 KDE 4.5.3).

Very interesting.
This DProgressDlg is implemented in utilities/batch/batchfacedetector.cpp.
In startAlbumListing(), the expected total is computed, and set to the
progress bar in line 186.
For each finished scanned image,slotShowOneDetected is called and the progress
is advanced by 1 in line 257. This also sets the small thumbnail in the
progress dialog. If images are skipped, it's slotImagesSkipped, 246.

I assume that setting the total must fail, but I dont know why.


What about the other problems:
- with a _confirmed_ name, clicking on the label in the preview view does
nothing
- in the preview view, typing in the tags line edit and then selecting a tag
with the mouse selects the first tag in the list, instead of the one under the
cursor

Thanks
Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Status of face detection

"Jens Müller"
>
> > I'd just like to add, that I also have just the moving slider, not the
> > progressbar (Qt4.7 KDE 4.5.3).

Some config for me: KDE 4.5.3 and Qt 4.7.0

I discovered another issue: In preview view context menu there is a entry 'Clear all faces on this image'. But after clicking it, the tags and regions stay there.

Regards, Jens


--
GMX DSL Doppel-Flat ab 19,99 €/mtl.! Jetzt auch mit
gratis Notebook-Flat! http://portal.gmx.net/de/go/dsl
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Status of face detection

Martin Klapetek
In reply to this post by Marcel Wiesweg
On Wed, Nov 24, 2010 at 18:07, Marcel Wiesweg <[hidden email]> wrote:

> I'd just like to add, that I also have just the moving slider, not the
> progressbar (Qt4.7 KDE 4.5.3).

Very interesting.
This DProgressDlg is implemented in utilities/batch/batchfacedetector.cpp.
In startAlbumListing(), the expected total is computed, and set to the
progress bar in line 186.
For each finished scanned image,slotShowOneDetected is called and the progress
is advanced by 1 in line 257. This also sets the small thumbnail in the
progress dialog. If images are skipped, it's slotImagesSkipped, 246.

I assume that setting the total must fail, but I dont know why.

Yes, the total is 0 in my case. I'll try to find out why later..
 


What about the other problems:
- with a _confirmed_ name, clicking on the label in the preview view does
nothing

Yes, it does nothing. However, if there are some uncofirmed tags and if I create a new tag for a new person and click 'Confirm', the tag is created ok, assigned ok, but it is displayed like the name would be empty (or just spaces). After switching image and then switching back, the name is properly in its place.

There is one other issue with this - if there are two persons on one image and both are confirmed, then in the people-tag-icon-view, each person's face has two tags under the face, one it's own and the other is from the other person. I think this shouldn't happen, because it implies that there are two tags assigned to one face and so it seems like it's wrong.
 
- in the preview view, typing in the tags line edit and then selecting a tag
with the mouse selects the first tag in the list, instead of the one under the
cursor

For me, clicking anything in the list does nothing but closes the list. No tag is selected, no name is filled in. The list just closes silently. 

Marty

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Status of face detection

Martin Klapetek
Also sending one usability issue, when too many faces were detected on one photo :) See http://www.flickr.com/photos/mck182/5204871587/

And with what I posted previously and with more testing, I'd like to take back the issue when assigning a tag to a photo in Unknown takes the photo out, but assigns the same tag to the picture next to it. That's the same issue as having two or more people on one photo, then all the tags are under everyone on that photo. So we should display only the tag name of the person who actually is on the face thumbnail (an in case of unknown, display no tags, currently there are tags of other people on the same photo).

Marty 

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Status of face detection

S. Burmeister
In reply to this post by Martin Klapetek
Am Mittwoch, 24. November 2010, 23:47:12 schrieb Martin Klapetek:
> Yes, it does nothing. However, if there are some uncofirmed tags and if I
> create a new tag for a new person and click 'Confirm', the tag is created
> ok, assigned ok, but it is displayed like the name would be empty (or just
> spaces). After switching image and then switching back, the name is
> properly in its place.

I can confirm that as well.

> > - in the preview view, typing in the tags line edit and then selecting a
> > tag
> > with the mouse selects the first tag in the list, instead of the one
> > under the
> > cursor
>
> For me, clicking anything in the list does nothing but closes the list. No
> tag is selected, no name is filled in. The list just closes silently.

For me the drop-down menu with the existing tags and the "Create new tag..."
is cut off, i.e. not wide enough to display "Create new tag name of a person".

Sven
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Status of face detection

Marcel Wiesweg
In reply to this post by Martin Klapetek


> > I assume that setting the total must fail, but I dont know why.
>
> Yes, the total is 0 in my case. I'll try to find out why later..

Do you display the album counts in the treeviews?


> Yes, it does nothing.

Ok, it's the RClickLabel from libkdcraw. Either it's a problem with this
class, or something changed in Qt4.7 regarding event distribution in
QGraphicsView. I will see if I can install Qt4.7 without breaking my system...

> However, if there are some uncofirmed tags and if I
> create a new tag for a new person and click 'Confirm', the tag is created
> ok, assigned ok, but it is displayed like the name would be empty (or just
> spaces). After switching image and then switching back, the name is
> properly in its place.

I thought I fixed that once, seems it's still an issue...

>
> There is one other issue with this - if there are two persons on one image
> and both are confirmed, then in the people-tag-icon-view, each person's
> face has two tags under the face, one it's own and the other is from the
> other person. I think this shouldn't happen, because it implies that there
> are two tags assigned to one face and so it seems like it's wrong.

Yes, obviously the face delegate should not draw any person tags in the "tags"
space. Currently, it's just the same code as in normal views, drawing all tag
names.

> For me, clicking anything in the list does nothing but closes the list. No
> tag is selected, no name is filled in. The list just closes silently.
>
> Marty

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Status of face detection

S. Burmeister
Am Donnerstag, 25. November 2010, 10:28:54 schrieb Marcel Wiesweg:
> Ok, it's the RClickLabel from libkdcraw. Either it's a problem with this
> class, or something changed in Qt4.7 regarding event distribution in
> QGraphicsView. I will see if I can install Qt4.7 without breaking my
> system...

libqt4-4.6.3-8.1.x86_64 is what I use and I see the same issue. The libkdcraw
version I have installed is the one from KDE trunk Rev: 1199690.

Sven
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12345