Review Request: speedup fingerprints scan or recreation

[Jaime Torres]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102104/

Review request for Digikam.

By Jaime Torres Amate.

Description

Replace a QStringList by a QHash<QString,int>.
Callgrind confirm that what was 95% CPU in QStringList is now a 20% CPU only when recreating all the fingerprints,
less when scaning.

Testing

Run under callgrind recreating all the fingerprings (around 12000 images)
normally run, you can see there is no slowdown as the progress bar is filled.

Bugs: 273077

Diffs

• libs/threadimageio/loadingcache.h (d664814)
• libs/threadimageio/loadingcache.cpp (87f80d9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jaime Torres]

I was slower than Andi.
Please forget it.

2011/7/27 Jaime Torres Amate <[hidden email]>

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102104/

Review request for Digikam.

By Jaime Torres Amate.

Description

Replace a QStringList by a QHash<QString,int>.
Callgrind confirm that what was 95% CPU in QStringList is now a 20% CPU only when recreating all the fingerprints,
less when scaning.

Testing

Run under callgrind recreating all the fingerprings (around 12000 images)
normally run, you can see there is no slowdown as the progress bar is filled.

Bugs: 273077

Diffs

• libs/threadimageio/loadingcache.h (d664814)
• libs/threadimageio/loadingcache.cpp (87f80d9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel