Review Request: fixes for some warnings and error reported by cppcheck

[Jaime Torres]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101946/

Review request for Digikam.

By Jaime Torres Amate.

Description

Fixes for some warnings and error reported by cppcheck
Do you modify code in the 3rdparty directory? If not, it will be removed from the patch.

Testing

I've seen no regression.

Diffs

• digikam/album/albummanager.h (c9c1417)
• imageplugins/enhance/hotpixels/weights.h (11f5176)
• imageplugins/enhance/hotpixels/weights.cpp (90d35d3)
• libs/3rdparty/libpgf/Decoder.cpp (af9391f)
• libs/database/haar/haar.h (ea492cb)
• libs/dimg/filters/auto/stretchfilter.cpp (6ecdc9d)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101946/

Looks fine for me. No regression to expect. Commit if you like.

- Marcel

On July 13th, 2011, 7:04 p.m., Jaime Torres Amate wrote:

Review request for Digikam.

By Jaime Torres Amate.

Updated July 13, 2011, 7:04 p.m.

Description

Fixes for some warnings and error reported by cppcheck
Do you modify code in the 3rdparty directory? If not, it will be removed from the patch.

Testing

I've seen no regression.

Diffs

• digikam/album/albummanager.h (c9c1417)
• imageplugins/enhance/hotpixels/weights.h (11f5176)
• imageplugins/enhance/hotpixels/weights.cpp (90d35d3)
• libs/3rdparty/libpgf/Decoder.cpp (af9391f)
• libs/database/haar/haar.h (ea492cb)
• libs/dimg/filters/auto/stretchfilter.cpp (6ecdc9d)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-5]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101946/

This review has been submitted with commit 7c6a07a6aad7e53a0734be61ce60523abaa41b8e by Jaime Torres to branch master.

- Commit

On July 13th, 2011, 7:04 p.m., Jaime Torres Amate wrote:

Review request for Digikam.

By Jaime Torres Amate.

Updated July 13, 2011, 7:04 p.m.

Description

Fixes for some warnings and error reported by cppcheck
Do you modify code in the 3rdparty directory? If not, it will be removed from the patch.

Testing

I've seen no regression.

Diffs

• digikam/album/albummanager.h (c9c1417)
• imageplugins/enhance/hotpixels/weights.h (11f5176)
• imageplugins/enhance/hotpixels/weights.cpp (90d35d3)
• libs/3rdparty/libpgf/Decoder.cpp (af9391f)
• libs/database/haar/haar.h (ea492cb)
• libs/dimg/filters/auto/stretchfilter.cpp (6ecdc9d)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel