Review Request: avoid 3 warnings

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request: avoid 3 warnings

Jaime Torres
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105202/

Review request for Digikam.
By Jaime Torres Amate.

Description

1. unsigned compared with signed gone
2. QSlider parameters are int, not float.

Testing

compiles with 3 warnings less.

Diffs

  • libs/progressmanager/progressmanager.cpp (f4e0ee0)
  • utilities/setup/setupfacetags.cpp (c8aa610)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request: avoid 3 warnings

Gilles Caulier-5
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105202/

This review has been submitted with commit ea348f8ac66353de8bbd72bb60cb18685d115f2c by Gilles Caulier to branch master.

- Commit


On June 10th, 2012, 11:26 a.m., Jaime Torres Amate wrote:

Review request for Digikam.
By Jaime Torres Amate.

Updated June 10, 2012, 11:26 a.m.

Description

1. unsigned compared with signed gone
2. QSlider parameters are int, not float.

Testing

compiles with 3 warnings less.

Diffs

  • libs/progressmanager/progressmanager.cpp (f4e0ee0)
  • utilities/setup/setupfacetags.cpp (c8aa610)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel