Review Request: InvertFilter: fix filter chaining

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request: InvertFilter: fix filter chaining

Matthias Welwarsky
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103966/

Review request for Digikam.
By Matthias Welwarsky.

Description

Invert filter needs to export its target image, otherwise it does not work in slave mode.

Diffs

  • CMakeLists.txt (fccb0396ce146d68a319a90125ee80506aeaf64b)
  • imageplugins/color/CMakeLists.txt (c233b06e506a0a57633fe836303228953d66ff1b)
  • imageplugins/color/digikamimageplugin_color_ui.rc (757f091ba48e80fbd425ca0e0ddca59ec488c5d5)
  • imageplugins/color/filmtool.h (PRE-CREATION)
  • imageplugins/color/filmtool.cpp (PRE-CREATION)
  • imageplugins/color/imageplugin_color.h (07a3d89a7f64fb604e7ed782e8d10f5dbc4119d0)
  • imageplugins/color/imageplugin_color.cpp (8cb1f9532dbd7cc862533a81f519e9b7b21593f1)
  • libs/dimg/filters/film/filmfilter.h (PRE-CREATION)
  • libs/dimg/filters/film/filmfilter.cpp (PRE-CREATION)
  • libs/dimg/filters/levels/levelsfilter.h (217d95524dda6061c707e80a509e025e2bec28d5)
  • libs/dimg/filters/levels/levelsfilter.cpp (f45626e338f251d67ea3d36d1647157162c93d92)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request: InvertFilter: fix filter chaining

Matthias Welwarsky
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103966/

Review request for Digikam.
By Matthias Welwarsky.

Updated Feb. 13, 2012, 11:27 a.m.

Description

Invert filter needs to export its target image, otherwise it does not work in slave mode.

Diffs

  • CMakeLists.txt (fccb0396ce146d68a319a90125ee80506aeaf64b)
  • imageplugins/color/CMakeLists.txt (c233b06e506a0a57633fe836303228953d66ff1b)
  • imageplugins/color/digikamimageplugin_color_ui.rc (757f091ba48e80fbd425ca0e0ddca59ec488c5d5)
  • imageplugins/color/filmtool.h (PRE-CREATION)
  • imageplugins/color/filmtool.cpp (PRE-CREATION)
  • imageplugins/color/imageplugin_color.h (07a3d89a7f64fb604e7ed782e8d10f5dbc4119d0)
  • imageplugins/color/imageplugin_color.cpp (8cb1f9532dbd7cc862533a81f519e9b7b21593f1)
  • libs/dimg/filters/film/filmfilter.h (PRE-CREATION)
  • libs/dimg/filters/film/filmfilter.cpp (PRE-CREATION)
  • libs/dimg/filters/levels/levelsfilter.h (217d95524dda6061c707e80a509e025e2bec28d5)
  • libs/dimg/filters/levels/levelsfilter.cpp (f45626e338f251d67ea3d36d1647157162c93d92)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request: InvertFilter: fix filter chaining

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103966/

In this big patch, you introduce a new filmtool for editor. What's the goal of this tool exactly ?

Gilles Caulier

- Gilles


On February 13th, 2012, 11:27 a.m., Matthias Welwarsky wrote:

Review request for Digikam.
By Matthias Welwarsky.

Updated Feb. 13, 2012, 11:27 a.m.

Description

Invert filter needs to export its target image, otherwise it does not work in slave mode.

Diffs

  • CMakeLists.txt (fccb0396ce146d68a319a90125ee80506aeaf64b)
  • imageplugins/color/CMakeLists.txt (c233b06e506a0a57633fe836303228953d66ff1b)
  • imageplugins/color/digikamimageplugin_color_ui.rc (757f091ba48e80fbd425ca0e0ddca59ec488c5d5)
  • imageplugins/color/filmtool.h (PRE-CREATION)
  • imageplugins/color/filmtool.cpp (PRE-CREATION)
  • imageplugins/color/imageplugin_color.h (07a3d89a7f64fb604e7ed782e8d10f5dbc4119d0)
  • imageplugins/color/imageplugin_color.cpp (8cb1f9532dbd7cc862533a81f519e9b7b21593f1)
  • libs/dimg/filters/film/filmfilter.h (PRE-CREATION)
  • libs/dimg/filters/film/filmfilter.cpp (PRE-CREATION)
  • libs/dimg/filters/levels/levelsfilter.h (217d95524dda6061c707e80a509e025e2bec28d5)
  • libs/dimg/filters/levels/levelsfilter.cpp (f45626e338f251d67ea3d36d1647157162c93d92)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel