Review Request: Do not hardcode ellipsis on splash screen messages

[Frederik Schwarzer]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101434/

Review request for Digikam.

By Frederik Schwarzer.

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101434/

Makes sense. After 2.0 not to break translations?

- Marcel

On May 24th, 2011, 6:35 p.m., Frederik Schwarzer wrote:

Review request for Digikam.

By Frederik Schwarzer.

Updated May 24, 2011, 6:35 p.m.

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Frederik Schwarzer]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101434/

On May 28th, 2011, 3:47 p.m., Marcel Wiesweg wrote:

Makes sense. After 2.0 not to break translations?

Sure, did not know about string freeze. Can you ping me here when string freeze is over?

- Frederik

On May 24th, 2011, 6:35 p.m., Frederik Schwarzer wrote:

Review request for Digikam.

By Frederik Schwarzer.

Updated May 24, 2011, 6:35 p.m.

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Frederik Schwarzer-2]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101434/

On May 28th, 2011, 3:47 p.m., Marcel Wiesweg wrote:

Makes sense. After 2.0 not to break translations?

On May 28th, 2011, 8:09 p.m., Frederik Schwarzer wrote:

Sure, did not know about string freeze. Can you ping me here when string freeze is over?

(ping) Can this go in now?

- Frederik

On May 24th, 2011, 6:35 p.m., Frederik Schwarzer wrote:

Review request for Digikam.

By Frederik Schwarzer.

Updated May 24, 2011, 6:35 p.m.

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101434/

On May 28th, 2011, 3:47 p.m., Marcel Wiesweg wrote:

Makes sense. After 2.0 not to break translations?

On May 28th, 2011, 8:09 p.m., Frederik Schwarzer wrote:

Sure, did not know about string freeze. Can you ping me here when string freeze is over?

On August 9th, 2011, 12:57 p.m., Frederik Schwarzer wrote:

(ping) Can this go in now?

yes, i review it now...

- Gilles

On May 24th, 2011, 6:35 p.m., Frederik Schwarzer wrote:

Review request for Digikam.

By Frederik Schwarzer.

Updated May 24, 2011, 6:35 p.m.

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101434/

On May 28th, 2011, 3:47 p.m., Marcel Wiesweg wrote:

Makes sense. After 2.0 not to break translations?

On May 28th, 2011, 8:09 p.m., Frederik Schwarzer wrote:

Sure, did not know about string freeze. Can you ping me here when string freeze is over?

On August 9th, 2011, 12:57 p.m., Frederik Schwarzer wrote:

(ping) Can this go in now?

On August 9th, 2011, 1:31 p.m., Gilles Caulier wrote:

yes, i review it now...

Patch applied to git master

- Gilles

On May 24th, 2011, 6:35 p.m., Frederik Schwarzer wrote:

Review request for Digikam.

By Frederik Schwarzer.

Updated May 24, 2011, 6:35 p.m.

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Frederik Schwarzer-2]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101434/

On May 28th, 2011, 3:47 p.m., Marcel Wiesweg wrote:

Makes sense. After 2.0 not to break translations?

On May 28th, 2011, 8:09 p.m., Frederik Schwarzer wrote:

Sure, did not know about string freeze. Can you ping me here when string freeze is over?

On August 9th, 2011, 12:57 p.m., Frederik Schwarzer wrote:

(ping) Can this go in now?

On August 9th, 2011, 1:31 p.m., Gilles Caulier wrote:

yes, i review it now...

On August 9th, 2011, 1:35 p.m., Gilles Caulier wrote:

Patch applied to git master

Thanks.
(If you add REVIEW: ###### to your commit message, requests are automatically closed and the revision is noted)

For the record: http://quickgit.kde.org/?p=digikam.git&a=commitdiff&h=78a2ee56bdd59a25d0bc46739244b694cb8ca5b0

- Frederik

On May 24th, 2011, 6:35 p.m., Frederik Schwarzer wrote:

Review request for Digikam.

By Frederik Schwarzer.

Updated May 24, 2011, 6:35 p.m.

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/101434/

Ship it!

Ship It!

- Gilles Caulier

On May 24th, 2011, 6:35 p.m. UTC, Frederik Schwarzer wrote:

Review request for Digikam.

By Frederik Schwarzer.

Updated May 24, 2011, 6:35 p.m.

Repository: digikam

Description

The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.

It seems more sane to let translators see that there is an ellipsis.

Testing

None. Sorry, I cannot compile on my box. :(

Diffs

• digikam/main/digikamapp.cpp (429fa5c)
• libs/widgets/common/splashscreen.cpp (78122ee)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel