digiKam › digikam-devel

Review Request 128927: Add namespace to desktop and appdata files

classic Classic list List threaded Threaded
♦
♦
 5 messages Options
Luigi Toscano
Reply | Threaded
Open this post in threaded view
♦
♦
|

Review Request 128927: Add namespace to desktop and appdata files

Luigi Toscano
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128927/

Review request for Digikam.
By Luigi Toscano.
Repository: digikam

Description 

- add the organization namespace to the desktop (and then appdata) files of digikam and showfoto.
- use the specific variable to find the directory of metadata (appstream) files.

Testing 

The code compiles  and the files are installed in the appropriate location.


The use of namespace is moving from "strongly suggested" to "mandatory"...

Diffs

  • app/CMakeLists.txt (2159d51)
  • app/main/digikam.appdata.xml (0a239f9)
  • app/main/digikam.desktop ()
  • showfoto/CMakeLists.txt (6bd490d)
  • showfoto/main/showfoto.appdata.xml (f04eae1)
  • showfoto/main/showfoto.desktop ()

View Diff
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 128927: Add namespace to desktop and appdata files

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128927/

Ship it! 

Ship It!

- Gilles Caulier


On September 16th, 2016, 10:15 p.m. UTC, Luigi Toscano wrote:

Review request for Digikam.
By Luigi Toscano.

Updated Sept. 16, 2016, 10:15 p.m.

Repository: digikam

Description 

- add the organization namespace to the desktop (and then appdata) files of digikam and showfoto.
- use the specific variable to find the directory of metadata (appstream) files.

Testing 

The code compiles  and the files are installed in the appropriate location.


The use of namespace is moving from "strongly suggested" to "mandatory"...

Diffs

  • app/CMakeLists.txt (2159d51)
  • app/main/digikam.appdata.xml (0a239f9)
  • app/main/digikam.desktop ()
  • showfoto/CMakeLists.txt (6bd490d)
  • showfoto/main/showfoto.appdata.xml (f04eae1)
  • showfoto/main/showfoto.desktop ()

View Diff
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 128927: Add namespace to desktop and appdata files

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128927/

On September 17th, 2016, 4:26 a.m. UTC, Gilles Caulier wrote:

Ship It!
What's the goal exactly of the XML data files ?

- Gilles


On September 16th, 2016, 10:15 p.m. UTC, Luigi Toscano wrote:

Review request for Digikam.
By Luigi Toscano.

Updated Sept. 16, 2016, 10:15 p.m.

Repository: digikam

Description 

- add the organization namespace to the desktop (and then appdata) files of digikam and showfoto.
- use the specific variable to find the directory of metadata (appstream) files.

Testing 

The code compiles  and the files are installed in the appropriate location.


The use of namespace is moving from "strongly suggested" to "mandatory"...

Diffs

  • app/CMakeLists.txt (2159d51)
  • app/main/digikam.appdata.xml (0a239f9)
  • app/main/digikam.desktop ()
  • showfoto/CMakeLists.txt (6bd490d)
  • showfoto/main/showfoto.appdata.xml (f04eae1)
  • showfoto/main/showfoto.desktop ()

View Diff
Luigi Toscano
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 128927: Add namespace to desktop and appdata files

Luigi Toscano
In reply to this post by Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128927/

On settembre 17th, 2016, 6:26 a.m. CEST, Gilles Caulier wrote:

Ship It!

On settembre 17th, 2016, 7:19 a.m. CEST, Gilles Caulier wrote:

What's the goal exactly of the XML data files ?
Generic metadata which are used by software center:
https://www.freedesktop.org/software/appstream/docs/

- Luigi


On settembre 17th, 2016, 12:15 a.m. CEST, Luigi Toscano wrote:

Review request for Digikam.
By Luigi Toscano.

Updated Set. 17, 2016, 12:15 a.m.

Repository: digikam

Description 

- add the organization namespace to the desktop (and then appdata) files of digikam and showfoto.
- use the specific variable to find the directory of metadata (appstream) files.

Testing 

The code compiles  and the files are installed in the appropriate location.


The use of namespace is moving from "strongly suggested" to "mandatory"...

Diffs

  • app/CMakeLists.txt (2159d51)
  • app/main/digikam.appdata.xml (0a239f9)
  • app/main/digikam.desktop ()
  • showfoto/CMakeLists.txt (6bd490d)
  • showfoto/main/showfoto.appdata.xml (f04eae1)
  • showfoto/main/showfoto.desktop ()

View Diff
Luigi Toscano
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 128927: Add namespace to desktop and appdata files

Luigi Toscano
In reply to this post by Luigi Toscano
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128927/

This change has been marked as submitted.

Review request for Digikam.
By Luigi Toscano.

Updated Sept. 17, 2016, 4:56 p.m.

Changes

Submitted with commit 741b1a98395b174a920ebfe9567994eeec648d8f by Luigi Toscano to branch master.
Repository: digikam

Description 

- add the organization namespace to the desktop (and then appdata) files of digikam and showfoto.
- use the specific variable to find the directory of metadata (appstream) files.

Testing 

The code compiles  and the files are installed in the appropriate location.


The use of namespace is moving from "strongly suggested" to "mandatory"...

Diffs

  • app/CMakeLists.txt (2159d51)
  • app/main/digikam.appdata.xml (0a239f9)
  • app/main/digikam.desktop ()
  • showfoto/CMakeLists.txt (6bd490d)
  • showfoto/main/showfoto.appdata.xml (f04eae1)
  • showfoto/main/showfoto.desktop ()

View Diff
Free forum by Nabble Edit this page