Review Request 126872: Fix database setting widget when mysql=on but internalmysql=off

[Xuetian Weng]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126872/

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Repository: digikam

Description

Basically the issue is DatabaseType enum value mismatch with dbType QComboBox index.
Add a new member dbTypeMap to help map enum value to index, and uses currentData() and itemData(index) when needed to get the actual enum value.

Testing

mysql enabled and internal mysql disabled, select database type mysql (experimental) from settings, UI updates correctly.

Diffs

• libs/database/utils/dbsettingswidget.cpp (668c36c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Xuetian Weng]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126872/

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Updated Jan. 24, 2016, 9:26 p.m.

Changes

some places miss dbTypeMap usage

Repository: digikam

Description

Basically the issue is DatabaseType enum value mismatch with dbType QComboBox index.
Add a new member dbTypeMap to help map enum value to index, and uses currentData() and itemData(index) when needed to get the actual enum value.

Testing

mysql enabled and internal mysql disabled, select database type mysql (experimental) from settings, UI updates correctly.

Diffs (updated)

• libs/database/utils/dbsettingswidget.cpp (668c36c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Xuetian Weng]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126872/

This change has been discarded.

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Updated Feb. 2, 2016, 12:24 p.m.

Repository: digikam

Description

Basically the issue is DatabaseType enum value mismatch with dbType QComboBox index.
Add a new member dbTypeMap to help map enum value to index, and uses currentData() and itemData(index) when needed to get the actual enum value.

Testing

mysql enabled and internal mysql disabled, select database type mysql (experimental) from settings, UI updates correctly.

Diffs

• libs/database/utils/dbsettingswidget.cpp (668c36c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel