Review Request 125881: Fix build without opencv_face

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request 125881: Fix build without opencv_face

Christoph Feck-2
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125881/

Review request for Digikam and Gilles Caulier.
By Christoph Feck.
Repository: digikam

Description

Two fixes:

  • if OpenCV is not installed, it previously aborted without displaying the summary, because CMake does not use shortcut-evaluation of "AND" expressions (the same fix has to be applied also to libkface)

  • remove checking for "opencv_face", because it is not needed in digikam

Testing

Compiles.

Diffs

  • CMakeLists.txt (f9612ff)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 125881: Fix build without opencv_face

Christoph Feck-2
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125881/

This change has been marked as submitted.


Review request for Digikam and Gilles Caulier.
By Christoph Feck.

Updated Oct. 30, 2015, 1:10 p.m.

Changes

Submitted with commit d933879a27de36dc2753961c1800150a4f3eb3cc by Gilles Caulier to branch master.
Repository: digikam

Description

Two fixes:

  • if OpenCV is not installed, it previously aborted without displaying the summary, because CMake does not use shortcut-evaluation of "AND" expressions (the same fix has to be applied also to libkface)

  • remove checking for "opencv_face", because it is not needed in digikam

Testing

Compiles.

Diffs

  • CMakeLists.txt (f9612ff)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel